Skip to contentSkip to conversation

rust: alloc: add __GFP_HIGHMEM flag

PATCH Applied Alice Ryhl 2 participants 2 messages Jun 7, 2024 – Jul 9, 2024

Subsystems (3)
Memory management Rust Rust alloc
lore
Share & tools
lore

Alice Ryhl

author maintainer
#0 lore raw

PATCH 1/1 rust: alloc: add __GFP_HIGHMEM flag

Make it possible to allocate memory that doesn't need to mapped into the kernel's address space. This flag is useful together with Page::alloc_page [1].

Rust Binder needs this for the memory that holds incoming transactions for each process. Each process will have a few megabytes of memory allocated with this flag, which is mapped into the process using vm_insert_page. When the kernel copies data for an incoming transaction into a process's memory region, it will use kmap_local_page to temporarily map pages that are being modified. There is no need for them to take up address space in the kernel when the kernel is not writing an incoming transaction into the page.

Link https://lore.kernel.org/all/[email protected]/ [1] open here
Signed-off-by Alice Ryhl <[email protected]>
---
 rust/bindings/bindings_helper.h | 1 +
 rust/kernel/alloc.rs            | 8 ++++++++
 2 files changed, 9 insertions(+)
rust/bindings/bindings_helper.h +1 -0
index ddb5644d4fd9..52a1412338ef 100644
@@ -25,3 +25,4 @@ const gfp_t RUST_CONST_HELPER_GFP_KERNEL = GFP_KERNEL;
 const gfp_t RUST_CONST_HELPER_GFP_KERNEL_ACCOUNT = GFP_KERNEL_ACCOUNT;
 const gfp_t RUST_CONST_HELPER_GFP_NOWAIT = GFP_NOWAIT;
 const gfp_t RUST_CONST_HELPER___GFP_ZERO = __GFP_ZERO;
+const gfp_t RUST_CONST_HELPER___GFP_HIGHMEM = ___GFP_HIGHMEM;
rust/kernel/alloc.rs +8 -0
index 531b5e471cb1..f2994aea5d8e 100644
@@ -52,6 +52,14 @@ pub mod flags {
     /// This is normally or'd with other flags.
     pub const __GFP_ZERO: Flags = Flags(bindings::__GFP_ZERO);
 
+    /// Allow the allocation to be in high memory.
+    ///
+    /// Allocations in high memory may not be mapped into the kernel's address space, so this can't
+    /// be used with `kmalloc` and other similar methods.
+    ///
+    /// This is normally or'd with other flags.
+    pub const __GFP_HIGHMEM: Flags = Flags(bindings::__GFP_HIGHMEM);
+
     /// Users can not sleep and need the allocation to succeed.
     ///
     /// A lower watermark is applied to allow access to "atomic reserves". The current

---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240417-highmem-dbadd159be11

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>
Applied
#1 lore raw
Quoted 14 lines · Alice Ryhl

Make it possible to allocate memory that doesn't need to mapped into the kernel's address space. This flag is useful together with Page::alloc_page [1].

Rust Binder needs this for the memory that holds incoming transactions for each process. Each process will have a few megabytes of memory allocated with this flag, which is mapped into the process using vm_insert_page. When the kernel copies data for an incoming transaction into a process's memory region, it will use kmap_local_page to temporarily map pages that are being modified. There is no need for them to take up address space in the kernel when the kernel is not writing an incoming transaction into the page.

Quoted 2 lines
Link https://lore.kernel.org/all/[email protected]/ [1] open here
Signed-off-by Alice Ryhl <[email protected]>

Applied to rust-next, thanks!

Cheers,
Miguel