modpost: bypass module description test on vmlinux.o
Subsystems (2)
PATCH 1/1 modpost: bypass module description test on vmlinux.o
When building modules with W=1, modpost will warn if a module is missing a MODULE_DESCRIPTION. Unfortunately, it also performs this test on vmlinux.o:
WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
Relocate the logic so that the test is not performed on vmlinux.o.
--- scripts/mod/modpost.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
scripts/mod/modpost.c +3 -2
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname) namespace =get_next_modinfo (&info,"import_ns" , namespace); } + +if (extra_warn && !get_modinfo (&info,"description" )) +warn ("missing MODULE_DESCRIPTION() in %s\n" , modname); } -if (extra_warn && !get_modinfo (&info,"description" )) -warn ("missing MODULE_DESCRIPTION() in %s\n" , modname);for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { symname =remove_dot (info.strtab + sym->st_name);
---
base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
change-id: 20240607-md-scripts-mod-7f7ff091e02b
Quoted 11 lines · Jeff Johnson
When building modules with W=1, modpost will warn if a module is missing a
MODULE_DESCRIPTION. Unfortunately, it also performs this test on vmlinux.o:WARNING: modpost: missing
MODULE_DESCRIPTION()in vmlinux.oRelocate the logic so that the test is not performed on vmlinux.o.
Fixes 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")Signed-off-by Jeff Johnson <[email protected]>---
Hi Jeff,
you're a few hours too late:
https://lore.kernel.org/linux-kbuild/[email protected]/
Kind regards,
Nicolas
Quoted 27 lines
scripts/mod/modpost.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)scripts/mod/modpost.c +3
-3@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname) namespace =get_next_modinfo (&info,"import_ns" , namespace); } + +if (extra_warn && !get_modinfo (&info,"description" )) +warn ("missing MODULE_DESCRIPTION() in %s\n" , modname); } -if (extra_warn && !get_modinfo (&info,"description" )) -warn ("missing MODULE_DESCRIPTION() in %s\n" , modname);for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { symname =remove_dot (info.strtab + sym->st_name); ---base-commit:
19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
change-id: 20240607-md-scripts-mod-7f7ff091e02b
Signature · 3 lines
epost|xmpp: [email protected] irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap --
Quoted 9 lines · Nicolas Schier
Quoted 8 lines · Jeff Johnson
When building modules with W=1, modpost will warn if a module is missing a
MODULE_DESCRIPTION. Unfortunately, it also performs this test on vmlinux.o:WARNING: modpost: missing
MODULE_DESCRIPTION()in vmlinux.oRelocate the logic so that the test is not performed on vmlinux.o.
Quoted 9 lines
Quoted 3 lines
Fixes 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")Signed-off-by Jeff Johnson <[email protected]>---
Hi Jeff,
you're a few hours too late:
https://lore.kernel.org/linux-kbuild/[email protected]/
:)