Skip to contentSkip to conversation

media: c8sectpfe: Add missing parameter names

PATCH In review Ricardo Ribalda 2 participants 2 messages Jun 6, 2024 – Jun 7, 2024 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: c8sectpfe: Add missing parameter names

clang 19 complains about the missing parameter name. Let's add it.

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]

Fixes e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
---
 drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h +2 -2
index 8e1bfd860524..3fe177b59b16 100644
@@ -16,8 +16,8 @@
 void c8sectpfe_debugfs_init(struct c8sectpfei *);
 void c8sectpfe_debugfs_exit(struct c8sectpfei *);
 #else
-static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
-static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
+static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
+static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
 #endif
 
 #endif /* __C8SECTPFE_DEBUG_H */

---
base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
change-id: 20240606-c8sectpfe-5f00b9867f36

Best regards,

Signature · 1 line
Ricardo Ribalda <[email protected]>
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ricardo Ribalda

clang 19 complains about the missing parameter name. Let's add it.

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]

Fixes e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
Quoted 28 lines
---
 drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h +2 -3
index 8e1bfd860524..3fe177b59b16 100644
@@ -16,8 +16,8 @@
 void c8sectpfe_debugfs_init(struct c8sectpfei *);
 void c8sectpfe_debugfs_exit(struct c8sectpfei *);
 #else
-static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
-static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
+static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
+static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
 #endif
 
 #endif /* __C8SECTPFE_DEBUG_H */
 
---

base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
change-id: 20240606-c8sectpfe-5f00b9867f36

Best regards,

Signature · 1 line
Ricardo Ribalda <[email protected]>