Skip to contentSkip to conversation

selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()

PATCH Applied Donet Tom 3 participants 3 messages Jun 7, 2024

Subsystems (3)
lore
Share & tools
lore

Donet Tom

author
#0 lore raw

PATCH v4 1/1 selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()

Commit 1b151e2435fc ("block: Remove special-casing of compound pages") caused a change in behaviour when releasing the pages if the buffer does not start at the beginning of the page. This was because the calculation of the number of pages to release was incorrect.
This was fixed by commit 38b43539d64b ("block: Fix page refcounts for unaligned buffers in __bio_release_pages()").

We pin the user buffer during direct I/O writes. If this buffer is a hugepage, bio_release_page() will unpin it and decrement all references and pin counts at ->bi_end_io. However, if any references to the hugepage remain post-I/O, the hugepage will not be freed upon unmap, leading to a memory leak.

This patch verifies that a hugepage, used as a user buffer for DIO operations, is correctly freed upon unmapping, regardless of whether the offsets are aligned or unaligned w.r.t page boundary.

Test Result Fail Scenario (Without the fix)
--------------------------------------------------------
[]# ./hugetlb_dio
TAP version 13
1..4
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 1 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 2 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 3 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 6
not ok 4 : Huge pages not freed!
Totals: pass:3 fail:1 xfail:0 xpass:0 skip:0 error:0

Test Result PASS Scenario (With the fix)
---------------------------------------------------------
[]#./hugetlb_dio
TAP version 13
1..4
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 1 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 2 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 3 : Huge pages freed successfully !
No. Free pages before allocation : 7
No. Free pages after munmap : 7
ok 4 : Huge pages freed successfully !
Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0

V4:
- Added this test to run_vmtests.sh.

V3:
- Fixed the build error when it is compiled with _FORTIFY_SOURCE.

V2:
- Addressed all review commets from Muhammad Usama Anjum
https://lore.kernel.org/all/[email protected]/

V1:
https://lore.kernel.org/all/[email protected]/#t

---
 tools/testing/selftests/mm/Makefile       |   1 +
 tools/testing/selftests/mm/hugetlb_dio.c  | 118 ++++++++++++++++++++++
 tools/testing/selftests/mm/run_vmtests.sh |   1 +
 3 files changed, 120 insertions(+)
 create mode 100644 tools/testing/selftests/mm/hugetlb_dio.c
tools/testing/selftests/mm/Makefile +1 -0
index 3b49bc3d0a3b..a1748a4c7df1 100644
@@ -73,6 +73,7 @@ TEST_GEN_FILES += ksm_functional_tests
 TEST_GEN_FILES += mdwe_test
 TEST_GEN_FILES += hugetlb_fault_after_madv
 TEST_GEN_FILES += hugetlb_madv_vs_map
+TEST_GEN_FILES += hugetlb_dio
 
 ifneq ($(ARCH),arm64)
 TEST_GEN_FILES += soft-dirty
tools/testing/selftests/mm/hugetlb_dio.c new file +118 -0

118 lines not on this page · raw message

tools/testing/selftests/mm/run_vmtests.sh +1 -0
index 3157204b9047..5698d519170d 100755
@@ -265,6 +265,7 @@ CATEGORY="hugetlb" run_test ./map_hugetlb
 CATEGORY="hugetlb" run_test ./hugepage-mremap
 CATEGORY="hugetlb" run_test ./hugepage-vmemmap
 CATEGORY="hugetlb" run_test ./hugetlb-madvise
+CATEGORY="hugetlb" run_test ./hugetlb_dio
 
 nr_hugepages_tmp=$(cat /proc/sys/vm/nr_hugepages)
 # For this test, we need one and just one huge page
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 2 lines · On Fri, 7 Jun 2024 13:20:00 -0500 Donet Tom <[email protected]> wrote:

V4:
- Added this test to run_vmtests.sh.

v4 also contains this change:

tools/testing/selftests/mm/hugetlb_dio.c renamed from tools/testing/selftests/mm/hugetlb_dio.c~selftest-mm-test-if-hugepage-does-not-get-leaked-during-__bio_release_pages-v4 +1 -1
@@ -40,7 +40,7 @@ void run_dio_using_hugetlb(unsigned int
 		ksft_exit_fail_msg("Unable to determine huge page size\n");
 
 	/* Open the file to DIO */
-	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT);
+	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664);
 	if (fd < 0)
 		ksft_exit_fail_perror("Error opening file\n");
 
#2 lore raw
Quoted 6 lines · Andrew Morton
Quoted 2 lines · On Fri, 7 Jun 2024 13:20:00 -0500 Donet Tom <[email protected]> wrote:

V4:
- Added this test to run_vmtests.sh.

v4 also contains this change:

I think v3 already had these changes [1]

V3:
- Fixed the build error when it is compiled with _FORTIFY_SOURCE.

[1] https://lore.kernel.org/linux-kselftest/[email protected]/

Quoted 13 lines
tools/testing/selftests/mm/hugetlb_dio.c renamed from tools/testing/selftests/mm/hugetlb_dio.c~selftest-mm-test-if-hugepage-does-not-get-leaked-during-__bio_release_pages-v4 +1 -1
@@ -40,7 +40,7 @@ void run_dio_using_hugetlb(unsigned int
 		ksft_exit_fail_msg("Unable to determine huge page size\n");
 
 	/* Open the file to DIO */
-	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT);
+	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664);
 	if (fd < 0)
 		ksft_exit_fail_perror("Error opening file\n");