drm/i915/display: Send vrr vsync params whne vrr is enabled
Subsystems (3)
PATCH 1/1 drm/i915/display: Send vrr vsync params whne vrr is enabled
Compute trans vrr vsync params only when either VRR or CMRR is enabled.
--- drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_vrr.c +2 -1
@@ -232,7 +232,8 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state, crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; } -if (intel_dp_as_sdp_supported (intel_dp)) { +if (intel_dp_as_sdp_supported (intel_dp) && + crtc_state->vrr.enable) { crtc_state->vrr.vsync_start = (crtc_state->hw.adjusted_mode.crtc_vtotal - crtc_state->hw.adjusted_mode.vsync_start);
Signature · 1 line
2.45.2
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Send vrr vsync params whne vrr is enabled
== Series Details ==
== Series Details ==
Series: drm/i915/display: Send vrr vsync params whne vrr is enabled
URL : https://patchwork.freedesktop.org/series/134714/
State : warning
== Summary ==
Error: dim checkpatch failed
711332181393 drm/i915/display: Send vrr vsync params whne vrr is enabled -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #26: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:236:
+ if (intel_dp_as_sdp_supported(intel_dp) &&
+ crtc_state->vrr.enable) {
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
Jani Nikula
maintainerRe: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Send vrr vsync params whne vrr is enabled
Quoted 12 lines · Patchwork
== Series Details ==
Series: drm/i915/display: Send vrr vsync params whne vrr is enabled
URL : https://patchwork.freedesktop.org/series/134714/
State : warning== Summary ==
Error: dim checkpatch failed
711332181393 drm/i915/display: Send vrr vsync params whne vrr is enabled -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #26: FILE:drivers/gpu/drm/i915/display/intel_vrr.c:236:
drivers/gpu/drm/i915/display/intel_vrr.c intel_vrr_compute_config(struct intel_crtc_state *crtc_state, · line 236
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_vrr.c +2
-0+if (intel_dp_as_sdp_supported (intel_dp) && + crtc_state->vrr.enable) {
Please fix this.
Quoted 4 lines
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
Signature · 1 line
Jani Nikula, Intel
RE: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Send vrr vsync params whne vrr is enabled
Hi @Jani Nikula
Quoted 20 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Friday, June 14, 2024 1:09 PM
To: Patchwork <[email protected]>; Golani, Mitulkumar Ajitkumar <[email protected]>
Cc: [email protected]
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Send vrr vsync params whne vrr is enabledQuoted 10 lines · Patchwork
== Series Details ==
Series: drm/i915/display: Send vrr vsync params whne vrr is enabled
URL : https://patchwork.freedesktop.org/series/134714/
State : warning== Summary ==
Error: dim checkpatch failed
711332181393 drm/i915/display: Send vrr vsync params whne vrr is
Quoted 8 lines
enabled
Quoted 1 line
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
parenthesis
drivers/gpu/drm/i915/display/intel_vrr.c intel_vrr_compute_config(struct intel_crtc_state *crtc_state, · line 236
Quoted 3 lines
#26: FILE:
drivers/gpu/drm/i915/display/intel_vrr.c:236:drivers/gpu/drm/i915/display/intel_vrr.c +2
-0+if (intel_dp_as_sdp_supported (intel_dp) && + crtc_state->vrr.enable) {Please fix this.
I fixed into next revision and got merged.
https://patchwork.freedesktop.org/patch/598089/?series=134714&rev=2
Thanks,
Mitul
Quoted 9 lines
Quoted 6 lines
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
--
Jani Nikula, Intel
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/display: Send vrr vsync params whne vrr is enabled
In reply to Mitul Golani== Series Details ==
== Series Details ==
Series: drm/i915/display: Send vrr vsync params whne vrr is enabled
URL : https://patchwork.freedesktop.org/series/134714/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14919 -> Patchwork_134714v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/index.html
Participating hosts (43 -> 40)
------------------------------
Additional (1): bat-arlh-2
Missing (4): fi-glk-j4005 bat-dg2-11 bat-adlp-6 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_134714v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@fbdev@eof:
- {bat-arlh-2}: NOTRUN -> [SKIP][1] +38 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/bat-arlh-2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_134714v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- {bat-twl-1}: [INCOMPLETE][2] ([i915#10886]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14919/bat-twl-1/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/bat-twl-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@hangcheck:
- bat-adlp-9: [ABORT][4] ([i915#10021]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14919/bat-adlp-9/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/bat-adlp-9/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@late_gt_pm:
- bat-arls-1: [DMESG-WARN][6] ([i915#10341]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14919/bat-arls-1/igt@i915_selftest@live@late_gt_pm.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/bat-arls-1/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-6:
- {bat-mtlp-9}: [DMESG-WARN][8] ([i915#11009]) -> [PASS][9] +2 other tests pass
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14919/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10021]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10021
[i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
[i915#10580]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10580
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10886
[i915#10911]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10911
[i915#10979]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10979
[i915#11009]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11009
[i915#11060]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11060
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#6121]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6121
[i915#9159]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9159
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
Build changes
-------------
* Linux: CI_DRM_14919 -> Patchwork_134714v1
CI-20190529: 20190529
CI_DRM_14919: 46852067df1514110bfc9c514d2610447376f1b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7880: 73618605b4370cf902267aaf1d25666ff5e26112 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_134714v1: 46852067df1514110bfc9c514d2610447376f1b7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134714v1/index.html