Skip to contentSkip to conversation

linux-yocto-dev: fix build

PATCH In review Trevor Woerner 3 participants 7 messages Jun 11, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-yocto-dev: fix build

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Disabling some filesystem-related security options fixes the build.

---
 recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
 .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
 2 files changed, 6 insertions(+)
 create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
index b6a63d7b7b29..94bf737c63bd 100644
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
 COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
 
+SRC_URI:append = " file://disable-some-fs-security.cfg"
 SRC_URI:append:orangepi-5-plus = " file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta"
recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg new file +5 -0
new file mode 100644
index 000000000000..dd2e894eed76
@@ -0,0 +1,5 @@
+CONFIG_SECURITYFS=n
+CONFIG_SECURITY_NETWORK=y
+CONFIG_SECURITY_NETWORK_XFRM=n
+CONFIG_SECURITY_PATH=y
+CONFIG_SECURITY_LANDLOCK=y
Signature · 1 line
2.44.0.478.g7774cfed6261
#1 lore raw

Hi Trevor,

Quoted 5 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

Quoted 12 lines
---
  recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
  .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
  2 files changed, 6 insertions(+)

create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg

recipes-kernel/linux/linux-yocto-dev.bbappend +0 -0
index b6a63d7b7b29..94bf737c63bd 100644

recipes-kernel/linux/linux-yocto-dev.bbappend FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" · line 5

Quoted 4 lines
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
  COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
 
+SRC_URI:append = " file://disable-some-fs-security.cfg"

If it is Rockchip-specific, I would suggest using SRC_URI:append:rockchip here, to make sure we do not modify other machines from other layers whenever meta-rockchip is included?

Cheers,
Quentin

#2 lore raw
Quoted 10 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 5 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

This builds fine with qemuarm64, for example. Comparing the .config from the qemuarm64 build vs the rockchip build is what led me to the patch that I've presented. The qemuarm64 build doesn't try to build the file that causes the error since its .config doesn't ask it to. We're using the in-kernel defconfig for the rockchip build so:
1) it's strange nobody else has seen/fixed this
2) why doesn't the qemuarm64 build use the in-kernel defconfig (or if it does, why are these options not set in its .config)?

Quoted 2 lines

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

I guess I could give him a poke.

Quoted 7 lines
Quoted 7 lines
---
  recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
  .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
  2 files changed, 6 insertions(+)

create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg

Quoted 11 lines

recipes-kernel/linux/linux-yocto-dev.bbappend FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" · line 3

Quoted 7 lines
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
index b6a63d7b7b29..94bf737c63bd 100644
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
  COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
+SRC_URI:append = " file://disable-some-fs-security.cfg"

If it is Rockchip-specific, I would suggest using SRC_URI:append:rockchip here, to make sure we do not modify other machines from other layers whenever meta-rockchip is included?

Oh right, thanks. I don't think of that use-case often enough.

#3 lore raw
Quoted 13 lines · Trevor Woerner
Quoted 10 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 5 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

Quoted 8 lines

This builds fine with qemuarm64, for example. Comparing the .config from the qemuarm64 build vs the rockchip build is what led me to the patch that I've presented. The qemuarm64 build doesn't try to build the file that causes the error since its .config doesn't ask it to. We're using the in-kernel defconfig for the rockchip build so:
1) it's strange nobody else has seen/fixed this
2) why doesn't the qemuarm64 build use the in-kernel defconfig (or if it does, why are these options not set in its .config)?

Hah. Let's not start the in-tree defconfig bikeshed debate.

There's a yocto reference configuration, it will not, and does not strictly follow anything in-tree. If someone does see things in a defconfig they want represented in the machine or base configuration, they are free to propose them as patches and they'll be considered on individual merit.

Quoted 5 lines
Quoted 3 lines

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

I guess I could give him a poke.

See my reply from just a few minutes ago.

Bruce

Quoted 21 lines
Quoted 8 lines
Quoted 8 lines
---
  recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
  .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
  2 files changed, 6 insertions(+)

create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg

Quoted 11 lines

recipes-kernel/linux/linux-yocto-dev.bbappend FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" · line 3

Quoted 7 lines
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
index b6a63d7b7b29..94bf737c63bd 100644
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
  COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
+SRC_URI:append = " file://disable-some-fs-security.cfg"

If it is Rockchip-specific, I would suggest using SRC_URI:append:rockchip here, to make sure we do not modify other machines from other layers whenever meta-rockchip is included?

Oh right, thanks. I don't think of that use-case often enough.

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#4 lore raw
In reply to Quentin Schulz
Quoted 7 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 3 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Quoted 7 lines
Quoted 2 lines

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

Ross had mentioned something like this a week or so ago, but I haven't seen it locally yet.

It's an aufs6 export that is causing the issue, I'm looking into it now.

Preferably I need to reproduce it on the qemuarm machines, so I can be sure of the fix.

Bruce

Quoted 35 lines
Quoted 13 lines
---
  recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
  .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
  2 files changed, 6 insertions(+)

create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg

recipes-kernel/linux/linux-yocto-dev.bbappend +0 -0
index b6a63d7b7b29..94bf737c63bd 100644

recipes-kernel/linux/linux-yocto-dev.bbappend FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" · line 5

Quoted 4 lines
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
  COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
 
+SRC_URI:append = " file://disable-some-fs-security.cfg"

If it is Rockchip-specific, I would suggest using SRC_URI:append:rockchip here, to make sure we do not modify other machines from other layers whenever meta-rockchip is included?

Cheers,
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#300): https://lists.yoctoproject.org/g/yocto-patches/message/300
Mute This Topic: https://lists.yoctoproject.org/mt/106613842/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13171493/1050810/607820704/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#5 lore raw
Quoted 16 lines · Bruce Ashfield
Quoted 12 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 5 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

Quoted 8 lines
Quoted 2 lines

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

Ross had mentioned something like this a week or so ago, but I haven't seen it locally yet.

It's an aufs6 export that is causing the issue, I'm looking into it now.

I see the issue with the exports. One slipped outside of an ifdef and is causing issues.

It should all be fixed shortly.

Bruce

Quoted 47 lines

Preferably I need to reproduce it on the qemuarm machines, so I can be sure of the fix.

Bruce

Quoted 26 lines
Quoted 13 lines
---
  recipes-kernel/linux/linux-yocto-dev.bbappend                | 1 +
  .../linux/linux-yocto-dev/disable-some-fs-security.cfg       | 5 +++++
  2 files changed, 6 insertions(+)

create mode 100644 recipes-kernel/linux/linux-yocto-dev/disable-some-fs-security.cfg

recipes-kernel/linux/linux-yocto-dev.bbappend +0 -0
index b6a63d7b7b29..94bf737c63bd 100644

recipes-kernel/linux/linux-yocto-dev.bbappend FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" · line 5

Quoted 4 lines
recipes-kernel/linux/linux-yocto-dev.bbappend +1 -0
@@ -2,4 +2,5 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
  COMPATIBLE_MACHINE:orangepi-5-plus = "orangepi-5-plus"
 
+SRC_URI:append = " file://disable-some-fs-security.cfg"

If it is Rockchip-specific, I would suggest using SRC_URI:append:rockchip here, to make sure we do not modify other machines from other layers whenever meta-rockchip is included?

Cheers,
Quentin

Quoted 9 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#300): https://lists.yoctoproject.org/g/yocto-patches/message/300
Mute This Topic: https://lists.yoctoproject.org/mt/106613842/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13171493/1050810/607820704/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#6 lore raw
Quoted 24 lines · Bruce Ashfield via lists.yoctoproject.org
Quoted 22 lines · Bruce Ashfield
Quoted 7 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 3 lines · Trevor Woerner via lists.yoctoproject.org

The linux-yocto-dev build was failing with:
| ERROR: modpost: vmlinux: local symbol 'security_path_rmdir' was exported

Quoted 7 lines
Quoted 2 lines

Disabling some filesystem-related security options fixes the build.

Is this the case for every board, including non-Rockchip ones?

Is Bruce aware of those issues? Shouldn't this rather be fixed in oe-core instead?

Ross had mentioned something like this a week or so ago, but I haven't seen it locally yet.

Quoted 7 lines
Quoted 2 lines

It's an aufs6 export that is causing the issue, I'm looking into it now.

I see the issue with the exports. One slipped outside of an ifdef and is causing issues.

It should all be fixed shortly.

w00t! Thanks :-)