misc: microchip: pci1xxxx: Fix return value of nvmem callbacks
Subsystems (4)
PATCH 1/1 misc: microchip: pci1xxxx: Fix return value of nvmem callbacks
Read/write callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure.
Currently pci1xxxx_otp_read()/pci1xxxx_otp_write() and pci1xxxx_eeprom_read()/pci1xxxx_eeprom_write() return the number of bytes read/written on success.
Fix to return 0 on success.
Fixes 9ab5465349c0 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX EEPROM via NVMEM sysfs")
Fixes 0969001569e4 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX OTP via NVMEM sysfs")
Signed-off-by Joy Chakraborty <[email protected]>
--- drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_otpe2p.c +0 -4
@@ -153,7 +153,6 @@ static int pci1xxxx_eeprom_read(void *priv_t, unsigned int off, buf[byte] =readl (rb +MMAP_EEPROM_OFFSET (EEPROM_DATA_REG )); } - ret = byte; error:release_sys_lock (priv);return ret;
@@ -197,7 +196,6 @@ static int pci1xxxx_eeprom_write(void *priv_t, unsigned int off, goto error; } } - ret = byte; error:release_sys_lock (priv);return ret;
@@ -258,7 +256,6 @@ static int pci1xxxx_otp_read(void *priv_t, unsigned int off, buf[byte] =readl (rb +MMAP_OTP_OFFSET (OTP_RD_DATA_OFFSET )); } - ret = byte; error:release_sys_lock (priv);return ret;
@@ -315,7 +312,6 @@ static int pci1xxxx_otp_write(void *priv_t, unsigned int off, goto error; } } - ret = byte; error:release_sys_lock (priv);return ret;
Signature · 1 line
2.45.2.505.gda0bf45e8d-goog
Quoted 8 lines · Joy Chakraborty
Read/write callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure.
Currently pci1xxxx_otp_read()/pci1xxxx_otp_write() and pci1xxxx_eeprom_read()/pci1xxxx_eeprom_write() return the number of bytes read/written on success.
Fix to return 0 on success.
Quoted 4 lines
Fixes 9ab5465349c0 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX EEPROM via NVMEM sysfs")Fixes 0969001569e4 ("misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX OTP via NVMEM sysfs")Signed-off-by Joy Chakraborty <[email protected]>
Thanks!
Reviewed-by Dan Carpenter <[email protected]>
regards,
dan carpenter