mm: ratelimit stat flush from workingset shrinker
Subsystems (3)
PATCH 1/1 mm: ratelimit stat flush from workingset shrinker
From: Shakeel Butt <[email protected]>
commit d4a5b369ad6d8aae552752ff438dddde653a72ec upstream.
One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the count_shadow_nodes() added by the commit f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path.
---
On production with kernel v6.6 we are observing issues with excessive cgroup rstat flushing due to the extra call to mem_cgroup_flush_stats() in count_shadow_nodes() introduced in commit f82e6bf9bb9b ("mm: memcg:
use rstat for non-hierarchical stats") that commit is part of v6.6. We request backport of commit d4a5b369ad6d ("mm: ratelimit stat flush from workingset shrinker") as it have a fixes tag for this commit.
IMHO it is worth explaining call path that makes count_shadow_nodes() cause excessive cgroup rstat flushing calls. Function shrink_node() calls mem_cgroup_flush_stats() on its own first, and then invokes shrink_node_memcgs(). Function shrink_node_memcgs() iterates over cgroups via mem_cgroup_iter() for each calling shrink_slab(). The shrink_slab() calls do_shrink_slab() that via shrinker->count_objects() invoke count_shadow_nodes(), and count_shadow_nodes() does
a mem_cgroup_flush_stats() call, that seems unnecessary.
Backport differs slightly due to v6.6.32 doesn't contain commit 7d7ef0a4686a ("mm: memcg: restore subtree stats flushing") from v6.8.
--- mm/workingset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/workingset.c +1 -1
@@ -664,7 +664,7 @@ static unsigned long count_shadow_nodes(struct shrinker *shrinker,struct lruvec *lruvec;int i; -mem_cgroup_flush_stats (); +mem_cgroup_flush_stats_ratelimited (); lruvec =mem_cgroup_lruvec (sc->memcg,NODE_DATA (sc->nid));for (pages =0 , i =0 ; i <NR_LRU_LISTS ; i++) pages += lruvec_page_state_local(lruvec,
Quoted 34 lines · Jesper Dangaard Brouer
From: Shakeel Butt <[email protected]>
commit
d4a5b369ad6d8aae552752ff438dddde653a72ecupstream.One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the
count_shadow_nodes()added by the commitf82e6bf9bb9b("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path.Fixes f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats")Signed-off-by Shakeel Butt <[email protected]>Cc Johannes Weiner <[email protected]>Cc Yosry Ahmed <[email protected]>Cc Yu Zhao <[email protected]>Cc Michal Hocko <[email protected]>Cc Roman Gushchin <[email protected]>Cc Muchun Song <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Jesper Dangaard Brouer <[email protected]>---
On production with kernel v6.6 we are observing issues with excessive cgroup rstat flushing due to the extra call tomem_cgroup_flush_stats()incount_shadow_nodes()introduced in commitf82e6bf9bb9b("mm: memcg:
use rstat for non-hierarchical stats") that commit is part of v6.6. We request backport of commitd4a5b369ad6d("mm: ratelimit stat flush from workingset shrinker") as it have a fixes tag for this commit.
Quoted 9 lines
IMHO it is worth explaining call path that makes
count_shadow_nodes()cause excessive cgroup rstat flushing calls. Functionshrink_node()callsmem_cgroup_flush_stats()on its own first, and then invokesshrink_node_memcgs(). Functionshrink_node_memcgs()iterates over cgroups viamem_cgroup_iter()for each callingshrink_slab(). Theshrink_slab()callsdo_shrink_slab()that viashrinker->count_objects()invokecount_shadow_nodes(), andcount_shadow_nodes()does
amem_cgroup_flush_stats()call, that seems unnecessary.
Actually at Meta production we have also replaced mem_cgroup_flush_stats() in shrink_node() with mem_cgroup_flush_stats_ratelimited() as it was causing too much flushing issue. We have not observed any issue after the change. I will propose that patch to upstream as well.
Quoted 45 lines · Shakeel Butt
Quoted 34 lines · Jesper Dangaard Brouer
From: Shakeel Butt <[email protected]>
commit
d4a5b369ad6d8aae552752ff438dddde653a72ecupstream.One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the
count_shadow_nodes()added by the commitf82e6bf9bb9b("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path.Fixes f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats")Signed-off-by Shakeel Butt <[email protected]>Cc Johannes Weiner <[email protected]>Cc Yosry Ahmed <[email protected]>Cc Yu Zhao <[email protected]>Cc Michal Hocko <[email protected]>Cc Roman Gushchin <[email protected]>Cc Muchun Song <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Jesper Dangaard Brouer <[email protected]>---
On production with kernel v6.6 we are observing issues with excessive cgroup rstat flushing due to the extra call tomem_cgroup_flush_stats()incount_shadow_nodes()introduced in commitf82e6bf9bb9b("mm: memcg:
use rstat for non-hierarchical stats") that commit is part of v6.6. We request backport of commitd4a5b369ad6d("mm: ratelimit stat flush from workingset shrinker") as it have a fixes tag for this commit.Quoted 9 lines
IMHO it is worth explaining call path that makes
count_shadow_nodes()cause excessive cgroup rstat flushing calls. Functionshrink_node()callsmem_cgroup_flush_stats()on its own first, and then invokesshrink_node_memcgs(). Functionshrink_node_memcgs()iterates over cgroups viamem_cgroup_iter()for each callingshrink_slab(). Theshrink_slab()callsdo_shrink_slab()that viashrinker->count_objects()invokecount_shadow_nodes(), andcount_shadow_nodes()does
amem_cgroup_flush_stats()call, that seems unnecessary.
Quoted 5 lines
Actually at Meta production we have also replaced
mem_cgroup_flush_stats()inshrink_node()withmem_cgroup_flush_stats_ratelimited()as it was causing too much flushing issue. We have not observed any issue after the change. I will propose that patch to upstream as well.
(Please Cc me as I'm not subscribed on [email protected])
Yes, we also see mem_cgroup_flush_stats() in shrink_node() cause issues.
So, I can confirm the issue. What we see is that it originates from kswapd, which have a kthread per NUMA node that runs concurrently... we measure cgroup rstat lock contention happening due to call in shrink_node().
See call stacks I captured with bpftrace script[1]:
stack_wait[695, kswapd0, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[696, kswapd1, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[697, kswapd2, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[698, kswapd3, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[699, kswapd4, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[700, kswapd5, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[701, kswapd6, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27
@stack_wait[702, kswapd7, 1]:
__cgroup_rstat_lock+107
__cgroup_rstat_lock+107
cgroup_rstat_flush_locked+851
cgroup_rstat_flush+35
shrink_node+226
balance_pgdat+807
kswapd+521
kthread+228
ret_from_fork+48
ret_from_fork_asm+27--Jesper
[1] https://github.com/xdp-project/xdp-project/blob/master/areas/latency/cgroup_rstat_latency.bt
Greg KH
maintainerQuoted 43 lines · Jesper Dangaard Brouer
From: Shakeel Butt <[email protected]>
commit
d4a5b369ad6d8aae552752ff438dddde653a72ecupstream.One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the
count_shadow_nodes()added by the commitf82e6bf9bb9b("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path.Fixes f82e6bf9bb9b ("mm: memcg: use rstat for non-hierarchical stats")Signed-off-by Shakeel Butt <[email protected]>Cc Johannes Weiner <[email protected]>Cc Yosry Ahmed <[email protected]>Cc Yu Zhao <[email protected]>Cc Michal Hocko <[email protected]>Cc Roman Gushchin <[email protected]>Cc Muchun Song <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Jesper Dangaard Brouer <[email protected]>---
On production with kernel v6.6 we are observing issues with excessive cgroup rstat flushing due to the extra call tomem_cgroup_flush_stats()incount_shadow_nodes()introduced in commitf82e6bf9bb9b("mm: memcg:
use rstat for non-hierarchical stats") that commit is part of v6.6. We request backport of commitd4a5b369ad6d("mm: ratelimit stat flush from workingset shrinker") as it have a fixes tag for this commit.IMHO it is worth explaining call path that makes
count_shadow_nodes()cause excessive cgroup rstat flushing calls. Functionshrink_node()callsmem_cgroup_flush_stats()on its own first, and then invokesshrink_node_memcgs(). Functionshrink_node_memcgs()iterates over cgroups viamem_cgroup_iter()for each callingshrink_slab(). Theshrink_slab()callsdo_shrink_slab()that viashrinker->count_objects()invokecount_shadow_nodes(), andcount_shadow_nodes()does
amem_cgroup_flush_stats()call, that seems unnecessary.
Quoted 2 lines
Backport differs slightly due to v6.6.32 doesn't contain commit
7d7ef0a4686a("mm: memcg: restore subtree stats flushing") from v6.8.
Now queued up, thanks.
greg k-h