Skip to contentSkip to conversation

dt-bindings: serial: vt8500-uart: convert to json-schema

PATCH Superseded Kanak Shilledar 4 participants 5 messages Jun 12, 2024

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: serial: vt8500-uart: convert to json-schema

Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts and clocks as required properties.

Additions to the original binding
- changed the file name from vt8500-uart to via,vt8500-uart.yaml
- removed unnecessary alias from the example.
- added Greg and Jiri as maintainers (referred MAINTAINERS file).

---
Changes in v2:
- Rebased changes
- Changed maintainers to have Rob. VT8500 is orphaned according to the maintainers file.
- Replaced compatible property description with comments.

---
 .../bindings/serial/via,vt8500-uart.yaml      | 47 +++++++++++++++++++
 .../bindings/serial/vt8500-uart.txt           | 27 -----------
 2 files changed, 47 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/vt8500-uart.txt
Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml new file +47 -0
new file mode 100644
index 000000000000..a81bdfaec2e9
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA VT8500 and WonderMedia WM8xxx UART Controller
+
+maintainers:
+  - Rob Herring <[email protected]>
+  - Kanak Shilledar <[email protected]>
+
+allOf:
+  - $ref: serial.yaml
+
+properties:
+  compatible:
+    enum:
+      - via,vt8500-uart # up to WM8850/WM8950
+      - wm,wm8880-uart  # for WM8880 and later
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - clocks
+  - interrupts
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    serial@d8200000 {
+        compatible = "via,vt8500-uart";
+        reg = <0xd8200000 0x1040>;
+        interrupts = <32>;
+        clocks = <&clkuart0>;
+    };
Documentation/devicetree/bindings/serial/vt8500-uart.txt deleted +0 -27
deleted file mode 100644
index 2b64e6107fb3..000000000000
@@ -1,27 +0,0 @@
-* VIA VT8500 and WonderMedia WM8xxx UART Controller
-
-Required properties:
-- compatible: should be "via,vt8500-uart" (for VIA/WonderMedia chips up to and
-	including WM8850/WM8950), or "wm,wm8880-uart" (for WM8880 and later)
-
-- reg: base physical address of the controller and length of memory mapped
-	region.
-
-- interrupts: hardware interrupt number
-
-- clocks: shall be the input parent clock phandle for the clock. This should
-	be the 24Mhz reference clock.
-
-Aliases may be defined to ensure the correct ordering of the uarts.
-
-Example:
-	aliases {
-		serial0 = &uart0;
-	};
-
-	uart0: serial@d8200000 {
-		compatible = "via,vt8500-uart";
-		reg = <0xd8200000 0x1040>;
-		interrupts = <32>;
-		clocks = <&clkuart0>;
-	};
Signature · 1 line
2.45.2
#1 lore raw
Quoted 8 lines · Kanak Shilledar

Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts and clocks as required properties.

Additions to the original binding
- changed the file name from vt8500-uart to via,vt8500-uart.yaml
- removed unnecessary alias from the example.
- added Greg and Jiri as maintainers (referred MAINTAINERS file).

Really? Because I see here:

Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml line 12

Quoted 3 lines
Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml new file +3 -0
+maintainers:
+  - Rob Herring <[email protected]>
+  - Kanak Shilledar <[email protected]>

Not me :)

thanks,

greg k-h

#2 lore raw
In reply to Kanak Shilledar
Quoted 8 lines · Kanak Shilledar

Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts and clocks as required properties.

Additions to the original binding
- changed the file name from vt8500-uart to via,vt8500-uart.yaml
- removed unnecessary alias from the example.
- added Greg and Jiri as maintainers (referred MAINTAINERS file).

?

Quoted 10 lines

---
Changes in v2:
- Rebased changes
- Changed maintainers to have Rob. VT8500 is orphaned according to the maintainers file.
- Replaced compatible property description with comments.

Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml new file +10 -0
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA VT8500 and WonderMedia WM8xxx UART Controller
+
+maintainers:
+  - Rob Herring <[email protected]>

Not Rob.

Quoted 1 line

+ - Kanak Shilledar <[email protected]>

I doubt you care about this device. This could be most recent contributor, so: Alexey Charkov <[email protected]>

Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml line 21

Quoted 9 lines
Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml new file +9 -0
+
+allOf:
+  - $ref: serial.yaml
+
+properties:
+  compatible:
+    enum:
+      - via,vt8500-uart # up to WM8850/WM8950
+      - wm,wm8880-uart  # for WM8880 and later

Best regards,
Krzysztof

#3 lore raw

Sorry for the confusion. I will fix the maintainers part quickly. I have one question that if I find any area for the SoC is not maintained or orphaned,
how can I find out who is the maintainer for that area, or the one who last contributed
for that specific area?

Thanks and Regards,
Kanak Shilledar

#4 lore raw
Quoted 6 lines · Kanak Shilledar

Sorry for the confusion. I will fix the maintainers part quickly. I have one question that if I find any area for the SoC is not maintained or orphaned,
how can I find out who is the maintainer for that area, or the one who last contributed
for that specific area?

git log for the latter, MAINTAINERS for the former.

Thanks,
Conor.