Skip to contentSkip to conversation

ALSA/PCI: add PantherLake audio support

PATCH In review Pierre-Louis Bossart 3 participants 9 messages Jun 12, 2024 – Jun 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ALSA/PCI: add PantherLake audio support

Add the PCI ID for PantherLake.

Since there's a follow-up patchset for ASoC, these 3 patches could be applied to the ASoC tree. Otherwise an immutable branch would be needed.

Pierre-Louis Bossart (3):
PCI: pci_ids: add INTEL_HDA_PTL
ALSA: hda: hda-intel: add PantherLake support
ALSA: hda: intel-dsp-config: Add PTL support

 include/linux/pci_ids.h      | 1 +
 sound/hda/intel-dsp-config.c | 9 +++++++++
 sound/pci/hda/hda_intel.c    | 2 ++
 3 files changed, 12 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/3 PCI: pci_ids: add INTEL_HDA_PTL

More PCI ids for Intel audio.

---
 include/linux/pci_ids.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/pci_ids.h +1 -0
index 942a587bb97e..0168c6a60148 100644
@@ -3112,6 +3112,7 @@
 #define PCI_DEVICE_ID_INTEL_HDA_LNL_P	0xa828
 #define PCI_DEVICE_ID_INTEL_S21152BB	0xb152
 #define PCI_DEVICE_ID_INTEL_HDA_BMG	0xe2f7
+#define PCI_DEVICE_ID_INTEL_HDA_PTL	0xe428
 #define PCI_DEVICE_ID_INTEL_HDA_CML_R	0xf0c8
 #define PCI_DEVICE_ID_INTEL_HDA_RKL_S	0xf1c8
 
Signature · 1 line
2.43.0
Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] PCI: pci_ids: add INTEL_HDA_PTL

Quoted 7 lines · Pierre-Louis Bossart

More PCI ids for Intel audio.

Change subject to match history:

PCI: Add INTEL_HDA_PTL to pci_ids.h

It's helpful mention the places where this will be used in the commit log because we only add things here when they're used in more than one place.

Quoted 19 lines
---
 include/linux/pci_ids.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/pci_ids.h +1 -0
index 942a587bb97e..0168c6a60148 100644
@@ -3112,6 +3112,7 @@
 #define PCI_DEVICE_ID_INTEL_HDA_LNL_P	0xa828
 #define PCI_DEVICE_ID_INTEL_S21152BB	0xb152
 #define PCI_DEVICE_ID_INTEL_HDA_BMG	0xe2f7
+#define PCI_DEVICE_ID_INTEL_HDA_PTL	0xe428
 #define PCI_DEVICE_ID_INTEL_HDA_CML_R	0xf0c8
 #define PCI_DEVICE_ID_INTEL_HDA_RKL_S	0xf1c8
 
Signature · 1 line
2.43.0
#3 lore raw

Re: [PATCH 1/3] PCI: pci_ids: add INTEL_HDA_PTL

Quoted 12 lines · Bjorn Helgaas
Quoted 7 lines · Pierre-Louis Bossart

More PCI ids for Intel audio.

Change subject to match history:

Quoted 7 lines

PCI: Add INTEL_HDA_PTL to pci_ids.h

It's helpful mention the places where this will be used in the commit log because we only add things here when they're used in more than one place.

OK, I corrected the subject at applying.

thanks,

Takashi

#4 lore raw

PATCH 2/3 ALSA: hda: hda-intel: add PantherLake support

In reply to Pierre-Louis Bossart

One more PCI ID.

---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/hda_intel.c +2 -0
index 3500108f6ba3..b33602e64d17 100644
@@ -2495,6 +2495,8 @@ static const struct pci_device_id azx_ids[] = {
 	{ PCI_DEVICE_DATA(INTEL, HDA_ARL_S, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE) },
 	/* Arrow Lake */
 	{ PCI_DEVICE_DATA(INTEL, HDA_ARL, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE) },
+	/* Panther Lake */
+	{ PCI_DEVICE_DATA(INTEL, HDA_PTL, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_LNL) },
 	/* Apollolake (Broxton-P) */
 	{ PCI_DEVICE_DATA(INTEL, HDA_APL, AZX_DRIVER_SKL | AZX_DCAPS_INTEL_BROXTON) },
 	/* Gemini-Lake */
Signature · 1 line
2.43.0
#5 lore raw

PATCH 3/3 ALSA: hda: intel-dsp-config: Add PTL support

In reply to Pierre-Louis Bossart

Same recipes as LNL

---
 sound/hda/intel-dsp-config.c | 9 +++++++++
 1 file changed, 9 insertions(+)
sound/hda/intel-dsp-config.c +9 -0
index 537863447358..a7419d2e912e 100644
@@ -543,6 +543,15 @@ static const struct config_entry config_table[] = {
 		.device = PCI_DEVICE_ID_INTEL_HDA_LNL_P,
 	},
 #endif
+
+	/* Panther Lake */
+#if IS_ENABLED(CONFIG_SND_SOC_SOF_PANTHERLAKE)
+	{
+		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
+		.device = PCI_DEVICE_ID_INTEL_HDA_PTL,
+	},
+#endif
+
 };
 
 static const struct config_entry *snd_intel_dsp_find_config
Signature · 1 line
2.43.0
#6 lore raw
In reply to Pierre-Louis Bossart
Quoted 11 lines · Pierre-Louis Bossart

Add the PCI ID for PantherLake.

Since there's a follow-up patchset for ASoC, these 3 patches could be applied to the ASoC tree. Otherwise an immutable branch would be needed.

Pierre-Louis Bossart (3):
PCI: pci_ids: add INTEL_HDA_PTL
ALSA: hda: hda-intel: add PantherLake support
ALSA: hda: intel-dsp-config: Add PTL support

Applied now to for-next branch.

There were duplicated Reviewed-by tags by Peter as checkpatch complained, so I removed the one.

thanks,

Takashi

#7 lore raw
Quoted 14 lines · Takashi Iwai
Quoted 11 lines · Pierre-Louis Bossart

Add the PCI ID for PantherLake.

Since there's a follow-up patchset for ASoC, these 3 patches could be applied to the ASoC tree. Otherwise an immutable branch would be needed.

Pierre-Louis Bossart (3):
PCI: pci_ids: add INTEL_HDA_PTL
ALSA: hda: hda-intel: add PantherLake support
ALSA: hda: intel-dsp-config: Add PTL support

Quoted 4 lines

Applied now to for-next branch.

There were duplicated Reviewed-by tags by Peter as checkpatch complained, so I removed the one.

Thanks Takashi, how do we proceed to get those changes into AsoC?

the first patch is a dependency for the patchset "[PATCH v2 0/5] ASoC/SOF/PCI/Intel: add PantherLake support"

#8 lore raw
Quoted 20 lines · Pierre-Louis Bossart
Quoted 16 lines · Takashi Iwai
Quoted 11 lines · Pierre-Louis Bossart

Add the PCI ID for PantherLake.

Since there's a follow-up patchset for ASoC, these 3 patches could be applied to the ASoC tree. Otherwise an immutable branch would be needed.

Pierre-Louis Bossart (3):
PCI: pci_ids: add INTEL_HDA_PTL
ALSA: hda: hda-intel: add PantherLake support
ALSA: hda: intel-dsp-config: Add PTL support

Applied now to for-next branch.

Quoted 7 lines
Quoted 2 lines

There were duplicated Reviewed-by tags by Peter as checkpatch complained, so I removed the one.

Thanks Takashi, how do we proceed to get those changes into AsoC?

the first patch is a dependency for the patchset "[PATCH v2 0/5] ASoC/SOF/PCI/Intel: add PantherLake support"

ASoC tree needs to merge for-next branch from my sound.git tree. Or vice versa, Mark sends a PR to sync the content. (It should be done more often, not only once per cycle, IMHO.)

thanks,

Takashi