etherdevice: Optimize is_broadcast_ether_addr
Subsystems (2)
PATCH 1/1 etherdevice: Optimize is_broadcast_ether_addr
From: Qingfang Deng <[email protected]>
Like is_zero_ether_addr, is_broadcast_ether_addr can also be optimized by using a 32-bit load if CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set. Sign extension is used to populate the upper 16-bit of the 16-bit load.
--- include/linux/etherdevice.h | 5 +++++ 1 file changed, 5 insertions(+)
include/linux/etherdevice.h +5 -0
@@ -174,9 +174,14 @@ static inline bool is_local_ether_addr(const u8 *addr)*/ static inline bool is_broadcast_ether_addr (const u8 *addr) { +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS ) +return (*(const s32 *)(addr +0 ) & + *(const s16 *)(addr +4 )) == (s32 )0xffffffff ; +#else return (*(const u16 *)(addr +0 ) & *(const u16 *)(addr +2 ) & *(const u16 *)(addr +4 )) ==0xffff ; +#endif }/**
Signature · 1 line
2.34.1
Jakub Kicinski
maintainerQuoted 3 lines · On Thu, 13 Jun 2024 15:34:41 +0800 Qingfang Deng wrote:
Like
is_zero_ether_addr,is_broadcast_ether_addrcan also be optimized by using a 32-bit load ifCONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESSis set. Sign extension is used to populate the upper 16-bit of the 16-bit load.
Can you provide more context on why it's beneficial. I mean, there's a lot of code in the kernel one could micro-optimize...
Show us the assembly, cycle counts, where it's used on fast paths...
Signature · 1 line
pw-bot: cr
Hi Jakub,
Quoted 4 lines · Jakub Kicinski
Can you provide more context on why it's beneficial. I mean, there's a lot of code in the kernel one could micro-optimize...
Show us the assembly, cycle counts, where it's used on fast paths...
is_broadcast_ether_addr is used in bridge forwarding fast paths (br_dev_xmit, br_multicast_flood, br_handle_frame_finish), and often in combination with is_multicast_ether_addr.
Since commit d54385ce68cd ("etherdev: Process is_multicast_ether_addr at same size as other operations"), is_multicast_ether_addr already does a 32-bit load. We can avoid duplicate loads by applying the same approach to is_broadcast_ether_addr and save a few instructions. Tested with x86_64, aarch64 and RISC-V compilers.
Quoted 2 lines
--
pw-bot: cr