mfd: axp20x: AXP717: Fix missing IRQ status registers range
Subsystems (3)
PATCH v3 1/1 mfd: axp20x: AXP717: Fix missing IRQ status registers range
While we list the "IRQ status *and acknowledge*" registers as volatile in the MFD description, they are missing from the writable range array, so acknowledging any interrupts was met with an -EIO error. This error propagates up, leading to the whole AXP717 driver failing to probe, which is fatal to most systems using this PMIC, since most peripherals refer one of the PMIC voltage rails.
This wasn't noticed on the initial submission, since the interrupt was completely missing at this point, but the DTs now merged describe the interrupt, creating the problem.
Add the five registers that hold those bits to the writable array.
This fixes the boot on the Anbernic systems using the AXP717 PMIC.
---
Hi,
the patch itself is unchanged from v2 sent in April, but the commit message was updated to give rationale for the Fixes: tag. Please take this as a fix into v6.10.
Thanks,
Andre
drivers/mfd/axp20x.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/axp20x.c +1 -0
@@ -210,6 +210,7 @@ static const struct regmap_access_table axp313a_volatile_table = {static const struct regmap_range axp717_writeable_ranges[] = {regmap_reg_range (AXP717_IRQ0_EN ,AXP717_IRQ4_EN ), +regmap_reg_range (AXP717_IRQ0_STATE ,AXP717_IRQ4_STATE ),regmap_reg_range (AXP717_DCDC_OUTPUT_CONTROL ,AXP717_CPUSLDO_CONTROL ), };
Signature · 1 line
2.39.4
Re: (subset) [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range
Quoted 11 lines · Andre Przywara
While we list the "IRQ status *and acknowledge*" registers as volatile in the MFD description, they are missing from the writable range array, so acknowledging any interrupts was met with an
-EIOerror. This error propagates up, leading to the whole AXP717 driver failing to probe, which is fatal to most systems using this PMIC, since most peripherals refer one of the PMIC voltage rails.
This wasn't noticed on the initial submission, since the interrupt was completely missing at this point, but the DTs now merged describe the interrupt, creating the problem.[...]
Applied, thanks!
[1/1] mfd: axp20x: AXP717: Fix missing IRQ status registers range
commit: 569c5136baf12c3b8dd137ac356f2a7ceb38bdb5
--
Lee Jones [李琼斯]
Lee Jones
maintainerQuoted 24 lines · Andre Przywara
While we list the "IRQ status *and acknowledge*" registers as volatile in the MFD description, they are missing from the writable range array, so acknowledging any interrupts was met with an
-EIOerror. This error propagates up, leading to the whole AXP717 driver failing to probe, which is fatal to most systems using this PMIC, since most peripherals refer one of the PMIC voltage rails.
This wasn't noticed on the initial submission, since the interrupt was completely missing at this point, but the DTs now merged describe the interrupt, creating the problem.Add the five registers that hold those bits to the writable array.
This fixes the boot on the Anbernic systems using the AXP717 PMIC.
Fixes b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")Reported-by Chris Morgan <[email protected]>Signed-off-by Andre Przywara <[email protected]>---
Hi,the patch itself is unchanged from v2 sent in April, but the commit message was updated to give rationale for the Fixes: tag. Please take this as a fix into v6.10.
Quoted 5 lines
Thanks,
Andredrivers/mfd/axp20x.c | 1 + 1 file changed, 1 insertion(+)
Submitted to Linus today.
Signature · 1 line
Lee Jones [李琼斯]