drm/mediatek: Remove less-than-zero comparison of an unsigned value
Subsystems (3)
PATCH 1/1 drm/mediatek: Remove less-than-zero comparison of an unsigned value
From: Hsiao Chien Sung <[email protected]>
Fix a Coverity error that less-than-zero comparison of an unsigned value is never true.
Fixes 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195")
Signed-off-by Hsiao Chien Sung <[email protected]>
--- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_ddp_comp.c +1 -1
@@ -593,7 +593,7 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp,int ret;#endif -if (comp_id <0 || comp_id >=DDP_COMPONENT_DRM_ID_MAX ) +if (comp_id >=DDP_COMPONENT_DRM_ID_MAX )return -EINVAL ; type = mtk_ddp_matches[comp_id].type;
Signature · 1 line
2.18.0
Hi, Shawn:
Quoted 4 lines · Shawn Sung
From: Hsiao Chien Sung <[email protected]>
Fix a Coverity error that less-than-zero comparison of an unsigned value is never true.
Reviewed-by CK Hu <[email protected]>
Quoted 20 lines
Fixes 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195")Signed-off-by Hsiao Chien Sung <[email protected]>--- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/mediatek/mtk_ddp_comp.c +1
-1@@ -593,7 +593,7 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp,int ret;#endif -if (comp_id <0 || comp_id >=DDP_COMPONENT_DRM_ID_MAX ) +if (comp_id >=DDP_COMPONENT_DRM_ID_MAX )return -EINVAL ; type = mtk_ddp_matches[comp_id].type;