lib-alloc_tag-fix-rcu-imbalance-in-pgalloc_tag_get.patch removed from -mm tree
The quilt patch titled
Subject: lib/alloc_tag: fix RCU imbalance in pgalloc_tag_get()
has been removed from the -mm tree. Its filename was
lib-alloc_tag-fix-rcu-imbalance-in-pgalloc_tag_get.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Suren Baghdasaryan <[email protected]>
Subject: lib/alloc_tag: fix RCU imbalance in pgalloc_tag_get()
Date: Sat, 1 Jun 2024 16:38:40 -0700
put_page_tag_ref() should be called only when get_page_tag_ref() returns a valid reference because only in that case get_page_tag_ref() enters RCU read section while put_page_tag_ref() will call rcu_read_unlock() even if the provided reference is NULL. Fix pgalloc_tag_get() which does not follow this rule causing RCU imbalance. Add a warning in put_page_tag_ref() to catch any future mistakes.
---
include/linux/pgalloc_tag.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
include/linux/pgalloc_tag.h renamed from include/linux/pgalloc_tag.h~lib-alloc_tag-fix-rcu-imbalance-in-pgalloc_tag_get +8 -3
@@ -37,6 +37,9 @@ static inline union codetag_ref *get_pagstatic inline void put_page_tag_ref (union codetag_ref *ref) { +if (WARN_ON (!ref)) +return ; +page_ext_put (page_ext_from_codetag_ref (ref)); }
@@ -102,9 +105,11 @@ static inline struct alloc_tag *pgalloc_union codetag_ref *ref =get_page_tag_ref (page);alloc_tag_sub_check (ref); -if (ref && ref->ct) - tag =ct_to_alloc_tag (ref->ct); -put_page_tag_ref (ref); +if (ref) { +if (ref->ct) + tag =ct_to_alloc_tag (ref->ct); +put_page_tag_ref (ref); + } }return tag;
_
Patches currently in -mm which might be from [email protected] are
mm-slab-fix-variable-obj_exts-set-but-not-used-warning.patch mm-handle-profiling-for-fake-memory-allocations-during-compaction.patch