Skip to contentSkip to conversation

kbuild: deb-pkg: Explicitly define optional user-defined variables

PATCH In review Nicolas Schier 1 participant 2 messages Jun 16, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: deb-pkg: Explicitly define optional user-defined variables

mkdebian supports some optional environment variables for controlling the Debian package generation. Declare those variables explicitly to allow enabling of 'set -u' (error on unset variables).

Use of ': "${VAR:=}"' for variable assignment is POSIX compatible [1].

[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#colon

---
 scripts/package/mkdebian | 12 ++++++++++++
 1 file changed, 12 insertions(+)
scripts/package/mkdebian +12 -0
index 070149c985fe..81e81906ad07 100755
@@ -6,6 +6,18 @@
 
 set -e
 
+# Optional user-specified environment variables
+
+# Set target Debian architecture (skip auto-detection)
+: "${KBUILD_DEBARCH:=}"
+
+# Set target Debian distribution (skipping auto-detection)
+: "${KDEB_CHANGELOG_DIST:=}"
+
+# Overwrite the automatically determined package version.
+: "${KDEB_PKGVERSION:=}"
+
+
 is_enabled() {
 	grep -q "^$1=y" include/config/auto.conf
 }
Signature · 7 lines
2.39.2


-- 
epost|xmpp: [email protected]          irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --
#1 lore raw
Quoted 38 lines · On Sun, Jun 16, 2024 at 06:37:16PM +0200 Nicolas Schier wrote:

mkdebian supports some optional environment variables for controlling the Debian package generation. Declare those variables explicitly to allow enabling of 'set -u' (error on unset variables).

Use of ': "${VAR:=}"' for variable assignment is POSIX compatible [1].

[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#colon

---
 scripts/package/mkdebian | 12 ++++++++++++
 1 file changed, 12 insertions(+)
scripts/package/mkdebian +12 -0
index 070149c985fe..81e81906ad07 100755
@@ -6,6 +6,18 @@
 
 set -e
 
+# Optional user-specified environment variables
+
+# Set target Debian architecture (skip auto-detection)
+: "${KBUILD_DEBARCH:=}"
+
+# Set target Debian distribution (skipping auto-detection)
+: "${KDEB_CHANGELOG_DIST:=}"
+
+# Overwrite the automatically determined package version.
+: "${KDEB_PKGVERSION:=}"
+
+
 is_enabled() {
 	grep -q "^$1=y" include/config/auto.conf
 }
Signature · 1 line
2.39.2

Please ignore, cp. https://lore.kernel.org/linux-kbuild/CAK7LNARPP_OsaOhUHT+5-vi5XJ36hDs0bNsiM7pwuAmj4S+MNg@mail.gmail.com/

Sorry for the noise.

Kind regards,
Nicolas