block: cleanup flag_{show,store}
A message that is not in the archive (sent off-list or not yet received): CGME20240617045649epcas5p1763924a49c5182f30a9ae3ea013390ae@epcas5p1.samsung.com
PATCH 1/1 block: cleanup flag_{show,store}
Remove a superfluous argument that flag_show and flag_store currently take.
Signed-off-by Kanchan Joshi <[email protected]>
--- block/blk-integrity.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
block/blk-integrity.c +7 -8
@@ -186,8 +186,8 @@ const char *blk_integrity_profile_name(struct blk_integrity *bi) }EXPORT_SYMBOL_GPL (blk_integrity_profile_name); -static ssize_t flag_store (struct device *dev,struct device_attribute *attr, -const char *page,size_t count,unsigned char flag) +static ssize_t flag_store (struct device *dev,const char *page,size_t count, +unsigned char flag) {struct request_queue *q =dev_to_disk (dev)->queue;struct queue_limits lim;
@@ -213,8 +213,7 @@ static ssize_t flag_store(struct device *dev, struct device_attribute *attr,return count; } -static ssize_t flag_show (struct device *dev,struct device_attribute *attr, -char *page,unsigned char flag) +static ssize_t flag_show (struct device *dev,char *page,unsigned char flag) {struct blk_integrity *bi =dev_to_bi (dev);
@@ -253,26 +252,26 @@ static ssize_t read_verify_store(struct device *dev,struct device_attribute *attr, const char *page, size_t count) { - return flag_store(dev, attr, page, count, BLK_INTEGRITY_NOVERIFY); + return flag_store(dev, page, count, BLK_INTEGRITY_NOVERIFY); }static ssize_t read_verify_show (struct device *dev,struct device_attribute *attr,char *page) { -return flag_show (dev, attr, page,BLK_INTEGRITY_NOVERIFY ); +return flag_show (dev, page,BLK_INTEGRITY_NOVERIFY ); }static ssize_t write_generate_store (struct device *dev,struct device_attribute *attr,const char *page,size_t count) { -return flag_store (dev, attr, page, count,BLK_INTEGRITY_NOGENERATE ); +return flag_store (dev, page, count,BLK_INTEGRITY_NOGENERATE ); }static ssize_t write_generate_show (struct device *dev,struct device_attribute *attr,char *page) { -return flag_show (dev, attr, page,BLK_INTEGRITY_NOGENERATE ); +return flag_show (dev, page,BLK_INTEGRITY_NOGENERATE ); } static ssize_t device_is_integrity_capable_show(struct device *dev,
Signature · 1 line
2.25.1
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>
Quoted 4 lines · Kanchan Joshi
Remove a superfluous argument that
flag_showandflag_storecurrently take.
Applied, thanks!
[1/1] block: cleanup flag_{show,store}
commit: b83bd486b43d2b7f10595a9d7a52d41023eaa9c1
Best regards,
Signature · 1 line
Jens Axboe