Skip to contentSkip to conversation

Add --noefistub option for linux

PATCH In review Vladimir Serbinenko 2 participants 2 messages Jun 17, 2024 – Jun 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Add --noefistub option for linux

In some cases like loading kernel from native disk (e.g. nvme) not supported by EFI in question efi stub is not an option. Allow user to disable efi stub and fallback to older protocol

---
 grub-core/loader/efi/linux.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
grub-core/loader/efi/linux.c +9 -1
index bfbd95aee..e70017a78 100644
@@ -459,10 +459,18 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
   grub_file_t file = 0;
   struct linux_arch_kernel_header lh;
   grub_err_t err;
+  bool force_legacy = false;
 
   grub_dl_ref (my_mod);
 
-  if (grub_is_shim_lock_enabled () == true)
+  if (argc > 0 && grub_strcmp(argv[0], "--noefistub") == 0)
+    {
+      force_legacy = true;
+      argv++;
+      argc--;
+    }
+
+  if (grub_is_shim_lock_enabled () == true || force_legacy)
     {
 #if defined(__i386__) || defined(__x86_64__)
       grub_dprintf ("linux", "shim_lock enabled, falling back to legacy Linux kernel loader\n");
Signature · 7 lines
2.39.2


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw
Quoted 3 lines · Vladimir Serbinenko

In some cases like loading kernel from native disk (e.g. nvme) not supported by EFI in question efi stub is not an option. Allow user to disable efi stub and fallback to older protocol

I'm not sure I follow. The disk does not need to be supported by EFI for the EFI stub to work, we are loading the kernel into memory and then running it from a memory device path.

Hence you can run EFI stub fine from anywhere, whether it's an nvme disk or a squashfs image.

There is a specific problem with looking up the device path which I said before, it always uses (root) instead of the actual device you loaded the kernel from which is silly.

Signature · 7 lines
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel