Skip to contentSkip to conversation

net/mlx5: fix HWS VXLAN item validation

PATCH In review Gregory Etelson 2 participants 2 messages Jun 17, 2024 – Jul 1, 2024 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix HWS VXLAN item validation

HWS can match entire VXLAN, VXLAN-GPE and VXLAN-GBP headers. No need for mask validation.

Fixes 113feae56db6 ("net/mlx5: validate HWS template items")
---
 drivers/net/mlx5/mlx5_flow.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
drivers/net/mlx5/mlx5_flow.c +11 -10
index 7bcbbc74b5..a150909bd3 100644
@@ -3148,21 +3148,22 @@ mlx5_flow_validate_item_vxlan(struct rte_eth_dev *dev,
 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
 					  "multiple tunnel layers not"
 					  " supported");
+	/* HWS can match entire VXLAN, VXLAN-GBP and VXLAN-GPE headers */
+	if (mlx5_hws_active(dev))
+		return 0;
 	valid_mask = &rte_flow_item_vxlan_mask;
 	/*
 	 * Verify only UDPv4 is present as defined in
 	 * https://tools.ietf.org/html/rfc7348
 	 */
-	if (!mlx5_hws_active(dev)) {
-		if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP))
-			return rte_flow_error_set(error, EINVAL,
-						  RTE_FLOW_ERROR_TYPE_ITEM,
-						  item, "no outer UDP layer found");
-		if (!(item_flags & MLX5_FLOW_LAYER_OUTER))
-			return rte_flow_error_set(error, ENOTSUP,
-						  RTE_FLOW_ERROR_TYPE_ITEM, item,
-						  "VXLAN tunnel must be fully defined");
-	}
+	if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP))
+		return rte_flow_error_set(error, EINVAL,
+					  RTE_FLOW_ERROR_TYPE_ITEM,
+					  item, "no outer UDP layer found");
+	if (!(item_flags & MLX5_FLOW_LAYER_OUTER))
+		return rte_flow_error_set(error, ENOTSUP,
+					  RTE_FLOW_ERROR_TYPE_ITEM, item,
+					  "VXLAN tunnel must be fully defined");
 	if (!mask)
 		mask = &rte_flow_item_vxlan_mask;
 
Signature · 1 line
2.43.0
Acked-by Dariusz Sosnowski on v1 1/1
#1 lore raw

Hi,
From: Gregory Etelson <[email protected]>
Sent: Monday, June 17, 2024 5:03 PM
To: [email protected]
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix HWS VXLAN item validation

HWS can match entire VXLAN, VXLAN-GPE and VXLAN-GBP headers. No need for mask validation.

Fixes 113feae56db6 ("net/mlx5: validate HWS template items")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh