Skip to contentSkip to conversation

dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format

PATCH Applied Frank Li 3 participants 7 messages Jun 17, 2024 – Jun 18, 2024

Subsystems (3)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt deleted +0 -21
deleted file mode 100644
index 7c3ca0e13de05..0000000000000
@@ -1,21 +0,0 @@
-Binding for Freescale QorIQ AHCI SATA Controller
-
-Required properties:
-  - reg: Physical base address and size of the controller's register area.
-  - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
-    chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a etc.
-  - clocks: Input clock specifier. Refer to common clock bindings.
-  - interrupts: Interrupt specifier. Refer to interrupt binding.
-
-Optional properties:
-  - dma-coherent: Enable AHCI coherent DMA operation.
-  - reg-names: register area names when there are more than 1 register area.
-
-Examples:
-	sata@3200000 {
-		compatible = "fsl,ls1021a-ahci";
-		reg = <0x0 0x3200000 0x0 0x10000>;
-		interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&platform_clk 1>;
-		dma-coherent;
-	};
Documentation/devicetree/bindings/ata/fsl,ahci.yaml new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 6 lines · Frank Li

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

Quoted 7 lines
---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml

Should this file perhaps be called:
fsl,qoriq-ahci.yaml ?

Would be nice with some input from DT maintainers on this.

Kind regards,
Niklas

#2 lore raw
Quoted 15 lines · Niklas Cassel
Quoted 6 lines · Frank Li

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

Quoted 7 lines
---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
Quoted 4 lines

Should this file perhaps be called:
fsl,qoriq-ahci.yaml ?

Would be nice with some input from DT maintainers on this.

This should be rather compatible.

Best regards,
Krzysztof

maintainer
#3 lore raw
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Niklas Cassel
Quoted 13 lines · Frank Li

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
Quoted 6 lines
Quoted 4 lines

Should this file perhaps be called:
fsl,qoriq-ahci.yaml ?

Would be nice with some input from DT maintainers on this.

This should be rather compatible.

Considering that you gave your Reviewed-by tag, I interpret this sentence as that you are happy with the filename used (fsl,ahci.yaml) in this patch.

Kind regards,
Niklas

#4 lore raw
Quoted 20 lines · Niklas Cassel
Quoted 19 lines · Krzysztof Kozlowski
Quoted 18 lines · Niklas Cassel
Quoted 6 lines · Frank Li

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

Quoted 7 lines
---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml

Should this file perhaps be called:
fsl,qoriq-ahci.yaml ?

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Would be nice with some input from DT maintainers on this.

This should be rather compatible.

Considering that you gave your Reviewed-by tag, I interpret this sentence as that you are happy with the filename used (fsl,ahci.yaml) in this patch.

Yes, maybe indeed fsl,qoriq-ahci or compatible-based would be better, but probably I provided a bit different review on other patch, so don't want to block useful conversion.

Best regards,
Krzysztof

maintainer Applied
#6 lore raw
In reply to Frank Li
Quoted 108 lines · Frank Li

Convert ahci-fsl-qoirq DT binding to yaml format.

Additional changes:
- Add reg-names list, ahci and sata-ecc
- Add fsl,ls1028a-ahci and fsl,lx2060a-ahci

---
 .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
 .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
 2 files changed, 58 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
 create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt deleted +0 -21
deleted file mode 100644
index 7c3ca0e13de05..0000000000000
@@ -1,21 +0,0 @@
-Binding for Freescale QorIQ AHCI SATA Controller
-
-Required properties:
-  - reg: Physical base address and size of the controller's register area.
-  - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
-    chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a etc.
-  - clocks: Input clock specifier. Refer to common clock bindings.
-  - interrupts: Interrupt specifier. Refer to interrupt binding.
-
-Optional properties:
-  - dma-coherent: Enable AHCI coherent DMA operation.
-  - reg-names: register area names when there are more than 1 register area.
-
-Examples:
-	sata@3200000 {
-		compatible = "fsl,ls1021a-ahci";
-		reg = <0x0 0x3200000 0x0 0x10000>;
-		interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&platform_clk 1>;
-		dma-coherent;
-	};
Documentation/devicetree/bindings/ata/fsl,ahci.yaml new file +58 -0
new file mode 100644
index 0000000000000..162b3bb5427ed
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/fsl,ahci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale QorIQ AHCI SATA Controller
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - fsl,ls1021a-ahci
+      - fsl,ls1043a-ahci
+      - fsl,ls1028a-ahci
+      - fsl,ls1088a-ahci
+      - fsl,ls2080a-ahci
+      - fsl,lx2160a-ahci
+
+  reg:
+    minItems: 1
+    maxItems: 2
+
+  reg-names:
+    items:
+      - const: ahci
+      - const: sata-ecc
+    minItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  dma-coherent: true
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    sata@3200000 {
+        compatible = "fsl,ls1021a-ahci";
+        reg = <0x3200000 0x10000>;
+        interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&platform_clk 1>;
+        dma-coherent;
+    };
Signature · 1 line
2.34.1

Applied:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.11