Skip to contentSkip to conversation

arm64: dts: imx8mp: Fix pgc_mlmix location

PATCH Applied Adam Ford 5 participants 6 messages Jun 17, 2024 – Jun 27, 2024

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp: Fix pgc_mlmix location

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +17 -17
index b92abb5a5c53..3576d2b89b43 100644
@@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
 						reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
 					};
 
+					pgc_mlmix: power-domain@4 {
+						#power-domain-cells = <0>;
+						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
+						clocks = <&clk IMX8MP_CLK_ML_AXI>,
+							 <&clk IMX8MP_CLK_ML_AHB>,
+							 <&clk IMX8MP_CLK_NPU_ROOT>;
+						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
+								  <&clk IMX8MP_CLK_ML_AXI>,
+								  <&clk IMX8MP_CLK_ML_AHB>;
+						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>;
+						assigned-clock-rates = <800000000>,
+								       <800000000>,
+								       <300000000>;
+					};
+
 					pgc_audio: power-domain@5 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
@@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
 						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
 						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
 					};
-
-					pgc_mlmix: power-domain@24 {
-						#power-domain-cells = <0>;
-						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
-						clocks = <&clk IMX8MP_CLK_ML_AXI>,
-							 <&clk IMX8MP_CLK_ML_AHB>,
-							 <&clk IMX8MP_CLK_NPU_ROOT>;
-						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
-								  <&clk IMX8MP_CLK_ML_AXI>,
-								  <&clk IMX8MP_CLK_ML_AHB>;
-						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>;
-						assigned-clock-rates = <800000000>,
-								       <800000000>,
-								       <300000000>;
-					};
 				};
 			};
 		};
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Adam Ford

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")

Thanks !

Reviewed-by on v1 1/1
#2 lore raw
In reply to Adam Ford

Hi Adam,

Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:

Quoted 5 lines

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Taking a look this mismatch seems to be also true for:
* IMX8MP_POWER_DOMAIN_VPUMIX
* IMX8MP_POWER_DOMAIN_VPU_G1
* IMX8MP_POWER_DOMAIN_VPU_G2
* IMX8MP_POWER_DOMAIN_VPU_VC8000E

Would you mind fixing them as well?

Despite that, for this patch:

Thanks and best regards,
Alexander

Quoted 58 lines
Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +17 -17
index b92abb5a5c53..3576d2b89b43 100644
@@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
 						reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
 					};
 
+					pgc_mlmix: power-domain@4 {
+						#power-domain-cells = <0>;
+						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
+						clocks = <&clk IMX8MP_CLK_ML_AXI>,
+							 <&clk IMX8MP_CLK_ML_AHB>,
+							 <&clk IMX8MP_CLK_NPU_ROOT>;
+						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
+								  <&clk IMX8MP_CLK_ML_AXI>,
+								  <&clk IMX8MP_CLK_ML_AHB>;
+						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>;
+						assigned-clock-rates = <800000000>,
+								       <800000000>,
+								       <300000000>;
+					};
+
 					pgc_audio: power-domain@5 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
@@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
 						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
 						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
 					};
-
-					pgc_mlmix: power-domain@24 {
-						#power-domain-cells = <0>;
-						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
-						clocks = <&clk IMX8MP_CLK_ML_AXI>,
-							 <&clk IMX8MP_CLK_ML_AHB>,
-							 <&clk IMX8MP_CLK_NPU_ROOT>;
-						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
-								  <&clk IMX8MP_CLK_ML_AXI>,
-								  <&clk IMX8MP_CLK_ML_AHB>;
-						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>;
-						assigned-clock-rates = <800000000>,
-								       <800000000>,
-								       <300000000>;
-					};
 				};
 			};
 		};
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
author
#3 lore raw
Quoted 10 lines · Alexander Stein

Hi Adam,

Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:

Quoted 5 lines

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Quoted 7 lines

Taking a look this mismatch seems to be also true for:
* IMX8MP_POWER_DOMAIN_VPUMIX
* IMX8MP_POWER_DOMAIN_VPU_G1
* IMX8MP_POWER_DOMAIN_VPU_G2
* IMX8MP_POWER_DOMAIN_VPU_VC8000E

Would you mind fixing them as well?

I can do that. I'll send out out later tonight.

adam

Quoted 74 lines

Despite that, for this patch:

Thanks and best regards,
Alexander

Quoted 48 lines
Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +17 -10
index b92abb5a5c53..3576d2b89b43 100644
@@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
                                              reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
                                      };
 
+                                     pgc_mlmix: power-domain@4 {
+                                             #power-domain-cells = <0>;
+                                             reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
+                                             clocks = <&clk IMX8MP_CLK_ML_AXI>,
+                                                      <&clk IMX8MP_CLK_ML_AHB>,
+                                                      <&clk IMX8MP_CLK_NPU_ROOT>;
+                                             assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
+                                                               <&clk IMX8MP_CLK_ML_AXI>,
+                                                               <&clk IMX8MP_CLK_ML_AHB>;
+                                             assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
+                                                                      <&clk IMX8MP_SYS_PLL1_800M>,
+                                                                      <&clk IMX8MP_SYS_PLL1_800M>;
+                                             assigned-clock-rates = <800000000>,
+                                                                    <800000000>,
+                                                                    <300000000>;
+                                     };
+
                                      pgc_audio: power-domain@5 {
                                              #power-domain-cells = <0>;
                                              reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
@@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
                                              reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
                                              clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
                                      };
-
-                                     pgc_mlmix: power-domain@24 {
-                                             #power-domain-cells = <0>;
-                                             reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
-                                             clocks = <&clk IMX8MP_CLK_ML_AXI>,
-                                                      <&clk IMX8MP_CLK_ML_AHB>,
-                                                      <&clk IMX8MP_CLK_NPU_ROOT>;
-                                             assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
-                                                               <&clk IMX8MP_CLK_ML_AXI>,
-                                                               <&clk IMX8MP_CLK_ML_AHB>;

arch/arm64/boot/dts/freescale/imx8mp.dtsi pgc_vpu_vc8000e: power-domain@22 { · line 922

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp.dtsi +0 -7
-                                             assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
-                                                                      <&clk IMX8MP_SYS_PLL1_800M>,
-                                                                      <&clk IMX8MP_SYS_PLL1_800M>;
-                                             assigned-clock-rates = <800000000>,
-                                                                    <800000000>,
-                                                                    <300000000>;
-                                     };
                              };
                      };
              };

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Reviewed-by on v1 1/1
#4 lore raw
In reply to Adam Ford
Quoted 5 lines

Subject: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

Quoted 9 lines

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power

domain")

Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")

Regards,
Peng.

Applied
#5 lore raw
In reply to Adam Ford
Quoted 10 lines · Adam Ford

The pgc_mlmix shows a power-domain@24, but the reg value is IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Fixes 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")

Applied, thanks!