Skip to contentSkip to conversation

vc4 VEC (analogue video) updates - margins and monochrome

PATCH Applied Dave Stevenson 6 participants 24 messages Feb 16, 2024 – Jun 18, 2024

Subsystems (3)

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Dave Stevenson

author maintainer
#0 lore raw

cover vc4 VEC (analogue video) updates - margins and monochrome

Hi All

A couple of patches to vc4, including adding a new "TV mode" enum for monochrome output (yes we have some users who wish for monochrome).

Adding mono has raised a query here as to whether the the TV_MODE is meant to describe the timing, or just the colour encoding.

The description for NTSC references "CCIR System M (aka 525-lines)", and PAL references "CCIR System B" which is the 625 line standard.

PAL-60 is absent from the enum, but support has been added to vc4 by selecting DRM_MODE_TV_MODE_PAL but with the NTSC (CCIR System M) timings. Is that the correct implementation? In which case the description for PAL should drop the CCIR System B reference as selecting the "TV mode" doesn't dictate the timing.

Monochrome is in the same boat as it can adopt either 525 or 625 line timing, or indeed anything else. Pi5 can support System A 405-line and the French 819-line mono modes as well.

If "TV mode" does dictate the timing as well as the colour encoding, then we need to add PAL-60, and 2 modes for mono (extending to 4 for 405 and 819 line modes later). If not, we ought to update the description.

Thoughts?

Thanks
Dave

Dave Stevenson (2):
drm/vc4: Add monochrome mode to the VEC. drm/vc4: vec: Add the margin properties to the connector

Nick Hollinghurst (1):
drm: Add DRM_MODE_TV_MODE_MONOCHROME

 drivers/gpu/drm/drm_connector.c    |  7 +++++++
 drivers/gpu/drm/drm_modes.c        |  5 ++++-
 drivers/gpu/drm/drm_probe_helper.c |  5 +++--
 drivers/gpu/drm/vc4/vc4_vec.c      | 30 +++++++++++++++++++++++++++++-
 include/drm/drm_connector.h        |  7 +++++++
 5 files changed, 50 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH 1/3 drm: Add DRM_MODE_TV_MODE_MONOCHROME

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

---
 drivers/gpu/drm/drm_connector.c    | 7 +++++++
 drivers/gpu/drm/drm_modes.c        | 5 ++++-
 drivers/gpu/drm/drm_probe_helper.c | 5 +++--
 include/drm/drm_connector.h        | 7 +++++++
 4 files changed, 21 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_connector.c +7 -0
index b0516505f7ae..fe05d27f3404 100644
@@ -1005,6 +1005,7 @@ static const struct drm_prop_enum_list drm_tv_mode_enum_list[] = {
 	{ DRM_MODE_TV_MODE_PAL_M, "PAL-M" },
 	{ DRM_MODE_TV_MODE_PAL_N, "PAL-N" },
 	{ DRM_MODE_TV_MODE_SECAM, "SECAM" },
+	{ DRM_MODE_TV_MODE_MONOCHROME, "Mono" },
 };
 DRM_ENUM_NAME_FN(drm_get_tv_mode_name, drm_tv_mode_enum_list)
 
@@ -1697,6 +1698,12 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
  *		TV Mode is CCIR System B (aka 625-lines) together with
  *		the SECAM Color Encoding.
  *
+ *	Mono:
+ *
+ *		Use timings appropriate to the DRM mode, including
+ *		equalizing pulses for a 525-line or 625-line mode,
+ *		with no pedestal or color encoding.
+ *
  *	Drivers can set up this property by calling
  *	drm_mode_create_tv_properties().
  */
drivers/gpu/drm/drm_modes.c +4 -1
index c4f88c3a93b7..d274e7b00b79 100644
@@ -530,7 +530,8 @@ static int fill_analog_mode(struct drm_device *dev,
  * @interlace: whether to compute an interlaced mode
  *
  * This function creates a struct drm_display_mode instance suited for
- * an analog TV output, for one of the usual analog TV mode.
+ * an analog TV output, for one of the usual analog TV modes. Where
+ * this is DRM_MODE_TV_MODE_MONOCHROME, a 625-line mode will be created.
  *
  * Note that @hdisplay is larger than the usual constraints for the PAL
  * and NTSC timings, and we'll choose to ignore most timings constraints
@@ -568,6 +569,8 @@ struct drm_display_mode *drm_analog_tv_mode(struct drm_device *dev,
 	case DRM_MODE_TV_MODE_PAL_N:
 		fallthrough;
 	case DRM_MODE_TV_MODE_SECAM:
+		fallthrough;
+	case DRM_MODE_TV_MODE_MONOCHROME:
 		analog = DRM_MODE_ANALOG_PAL;
 		break;
 
drivers/gpu/drm/drm_probe_helper.c +3 -2
index d1e1ade66f81..9254dc2af873 100644
@@ -1211,8 +1211,9 @@ int drm_connector_helper_tv_get_modes(struct drm_connector *connector)
 	for (i = 0; i < tv_mode_property->num_values; i++)
 		supported_tv_modes |= BIT(tv_mode_property->values[i]);
 
-	if ((supported_tv_modes & ntsc_modes) &&
-	    (supported_tv_modes & pal_modes)) {
+	if (((supported_tv_modes & ntsc_modes) &&
+	     (supported_tv_modes & pal_modes)) ||
+	    (supported_tv_modes & BIT(DRM_MODE_TV_MODE_MONOCHROME))) {
 		uint64_t default_mode;
 
 		if (drm_object_property_get_default_value(&connector->base,
include/drm/drm_connector.h +7 -0
index fe88d7fc6b8f..90fd0ea0ca09 100644
@@ -200,6 +200,13 @@ enum drm_connector_tv_mode {
 	 */
 	DRM_MODE_TV_MODE_SECAM,
 
+	/**
+	 * @DRM_MODE_TV_MODE_MONOCHROME: Use timings appropriate to
+	 * the DRM mode, including equalizing pulses for a 525-line
+	 * or 625-line mode, with no pedestal or color encoding.
+	 */
+	DRM_MODE_TV_MODE_MONOCHROME,
+
 	/**
 	 * @DRM_MODE_TV_MODE_MAX: Number of analog TV output modes.
 	 *
Signature · 1 line
2.25.1
#2 lore raw

UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

Hi Dave and Nick,

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

AFAIU, adding a new value to an existing enum still counts as new UAPI.

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

Btw. no-one has submitted a record with "TV mode" to
https://drmdb.emersion.fr/
It only lists the radeon-specific "tv standard" property. I first thought you had mistaken the property name in the cover letter.

Thanks,
pq

Quoted 89 lines
---
 drivers/gpu/drm/drm_connector.c    | 7 +++++++
 drivers/gpu/drm/drm_modes.c        | 5 ++++-
 drivers/gpu/drm/drm_probe_helper.c | 5 +++--
 include/drm/drm_connector.h        | 7 +++++++
 4 files changed, 21 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_connector.c +7 -0
index b0516505f7ae..fe05d27f3404 100644
@@ -1005,6 +1005,7 @@ static const struct drm_prop_enum_list drm_tv_mode_enum_list[] = {
 	{ DRM_MODE_TV_MODE_PAL_M, "PAL-M" },
 	{ DRM_MODE_TV_MODE_PAL_N, "PAL-N" },
 	{ DRM_MODE_TV_MODE_SECAM, "SECAM" },
+	{ DRM_MODE_TV_MODE_MONOCHROME, "Mono" },
 };
 DRM_ENUM_NAME_FN(drm_get_tv_mode_name, drm_tv_mode_enum_list)
 
@@ -1697,6 +1698,12 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
  *		TV Mode is CCIR System B (aka 625-lines) together with
  *		the SECAM Color Encoding.
  *
+ *	Mono:
+ *
+ *		Use timings appropriate to the DRM mode, including
+ *		equalizing pulses for a 525-line or 625-line mode,
+ *		with no pedestal or color encoding.
+ *
  *	Drivers can set up this property by calling
  *	drm_mode_create_tv_properties().
  */
drivers/gpu/drm/drm_modes.c +4 -1
index c4f88c3a93b7..d274e7b00b79 100644
@@ -530,7 +530,8 @@ static int fill_analog_mode(struct drm_device *dev,
  * @interlace: whether to compute an interlaced mode
  *
  * This function creates a struct drm_display_mode instance suited for
- * an analog TV output, for one of the usual analog TV mode.
+ * an analog TV output, for one of the usual analog TV modes. Where
+ * this is DRM_MODE_TV_MODE_MONOCHROME, a 625-line mode will be created.
  *
  * Note that @hdisplay is larger than the usual constraints for the PAL
  * and NTSC timings, and we'll choose to ignore most timings constraints
@@ -568,6 +569,8 @@ struct drm_display_mode *drm_analog_tv_mode(struct drm_device *dev,
 	case DRM_MODE_TV_MODE_PAL_N:
 		fallthrough;
 	case DRM_MODE_TV_MODE_SECAM:
+		fallthrough;
+	case DRM_MODE_TV_MODE_MONOCHROME:
 		analog = DRM_MODE_ANALOG_PAL;
 		break;
 
drivers/gpu/drm/drm_probe_helper.c +3 -2
index d1e1ade66f81..9254dc2af873 100644
@@ -1211,8 +1211,9 @@ int drm_connector_helper_tv_get_modes(struct drm_connector *connector)
 	for (i = 0; i < tv_mode_property->num_values; i++)
 		supported_tv_modes |= BIT(tv_mode_property->values[i]);
 
-	if ((supported_tv_modes & ntsc_modes) &&
-	    (supported_tv_modes & pal_modes)) {
+	if (((supported_tv_modes & ntsc_modes) &&
+	     (supported_tv_modes & pal_modes)) ||
+	    (supported_tv_modes & BIT(DRM_MODE_TV_MODE_MONOCHROME))) {
 		uint64_t default_mode;
 
 		if (drm_object_property_get_default_value(&connector->base,
include/drm/drm_connector.h +7 -0
index fe88d7fc6b8f..90fd0ea0ca09 100644
@@ -200,6 +200,13 @@ enum drm_connector_tv_mode {
 	 */
 	DRM_MODE_TV_MODE_SECAM,
 
+	/**
+	 * @DRM_MODE_TV_MODE_MONOCHROME: Use timings appropriate to
+	 * the DRM mode, including equalizing pulses for a 525-line
+	 * or 625-line mode, with no pedestal or color encoding.
+	 */
+	DRM_MODE_TV_MODE_MONOCHROME,
+
 	/**
 	 * @DRM_MODE_TV_MODE_MAX: Number of analog TV output modes.
 	 *
#3 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 16 lines · Pekka Paalanen
Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

Quoted 8 lines

Hi Dave and Nick,

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

AFAIU, adding a new value to an existing enum still counts as new UAPI.

I tend to agree with Pekka. I'm getting tired of seeing new DRM properties without knowing which canonical upstream user-space project uses it.

Can someone describe this for the "TV mode" property?

Harry

Quoted 103 lines

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

Btw. no-one has submitted a record with "TV mode" to
https://drmdb.emersion.fr/
It only lists the radeon-specific "tv standard" property. I first thought you had mistaken the property name in the cover letter.

Thanks,
pq

Quoted 89 lines
---
 drivers/gpu/drm/drm_connector.c    | 7 +++++++
 drivers/gpu/drm/drm_modes.c        | 5 ++++-
 drivers/gpu/drm/drm_probe_helper.c | 5 +++--
 include/drm/drm_connector.h        | 7 +++++++
 4 files changed, 21 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_connector.c +7 -0
index b0516505f7ae..fe05d27f3404 100644
@@ -1005,6 +1005,7 @@ static const struct drm_prop_enum_list drm_tv_mode_enum_list[] = {
 	{ DRM_MODE_TV_MODE_PAL_M, "PAL-M" },
 	{ DRM_MODE_TV_MODE_PAL_N, "PAL-N" },
 	{ DRM_MODE_TV_MODE_SECAM, "SECAM" },
+	{ DRM_MODE_TV_MODE_MONOCHROME, "Mono" },
 };
 DRM_ENUM_NAME_FN(drm_get_tv_mode_name, drm_tv_mode_enum_list)
 
@@ -1697,6 +1698,12 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
  *		TV Mode is CCIR System B (aka 625-lines) together with
  *		the SECAM Color Encoding.
  *
+ *	Mono:
+ *
+ *		Use timings appropriate to the DRM mode, including
+ *		equalizing pulses for a 525-line or 625-line mode,
+ *		with no pedestal or color encoding.
+ *
  *	Drivers can set up this property by calling
  *	drm_mode_create_tv_properties().
  */
drivers/gpu/drm/drm_modes.c +4 -1
index c4f88c3a93b7..d274e7b00b79 100644
@@ -530,7 +530,8 @@ static int fill_analog_mode(struct drm_device *dev,
  * @interlace: whether to compute an interlaced mode
  *
  * This function creates a struct drm_display_mode instance suited for
- * an analog TV output, for one of the usual analog TV mode.
+ * an analog TV output, for one of the usual analog TV modes. Where
+ * this is DRM_MODE_TV_MODE_MONOCHROME, a 625-line mode will be created.
  *
  * Note that @hdisplay is larger than the usual constraints for the PAL
  * and NTSC timings, and we'll choose to ignore most timings constraints
@@ -568,6 +569,8 @@ struct drm_display_mode *drm_analog_tv_mode(struct drm_device *dev,
 	case DRM_MODE_TV_MODE_PAL_N:
 		fallthrough;
 	case DRM_MODE_TV_MODE_SECAM:
+		fallthrough;
+	case DRM_MODE_TV_MODE_MONOCHROME:
 		analog = DRM_MODE_ANALOG_PAL;
 		break;
 
drivers/gpu/drm/drm_probe_helper.c +3 -2
index d1e1ade66f81..9254dc2af873 100644
@@ -1211,8 +1211,9 @@ int drm_connector_helper_tv_get_modes(struct drm_connector *connector)
 	for (i = 0; i < tv_mode_property->num_values; i++)
 		supported_tv_modes |= BIT(tv_mode_property->values[i]);
 
-	if ((supported_tv_modes & ntsc_modes) &&
-	    (supported_tv_modes & pal_modes)) {
+	if (((supported_tv_modes & ntsc_modes) &&
+	     (supported_tv_modes & pal_modes)) ||
+	    (supported_tv_modes & BIT(DRM_MODE_TV_MODE_MONOCHROME))) {
 		uint64_t default_mode;
 
 		if (drm_object_property_get_default_value(&connector->base,
include/drm/drm_connector.h +7 -0
index fe88d7fc6b8f..90fd0ea0ca09 100644
@@ -200,6 +200,13 @@ enum drm_connector_tv_mode {
 	 */
 	DRM_MODE_TV_MODE_SECAM,
 
+	/**
+	 * @DRM_MODE_TV_MODE_MONOCHROME: Use timings appropriate to
+	 * the DRM mode, including equalizing pulses for a 525-line
+	 * or 625-line mode, with no pedestal or color encoding.
+	 */
+	DRM_MODE_TV_MODE_MONOCHROME,
+
 	/**
 	 * @DRM_MODE_TV_MODE_MAX: Number of analog TV output modes.
 	 *
maintainer
#4 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Pekka Paalanen

Hi Pekka,

Quoted 20 lines · Pekka Paalanen
Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

Quoted 5 lines

AFAIU, adding a new value to an existing enum still counts as new UAPI.

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

That property was meant to provide legacy display handling, so I don't expect any reasonably recent codebase like Weston to suppport it, ever :)

That being said, from the beginning, that property was meant to be handled as a "mode-setting" property, and thus handled by either the kernel command-line, xrandr, or any similar mechanism.

I would expect that new enum variant to be handled under the same terms:
it'll probably only show up in distro scripts or configuration files, and never in any actual code base.

Is it what you were expecting, or did you mean something else?

Maxime

#5 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 37 lines · On Mon, 26 Feb 2024 15:10:45 +0100 Maxime Ripard <[email protected]> wrote:

Hi Pekka,

Quoted 20 lines · Pekka Paalanen
Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

Quoted 5 lines

AFAIU, adding a new value to an existing enum still counts as new UAPI.

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

That property was meant to provide legacy display handling, so I don't expect any reasonably recent codebase like Weston to suppport it, ever :)

That being said, from the beginning, that property was meant to be handled as a "mode-setting" property, and thus handled by either the kernel command-line, xrandr, or any similar mechanism.

Quoted 5 lines

I would expect that new enum variant to be handled under the same terms:
it'll probably only show up in distro scripts or configuration files, and never in any actual code base.

Is it what you were expecting, or did you mean something else?

Maybe? Let's have it in the commit message and see if DRM maintainers agree.

You should expect that all KMS clients will work towards programming all exposed KMS properties into known values. That's the only way to achieve repeatable KMS behaviour, because there is no KMS reset ioctl.

There are no two tiers of KMS properties AFAIK. You have to be the DRM master to change anything. So, people cannot force any settings from outside of a KMS client, they have to go through the KMS client, like xrandr goes through Xorg (and only Xorg).

I do fully expect Weston to gain support for this property, if anyone cares of its value. That goes for all Wayland compositors.

You're correct in that a KMS client would probably not know to control the value of this property automatically but it needs to come from configuration. That would be each KMS client's configuration. I don't understand how a script could achieve that.

However, if you feel it is important to have KMS properties that display servers must not touch, then they should be documented as such. I do not know if that would actually lift the new-UAPI requirements, that is for the DRM maintainers to decide and document. Is there such a thing already?

What are those "similar to xrandr" mechanisms? I don't think I've heard of any, and I've also completely missed any kernel command line arguments manipulating KMS properties.

Thanks,
pq

author maintainer
#6 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Hi Pekka

Sorry for the slight delay in replying.

Quoted 41 lines · Pekka Paalanen
Quoted 37 lines · On Mon, 26 Feb 2024 15:10:45 +0100 Maxime Ripard <[email protected]> wrote:

Hi Pekka,

Quoted 20 lines · Pekka Paalanen
Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

Quoted 5 lines

AFAIU, adding a new value to an existing enum still counts as new UAPI.

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

That property was meant to provide legacy display handling, so I don't expect any reasonably recent codebase like Weston to suppport it, ever :)

That being said, from the beginning, that property was meant to be handled as a "mode-setting" property, and thus handled by either the kernel command-line, xrandr, or any similar mechanism.

Quoted 8 lines
Quoted 5 lines

I would expect that new enum variant to be handled under the same terms:
it'll probably only show up in distro scripts or configuration files, and never in any actual code base.

Is it what you were expecting, or did you mean something else?

Maybe? Let's have it in the commit message and see if DRM maintainers agree.

You want the commit text for a patch adding a new enum to state that the whole property isn't expected to be used through the UAPI? OK, I can roll a v2 if that is your desire.

Quoted 11 lines

You should expect that all KMS clients will work towards programming all exposed KMS properties into known values. That's the only way to achieve repeatable KMS behaviour, because there is no KMS reset ioctl.

There are no two tiers of KMS properties AFAIK. You have to be the DRM master to change anything. So, people cannot force any settings from outside of a KMS client, they have to go through the KMS client, like xrandr goes through Xorg (and only Xorg).

I do fully expect Weston to gain support for this property, if anyone cares of its value. That goes for all Wayland compositors.

I don't know about Weston, but Wayfire / wlroots / sway have currently chosen to ignore all interlaced display modes [1].
[2] is the wlroots devs basically calling interlaced output a dead end.

That makes the debate for controlling the colour encoding on a composite video rather redundant as they're almost always interlaced.

[1] https://github.com/swaywm/sway/issues/3167
[2] https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3038

Quoted 5 lines

You're correct in that a KMS client would probably not know to control the value of this property automatically but it needs to come from configuration. That would be each KMS client's configuration. I don't understand how a script could achieve that.

Quoted 8 lines

However, if you feel it is important to have KMS properties that display servers must not touch, then they should be documented as such. I do not know if that would actually lift the new-UAPI requirements, that is for the DRM maintainers to decide and document. Is there such a thing already?

What are those "similar to xrandr" mechanisms? I don't think I've heard of any,

Boot to the console and run
modetest -w <connector id>:"tv_mode":"NTSC"
There is no reset mechanism for all properties, so that setting persists after modetest quits.

Quoted 2 lines

and I've also completely missed any kernel command line arguments manipulating KMS properties.

"tv_mode" on the command line is handled in drm_mode_parse_cmdline_options() [3], as are rotate, reflect_x, reflect_y, margin_[left|right|top|bottom], and panel_orientation all to set the relevant KMS properties.

Having "video=Composite-1:PAL,tv_mode=Mono" on the kernel command line will set up connector Composite-1 with the standard 720x576 50Hz interlaced timings, and DRM_MODE_TV_MODE_MONOCHROME selected on the tv_mode property. Swap in different tv_mode descriptions as required (eg PAL,tv_mode=SECAM), although some make little sense.

That's the main route I'm looking at for configuring this property, for situations such as having a black and white TV connected. You don't get the opportunity to interrogate a composite display over what it supports, so it has to be configured manually somewhere in the system. If your monitor doesn't support the system default, then you can't see a GUI in order to change the option, and there is no guaranteed supported configuration so the command line is about the only option.

The use cases for runtime switching of the "tv_mode" are exceedingly rare, so IMHO the property doesn't need exposing through the UAPI. However it was added to the UAPI about 8 years ago for vc4 and sunxi, and is also now used by other drivers, so can't be reverted. Does that mean it can now never be changed without jumping through the hoop of creating some userspace user?

Regards
Dave

[3] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_modes.c#L2232

#7 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 3 lines · Dave Stevenson

You want the commit text for a patch adding a new enum to state that the whole property isn't expected to be used through the UAPI? OK, I can roll a v2 if that is your desire.

By definition, anything new exposed by the kernel via KMS is new uAPI, even if it's not expected to be used by most compositors.

Quoted 9 lines
Quoted 9 lines

You should expect that all KMS clients will work towards programming all exposed KMS properties into known values. That's the only way to achieve repeatable KMS behaviour, because there is no KMS reset ioctl.

There are no two tiers of KMS properties AFAIK. You have to be the DRM master to change anything. So, people cannot force any settings from outside of a KMS client, they have to go through the KMS client, like xrandr goes through Xorg (and only Xorg).

Quoted 6 lines
Quoted 2 lines

I do fully expect Weston to gain support for this property, if anyone cares of its value. That goes for all Wayland compositors.

I don't know about Weston, but Wayfire / wlroots / sway have currently chosen to ignore all interlaced display modes [1].
[2] is the wlroots devs basically calling interlaced output a dead end.

Note, part of this thread is missing on GitLab:
https://github.com/swaywm/wlroots/issues/3038

Also note that none of that is set in stone if someone comes with a solid enough use-case.

Quoted 17 lines

That makes the debate for controlling the colour encoding on a composite video rather redundant as they're almost always interlaced.

[1] https://github.com/swaywm/sway/issues/3167
[2] https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3038

Quoted 11 lines

You're correct in that a KMS client would probably not know to control the value of this property automatically but it needs to come from configuration. That would be each KMS client's configuration. I don't understand how a script could achieve that.

However, if you feel it is important to have KMS properties that display servers must not touch, then they should be documented as such. I do not know if that would actually lift the new-UAPI requirements, that is for the DRM maintainers to decide and document. Is there such a thing already?

Quoted 8 lines
Quoted 2 lines

What are those "similar to xrandr" mechanisms? I don't think I've heard of any,

Boot to the console and run
modetest -w <connector id>:"tv_mode":"NTSC"

There is no reset mechanism for all properties, so that setting persists after modetest quits.

That is a hack. This hack is no guarantee to continue to work in the future. KMS is not intended to be abused this way.

There is a single component in charge of managing the KMS properties:
the compositor. Any attempt to bypass it only works by chance, if it works at all and doesn't result in fireworks.

Quoted 23 lines
Quoted 2 lines

and I've also completely missed any kernel command line arguments manipulating KMS properties.

"tv_mode" on the command line is handled in drm_mode_parse_cmdline_options() [3], as are rotate, reflect_x, reflect_y, margin_[left|right|top|bottom], and panel_orientation all to set the relevant KMS properties.

Having "video=Composite-1:PAL,tv_mode=Mono" on the kernel command line will set up connector Composite-1 with the standard 720x576 50Hz interlaced timings, and DRM_MODE_TV_MODE_MONOCHROME selected on the tv_mode property. Swap in different tv_mode descriptions as required (eg PAL,tv_mode=SECAM), although some make little sense.

That's the main route I'm looking at for configuring this property, for situations such as having a black and white TV connected. You don't get the opportunity to interrogate a composite display over what it supports, so it has to be configured manually somewhere in the system. If your monitor doesn't support the system default, then you can't see a GUI in order to change the option, and there is no guaranteed supported configuration so the command line is about the only option.

Quoted 6 lines

The use cases for runtime switching of the "tv_mode" are exceedingly rare, so IMHO the property doesn't need exposing through the UAPI. However it was added to the UAPI about 8 years ago for vc4 and sunxi, and is also now used by other drivers, so can't be reverted. Does that mean it can now never be changed without jumping through the hoop of creating some userspace user?

I don't know what the rules were 8 years ago, but the current uAPI rules are what they are, and a new enum entry is new uAPI.

maintainer
#8 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Hi,

Quoted 31 lines · Simon Ser
Quoted 23 lines · Dave Stevenson
Quoted 2 lines

and I've also completely missed any kernel command line arguments manipulating KMS properties.

"tv_mode" on the command line is handled in drm_mode_parse_cmdline_options() [3], as are rotate, reflect_x, reflect_y, margin_[left|right|top|bottom], and panel_orientation all to set the relevant KMS properties.

Having "video=Composite-1:PAL,tv_mode=Mono" on the kernel command line will set up connector Composite-1 with the standard 720x576 50Hz interlaced timings, and DRM_MODE_TV_MODE_MONOCHROME selected on the tv_mode property. Swap in different tv_mode descriptions as required (eg PAL,tv_mode=SECAM), although some make little sense.

That's the main route I'm looking at for configuring this property, for situations such as having a black and white TV connected. You don't get the opportunity to interrogate a composite display over what it supports, so it has to be configured manually somewhere in the system. If your monitor doesn't support the system default, then you can't see a GUI in order to change the option, and there is no guaranteed supported configuration so the command line is about the only option.

Quoted 6 lines

The use cases for runtime switching of the "tv_mode" are exceedingly rare, so IMHO the property doesn't need exposing through the UAPI. However it was added to the UAPI about 8 years ago for vc4 and sunxi, and is also now used by other drivers, so can't be reverted. Does that mean it can now never be changed without jumping through the hoop of creating some userspace user?

Quoted 2 lines

I don't know what the rules were 8 years ago, but the current uAPI rules are what they are, and a new enum entry is new uAPI.

TBF, and even if the wayland compositors support is missing, this property is perfectly usable as it is with upstream, open-source code, through either the command-line or X.org, and it's documented.

So it's fine by me from a UAPI requirement side.

Maxime

#9 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 8 lines · Maxime Ripard
Quoted 2 lines

I don't know what the rules were 8 years ago, but the current uAPI rules are what they are, and a new enum entry is new uAPI.

TBF, and even if the wayland compositors support is missing, this property is perfectly usable as it is with upstream, open-source code, through either the command-line or X.org, and it's documented.

So it's fine by me from a UAPI requirement side.

That is not a valid way to pass the uAPI requirements IMHO. Yes, one can program any KMS property via modetest or xrandr. Does that mean that none of the new uAPI need a "real" implementation anymore? Does that mean that the massive patch adding a color pipeline uAPI doesn't need user-space anymore?

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

#10 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 9 lines · Simon Ser
Quoted 7 lines · Maxime Ripard
Quoted 2 lines

I don't know what the rules were 8 years ago, but the current uAPI rules are what they are, and a new enum entry is new uAPI.

TBF, and even if the wayland compositors support is missing, this property is perfectly usable as it is with upstream, open-source code, through either the command-line or X.org, and it's documented.

Quoted 7 lines
Quoted 1 line

So it's fine by me from a UAPI requirement side.

That is not a valid way to pass the uAPI requirements IMHO. Yes, one can program any KMS property via modetest or xrandr. Does that mean that none of the new uAPI need a "real" implementation anymore? Does that mean that the massive patch adding a color pipeline uAPI doesn't need user-space anymore?

xrandr only supports properties on the connector, so it's right out for the color pipeline.

Also "we use xrandr for color properties" very much doesn't pass the bs filter of "is it a toy".

My take would be that this escape hatch is also not valid for all connector property, stuff that is clearly meant to be configured automatically by the compositors cannot use the "we use xrandr" excuse, because users can't type fast enough and hit <Enter> precisely enough to update a property in lockstep with the compositor's redraw loop :-)

Quoted 5 lines

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

I think it bends it pretty badly, because people running native Xorg are slowly going away, and the modetest hack does not clear the bar for "is it a joke/test/demo hack" for me.

I think some weston (or whatever compositor you like) config file support to set a bunch of "really only way to configure is by hand" output properties would clear the bar here for me. Because that is a feature I already mentioned that xrandr _does_ have, and which modetest hackery very much does not.
-Sima

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
maintainer
#11 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Hi,

Reviving this thread because I'm not sure what the outcome was.

Quoted 10 lines · Daniel Vetter
Quoted 5 lines

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

I think it bends it pretty badly, because people running native Xorg are slowly going away, and the modetest hack does not clear the bar for "is it a joke/test/demo hack" for me.

Quoted 5 lines

I think some weston (or whatever compositor you like) config file support to set a bunch of "really only way to configure is by hand" output properties would clear the bar here for me. Because that is a feature I already mentioned that xrandr _does_ have, and which modetest hackery very much does not.

The expectation (and general usage) for that property was that it was set by the kernel command line and then was forgotten about. Old TVs require one mode and that's it, so it doesn't make much sense to change it while the system is live, you just want the default to work.

So it's not really a matter of "the user-space code should be open" here, there's no user-space code, and there will likely never be given that it's mostly used to deal with decades-old systems at this point.

Maxime

#12 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 21 lines · Maxime Ripard

Hi,

Reviving this thread because I'm not sure what the outcome was.

Quoted 10 lines · Daniel Vetter
Quoted 5 lines

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

I think it bends it pretty badly, because people running native Xorg are slowly going away, and the modetest hack does not clear the bar for "is it a joke/test/demo hack" for me.

Quoted 5 lines

I think some weston (or whatever compositor you like) config file support to set a bunch of "really only way to configure is by hand" output properties would clear the bar here for me. Because that is a feature I already mentioned that xrandr _does_ have, and which modetest hackery very much does not.

Quoted 8 lines

The expectation (and general usage) for that property was that it was set by the kernel command line and then was forgotten about. Old TVs require one mode and that's it, so it doesn't make much sense to change it while the system is live, you just want the default to work.

So it's not really a matter of "the user-space code should be open" here, there's no user-space code, and there will likely never be given that it's mostly used to deal with decades-old systems at this point.

Yeah if this is being used just with the kernel cmdline, then I guess that's somewhat ok-ish. And TVs are horrible, so "massage your kernel cmdline" is comparitively not a horrible interface :-P

Anyway, I guess this makes this an ack.
-Sima

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#13 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Quoted 31 lines · Daniel Vetter
Quoted 21 lines · Maxime Ripard

Hi,

Reviving this thread because I'm not sure what the outcome was.

Quoted 10 lines · Daniel Vetter
Quoted 5 lines

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

I think it bends it pretty badly, because people running native Xorg are slowly going away, and the modetest hack does not clear the bar for "is it a joke/test/demo hack" for me.

Quoted 5 lines

I think some weston (or whatever compositor you like) config file support to set a bunch of "really only way to configure is by hand" output properties would clear the bar here for me. Because that is a feature I already mentioned that xrandr _does_ have, and which modetest hackery very much does not.

Quoted 8 lines

The expectation (and general usage) for that property was that it was set by the kernel command line and then was forgotten about. Old TVs require one mode and that's it, so it doesn't make much sense to change it while the system is live, you just want the default to work.

So it's not really a matter of "the user-space code should be open" here, there's no user-space code, and there will likely never be given that it's mostly used to deal with decades-old systems at this point.

Quoted 5 lines

Yeah if this is being used just with the kernel cmdline, then I guess that's somewhat ok-ish. And TVs are horrible, so "massage your kernel cmdline" is comparitively not a horrible interface :-P

Anyway, I guess this makes this an ack.

To clarify, since people asked about this on irc and why it's not a terrible precedence.

This is very much just for very, very dead old tech like analog TVs. If people try this escape hatch for hdmi or dp screens, the answer will be completely different :-)
-Sima

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#14 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Daniel Vetter
Quoted 5 lines · Daniel Vetter

I think some weston (or whatever compositor you like) config file support to set a bunch of "really only way to configure is by hand" output properties would clear the bar here for me. Because that is a feature I already mentioned that xrandr does have, and which modetest hackery very much does not.

FWIW, this is a feature I would very much not want to add in my own compositor. Not only there is a bunch of complexity exposing KMS props in config files (enums, bitfields, blobs, etc), but also I don't like the idea of having a way to set arbitrary KMS props behind my back, which would be a very easy way to mess up the KMS state and cause conflicts when the compositor is upgraded.

maintainer
#15 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Simon Ser

Hi Simon,

Quoted 9 lines · Simon Ser
Quoted 7 lines · Maxime Ripard
Quoted 2 lines

I don't know what the rules were 8 years ago, but the current uAPI rules are what they are, and a new enum entry is new uAPI.

TBF, and even if the wayland compositors support is missing, this property is perfectly usable as it is with upstream, open-source code, through either the command-line or X.org, and it's documented.

Quoted 7 lines
Quoted 1 line

So it's fine by me from a UAPI requirement side.

That is not a valid way to pass the uAPI requirements IMHO. Yes, one can program any KMS property via modetest or xrandr. Does that mean that none of the new uAPI need a "real" implementation anymore? Does that mean that the massive patch adding a color pipeline uAPI doesn't need user-space anymore?

I guess it's also a matter what the API is exactly? Like, xrandr or the kernel command line allows to use that particular API fully.

Can you fully exert the color pipeline uAPI with xrandr?

And at the time we submitted it, even with our best intent, we couldn't totally clear the userspace requirement because the PR would have been rejected because nobody wanted to deal with analog TV. And that's fair, any upstream project is free to do as it wants and analog TV is certainly not the state of the art anymore.

But we had some variation of that property used in many drivers (i915, nouveau, vc4, sun4i and amlogic from the top of my head), all drivers-specific, and having that kind of support was also one of the blockers to move the few remaining fbdev drivers to KMS.

It seems a bit unfair to put that requirement now that maybe some compositors could be interested.

Quoted 5 lines

The only thing I'm saying is that this breaks the usual DRM requirements. If, as a maintainer, you're fine with breaking the rules and have a good motivation to do so, that's fine by me. Rules are meant to be broken from time to time depending on the situation. But please don't pretend that modetest/xrandr is valid user-space to pass the rules.

Ack. And indeed, modetest surely was a bad example.

Maxime

#16 lore raw

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Dave Stevenson
Quoted 38 lines · On Mon, 26 Feb 2024 17:23:24 +0000 Dave Stevenson…

Hi Pekka

Sorry for the slight delay in replying.

Quoted 32 lines · Pekka Paalanen
Quoted 28 lines · On Mon, 26 Feb 2024 15:10:45 +0100 Maxime Ripard <[email protected]> wrote:

Hi Pekka,

Quoted 25 lines · Pekka Paalanen
Quoted 7 lines · On Fri, 16 Feb 2024 18:48:55 +0000 Dave Stevenson…

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Quoted 5 lines

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

since no-one else commented yet, I'd like to remind of the new UAPI requirements:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

AFAIU, adding a new value to an existing enum still counts as new UAPI.

Maybe there is no need for the full treatment here, or maybe there is, I'm not sure. I think you should make some statement about how the new UAPI requirements have been addressed.

...

Quoted 6 lines

The use cases for runtime switching of the "tv_mode" are exceedingly rare, so IMHO the property doesn't need exposing through the UAPI. However it was added to the UAPI about 8 years ago for vc4 and sunxi, and is also now used by other drivers, so can't be reverted. Does that mean it can now never be changed without jumping through the hoop of creating some userspace user?

That is for the DRM maintainers to decide. For that, they must first notice that this is indeed new UAPI.

History has shown that UAPI changes sometimes get through when they would have probably been rejected off-hand if a maintainer had a proper look. I saw an UAPI addition that was not in any way highlighted as such, with a topic that is probably uninteresting to most. The patch also did not discuss any of the details you now explained, which could serve as a justification. Naturally I screamed, hoping to attract maintainer attention.

Thanks,
pq

Quoted 5 lines

Regards
Dave

[3] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_modes.c#L2232

maintainer Applied
#17 lore raw

Re: (subset) [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Dave Stevenson
Quoted 9 lines · Dave Stevenson

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

[...]

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime

maintainer
#18 lore raw

Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

In reply to Dave Stevenson

Hi,

Quoted 24 lines · Dave Stevenson

From: Nick Hollinghurst <[email protected]>

Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal).

Change default mode creation to acommodate the new tv_mode value which comprises both 525-line and 625-line formats.

---
 drivers/gpu/drm/drm_connector.c    | 7 +++++++
 drivers/gpu/drm/drm_modes.c        | 5 ++++-
 drivers/gpu/drm/drm_probe_helper.c | 5 +++--
 include/drm/drm_connector.h        | 7 +++++++
 4 files changed, 21 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_connector.c +0 -0
index b0516505f7ae..fe05d27f3404 100644

drivers/gpu/drm/drm_connector.c static const struct drm_prop_enum_list drm_tv_mode_enum_list[] = { · line 1010

Quoted 6 lines
drivers/gpu/drm/drm_connector.c +1 -0
@@ -1005,6 +1005,7 @@ static const struct drm_prop_enum_list drm_tv_mode_enum_list[] = {
 	{ DRM_MODE_TV_MODE_PAL_M, "PAL-M" },
 	{ DRM_MODE_TV_MODE_PAL_N, "PAL-N" },
 	{ DRM_MODE_TV_MODE_SECAM, "SECAM" },
+	{ DRM_MODE_TV_MODE_MONOCHROME, "Mono" },
 };
 DRM_ENUM_NAME_FN(drm_get_tv_mode_name, drm_tv_mode_enum_

We'll need to have kunit tests here for that value in:

* drm_cmdline_parser_test to make sure it's properly read from the command line
* drm_connector_test to make sure the name is properly associated to its enum value
* drm_modes_test to make sure the modes generated for that tv mode actually returns 625 lines

Those would all have been additional patches, and the next patches need a new version as well so please add them to your v2.

Maxime

author maintainer
#19 lore raw

PATCH 2/3 drm/vc4: Add monochrome mode to the VEC.

In reply to Dave Stevenson

The VEC supports not producing colour bursts for monochrome output. It also has an option for disabling the chroma input to remove chroma from the signal.

Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb this in.

---
 drivers/gpu/drm/vc4/vc4_vec.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_vec.c +27 -1
index 268f18b10ee0..f9e134dd1e3b 100644
@@ -234,6 +234,7 @@ enum vc4_vec_tv_mode_id {
 	VC4_VEC_TV_MODE_PAL_60,
 	VC4_VEC_TV_MODE_PAL_N,
 	VC4_VEC_TV_MODE_SECAM,
+	VC4_VEC_TV_MODE_MONOCHROME,
 };
 
 struct vc4_vec_tv_mode {
@@ -324,6 +325,22 @@ static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] = {
 		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
 		.custom_freq = 0x29c71c72,
 	},
+	{
+		/* 50Hz mono */
+		.mode = DRM_MODE_TV_MODE_MONOCHROME,
+		.expected_htotal = 864,
+		.config0 = VEC_CONFIG0_PAL_BDGHI_STD | VEC_CONFIG0_BURDIS |
+			   VEC_CONFIG0_CHRDIS,
+		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
+	},
+	{
+		/* 60Hz mono */
+		.mode = DRM_MODE_TV_MODE_MONOCHROME,
+		.expected_htotal = 858,
+		.config0 = VEC_CONFIG0_PAL_M_STD | VEC_CONFIG0_BURDIS |
+			   VEC_CONFIG0_CHRDIS,
+		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
+	},
 };
 
 static inline const struct vc4_vec_tv_mode *
@@ -351,6 +368,7 @@ static const struct drm_prop_enum_list legacy_tv_mode_names[] = {
 	{ VC4_VEC_TV_MODE_PAL_M, "PAL-M", },
 	{ VC4_VEC_TV_MODE_PAL_N, "PAL-N", },
 	{ VC4_VEC_TV_MODE_SECAM, "SECAM", },
+	{ VC4_VEC_TV_MODE_MONOCHROME, "Mono", },
 };
 
 static enum drm_connector_status
@@ -406,6 +424,10 @@ vc4_vec_connector_set_property(struct drm_connector *connector,
 		state->tv.mode = DRM_MODE_TV_MODE_SECAM;
 		break;
 
+	case VC4_VEC_TV_MODE_MONOCHROME:
+		state->tv.mode = DRM_MODE_TV_MODE_MONOCHROME;
+		break;
+
 	default:
 		return -EINVAL;
 	}
@@ -453,6 +475,9 @@ vc4_vec_connector_get_property(struct drm_connector *connector,
 		*val = VC4_VEC_TV_MODE_SECAM;
 		break;
 
+	case DRM_MODE_TV_MODE_MONOCHROME:
+		return VC4_VEC_TV_MODE_MONOCHROME;
+
 	default:
 		return -EINVAL;
 	}
@@ -754,7 +779,8 @@ static int vc4_vec_bind(struct device *dev, struct device *master, void *data)
 					    BIT(DRM_MODE_TV_MODE_PAL) |
 					    BIT(DRM_MODE_TV_MODE_PAL_M) |
 					    BIT(DRM_MODE_TV_MODE_PAL_N) |
-					    BIT(DRM_MODE_TV_MODE_SECAM));
+					    BIT(DRM_MODE_TV_MODE_SECAM) |
+					    BIT(DRM_MODE_TV_MODE_MONOCHROME));
 	if (ret)
 		return ret;
 
Signature · 1 line
2.25.1
maintainer
#20 lore raw

Re: [PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

Hi,

Quoted 67 lines · Dave Stevenson

The VEC supports not producing colour bursts for monochrome output. It also has an option for disabling the chroma input to remove chroma from the signal.

Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb this in.

---
 drivers/gpu/drm/vc4/vc4_vec.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_vec.c +22 -0
index 268f18b10ee0..f9e134dd1e3b 100644
@@ -234,6 +234,7 @@ enum vc4_vec_tv_mode_id {
 	VC4_VEC_TV_MODE_PAL_60,
 	VC4_VEC_TV_MODE_PAL_N,
 	VC4_VEC_TV_MODE_SECAM,
+	VC4_VEC_TV_MODE_MONOCHROME,
 };
 
 struct vc4_vec_tv_mode {
@@ -324,6 +325,22 @@ static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] = {
 		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
 		.custom_freq = 0x29c71c72,
 	},
+	{
+		/* 50Hz mono */
+		.mode = DRM_MODE_TV_MODE_MONOCHROME,
+		.expected_htotal = 864,
+		.config0 = VEC_CONFIG0_PAL_BDGHI_STD | VEC_CONFIG0_BURDIS |
+			   VEC_CONFIG0_CHRDIS,
+		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
+	},
+	{
+		/* 60Hz mono */
+		.mode = DRM_MODE_TV_MODE_MONOCHROME,
+		.expected_htotal = 858,
+		.config0 = VEC_CONFIG0_PAL_M_STD | VEC_CONFIG0_BURDIS |
+			   VEC_CONFIG0_CHRDIS,
+		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
+	},
 };
 
 static inline const struct vc4_vec_tv_mode *
@@ -351,6 +368,7 @@ static const struct drm_prop_enum_list legacy_tv_mode_names[] = {
 	{ VC4_VEC_TV_MODE_PAL_M, "PAL-M", },
 	{ VC4_VEC_TV_MODE_PAL_N, "PAL-N", },
 	{ VC4_VEC_TV_MODE_SECAM, "SECAM", },
+	{ VC4_VEC_TV_MODE_MONOCHROME, "Mono", },
 };
 
 static enum drm_connector_status
@@ -406,6 +424,10 @@ vc4_vec_connector_set_property(struct drm_connector *connector,
 		state->tv.mode = DRM_MODE_TV_MODE_SECAM;
 		break;
 
+	case VC4_VEC_TV_MODE_MONOCHROME:
+		state->tv.mode = DRM_MODE_TV_MODE_MONOCHROME;
+		break;
+
 	default:
 		return -EINVAL;
 	}

drivers/gpu/drm/vc4/vc4_vec.c vc4_vec_connector_get_property(struct drm_connector *connector, · line 483

Quoted 9 lines
drivers/gpu/drm/vc4/vc4_vec.c +3 -0
@@ -453,6 +475,9 @@ vc4_vec_connector_get_property(struct drm_connector *connector,
 		*val = VC4_VEC_TV_MODE_SECAM;
 		break;
 
+	case DRM_MODE_TV_MODE_MONOCHROME:
+		return VC4_VEC_TV_MODE_MONOCHROME;
+
 	default:
 		return -EINVAL;
 	}

We don't need to expose the new value here, that property is only for the legacy, driver-specific property. So you should only need the vc4_vec_tv_modes changes

Maxime

author maintainer
#21 lore raw

Re: [PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

Hi Maxime

Quoted 74 lines · Maxime Ripard

Hi,

Quoted 70 lines · Dave Stevenson

The VEC supports not producing colour bursts for monochrome output. It also has an option for disabling the chroma input to remove chroma from the signal.

Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb this in.

---
 drivers/gpu/drm/vc4/vc4_vec.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_vec.c +22 -0
index 268f18b10ee0..f9e134dd1e3b 100644
@@ -234,6 +234,7 @@ enum vc4_vec_tv_mode_id {
      VC4_VEC_TV_MODE_PAL_60,
      VC4_VEC_TV_MODE_PAL_N,
      VC4_VEC_TV_MODE_SECAM,
+     VC4_VEC_TV_MODE_MONOCHROME,
 };
 
 struct vc4_vec_tv_mode {
@@ -324,6 +325,22 @@ static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] = {
              .config1 = VEC_CONFIG1_C_CVBS_CVBS,
              .custom_freq = 0x29c71c72,
      },
+     {
+             /* 50Hz mono */
+             .mode = DRM_MODE_TV_MODE_MONOCHROME,
+             .expected_htotal = 864,
+             .config0 = VEC_CONFIG0_PAL_BDGHI_STD | VEC_CONFIG0_BURDIS |
+                        VEC_CONFIG0_CHRDIS,
+             .config1 = VEC_CONFIG1_C_CVBS_CVBS,
+     },
+     {
+             /* 60Hz mono */
+             .mode = DRM_MODE_TV_MODE_MONOCHROME,
+             .expected_htotal = 858,
+             .config0 = VEC_CONFIG0_PAL_M_STD | VEC_CONFIG0_BURDIS |
+                        VEC_CONFIG0_CHRDIS,
+             .config1 = VEC_CONFIG1_C_CVBS_CVBS,
+     },
 };
 
 static inline const struct vc4_vec_tv_mode *
@@ -351,6 +368,7 @@ static const struct drm_prop_enum_list legacy_tv_mode_names[] = {
      { VC4_VEC_TV_MODE_PAL_M, "PAL-M", },
      { VC4_VEC_TV_MODE_PAL_N, "PAL-N", },
      { VC4_VEC_TV_MODE_SECAM, "SECAM", },
+     { VC4_VEC_TV_MODE_MONOCHROME, "Mono", },
 };
 
 static enum drm_connector_status
@@ -406,6 +424,10 @@ vc4_vec_connector_set_property(struct drm_connector *connector,
              state->tv.mode = DRM_MODE_TV_MODE_SECAM;
              break;
 
+     case VC4_VEC_TV_MODE_MONOCHROME:
+             state->tv.mode = DRM_MODE_TV_MODE_MONOCHROME;
+             break;
+
      default:
              return -EINVAL;
      }
@@ -453,6 +475,9 @@ vc4_vec_connector_get_property(struct drm_connector *connector,
              *val = VC4_VEC_TV_MODE_SECAM;
              break;
 
Quoted 2 lines

drivers/gpu/drm/vc4/vc4_vec.c vc4_vec_connector_get_property(struct drm_connector *connector, · line 479

Quoted 2 lines
drivers/gpu/drm/vc4/vc4_vec.c +2 -0
+     case DRM_MODE_TV_MODE_MONOCHROME:
+             return VC4_VEC_TV_MODE_MONOCHROME;

I have got an error here - it should be
*val = VC4_VEC_TV_MODE_MONOCHROME;
break;

Quoted 8 lines

drivers/gpu/drm/vc4/vc4_vec.c vc4_vec_connector_set_property(struct drm_connector *connector, · line 433

Quoted 4 lines
drivers/gpu/drm/vc4/vc4_vec.c +1 -0
+
      default:
              return -EINVAL;
      }

We don't need to expose the new value here, that property is only for the legacy, driver-specific property. So you should only need the vc4_vec_tv_modes changes

As both properties share the same underlying value, that means that if the new property selects Monochrome, the legacy one will return -EINVAL as it is an unknown value.

modetest and kmsprint -p both bomb out in this situation as by the looks of it we fail to get a pointer to the connector returned. That means you can't switch it back again.

Am I missing something?

Dave

author maintainer
#22 lore raw

PATCH 3/3 drm/vc4: vec: Add the margin properties to the connector

In reply to Dave Stevenson

All the handling for the properties was present, but they were never attached to the connector to allow userspace to change them.

Add them to the connector.

---
 drivers/gpu/drm/vc4/vc4_vec.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vc4/vc4_vec.c +2 -0
index f9e134dd1e3b..0aed18920d18 100644
@@ -528,6 +528,8 @@ static int vc4_vec_connector_init(struct drm_device *dev, struct vc4_vec *vec)
 
 	drm_object_attach_property(&connector->base, prop, VC4_VEC_TV_MODE_NTSC);
 
+	drm_connector_attach_tv_margin_properties(connector);
+
 	drm_connector_attach_encoder(connector, &vec->encoder.base);
 
 	return 0;
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 3/3
#23 lore raw

Re: [PATCH 3/3] drm/vc4: vec: Add the margin properties to the connector

Quoted 7 lines · Dave Stevenson

All the handling for the properties was present, but they were never attached to the connector to allow userspace to change them.

Add them to the connector.

[ ... ]

Thanks!
Maxime