Skip to contentSkip to conversation

vulkan-cts: add workaround for createMeshShaderMiscTestsEXT

PATCH Superseded [email protected] 3 participants 5 messages Jun 18, 2024 – Jun 19, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vulkan-cts: add workaround for createMeshShaderMiscTestsEXT

From: Randolph Sapp <[email protected]>

Remove the CXX flag "-O2" for GCC 13 and 14. There's a bug with ARM GCC that breaks the iteration of "types" in the createMeshShaderMiscTestsEXT function. This issue is not present for clang or x86_64 GCC 14.

It seems that the array is not initialized before the first iteration. In testing this can result in a random value being used. This can manifest in LINES type being processed twice, resulting in the following error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name 'no_lines' added to group 'misc'.

---
 meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +3 -0
index 1008a5fd4..7492fe9aa 100644
@@ -23,6 +23,9 @@ SRC_URI += "file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat
 
 TOOLCHAIN = "gcc"
 
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc = "-O2"
+
 S = "${WORKDIR}/git"
 
 REQUIRED_DISTRO_FEATURES = "vulkan"
Signature · 1 line
2.45.1
#1 lore raw
Quoted 29 lines · On Mon, Jun 17, 2024 at 5:52 PM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

Remove the CXX flag "-O2" for GCC 13 and 14. There's a bug with ARM GCC that breaks the iteration of "types" in the createMeshShaderMiscTestsEXT function. This issue is not present for clang or x86_64 GCC 14.

It seems that the array is not initialized before the first iteration. In testing this can result in a random value being used. This can manifest in LINES type being processed twice, resulting in the following error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name 'no_lines' added to group 'misc'.

---
 meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +0 -0
index 1008a5fd4..7492fe9aa 100644
@@ -23,6 +23,9 @@ SRC_URI +=

"file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat

TOOLCHAIN = "gcc"

meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb SRC_URI += "file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat · line 27

Quoted 2 lines
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +2 -0
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc = "-O2"

Let’s limit it to arm
And gcc using the needed overrides

Quoted 9 lines

+
S = "${WORKDIR}/git"

REQUIRED_DISTRO_FEATURES = "vulkan"
--
2.45.1

#2 lore raw
Quoted 7 lines · Khem Raj
Quoted 5 lines · On Mon, Jun 17, 2024 at 5:52 PM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

Remove the CXX flag "-O2" for GCC 13 and 14. There's a bug with ARM GCC that breaks the iteration of "types" in the createMeshShaderMiscTestsEXT function. This issue is not present for clang or x86_64 GCC 14.

Is there an upstream bug submitted that tracks it?

Quoted 39 lines
Quoted 23 lines

It seems that the array is not initialized before the first iteration. In testing this can result in a random value being used. This can manifest in LINES type being processed twice, resulting in the following error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name 'no_lines' added to group 'misc'.

---
 meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +0 -0
index 1008a5fd4..7492fe9aa 100644
@@ -23,6 +23,9 @@ SRC_URI +=

"file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat

TOOLCHAIN = "gcc"

meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb SRC_URI += "file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat · line 27

Quoted 2 lines
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +2 -0
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc = "-O2"

Let’s limit it to arm
And gcc using the needed overrides

Quoted 9 lines

+
S = "${WORKDIR}/git"

REQUIRED_DISTRO_FEATURES = "vulkan"
--
2.45.1

#3 lore raw
Quoted 10 lines · Denys Dmytriyenko
Quoted 7 lines · Khem Raj
Quoted 5 lines · On Mon, Jun 17, 2024 at 5:52 PM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

Remove the CXX flag "-O2" for GCC 13 and 14. There's a bug with ARM GCC that breaks the iteration of "types" in the createMeshShaderMiscTestsEXT function. This issue is not present for clang or x86_64 GCC 14.

Is there an upstream bug submitted that tracks it?

Not that I know of, at least for GCC. Still trying to track down where that should go and how to reproduce this in a way people will take it seriously.

About to have a PR in cts with two modifications to that function that also solve the issue, though. Hoping to get more insight from them.

Quoted 39 lines
Quoted 39 lines
Quoted 23 lines

It seems that the array is not initialized before the first iteration. In testing this can result in a random value being used. This can manifest in LINES type being processed twice, resulting in the following error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name 'no_lines' added to group 'misc'.

---
 meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +0 -0
index 1008a5fd4..7492fe9aa 100644
@@ -23,6 +23,9 @@ SRC_URI +=

"file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat

TOOLCHAIN = "gcc"

meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb SRC_URI += "file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat · line 27

Quoted 2 lines
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +2 -0
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc = "-O2"

Let’s limit it to arm
And gcc using the needed overrides

Quoted 9 lines

+
S = "${WORKDIR}/git"

REQUIRED_DISTRO_FEATURES = "vulkan"
--
2.45.1

#4 lore raw
Quoted 6 lines · Randolph Sapp
Quoted 5 lines · Denys Dmytriyenko
Quoted 4 lines · Khem Raj
Quoted 2 lines · On Mon, Jun 17, 2024 at 5:52 PM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

Remove the CXX flag "-O2" for GCC 13 and 14. There's a bug with ARM GCC that breaks the iteration of "types" in the createMeshShaderMiscTestsEXT function. This issue is not present for clang or x86_64 GCC 14.

Is there an upstream bug submitted that tracks it?

Not that I know of, at least for GCC. Still trying to track down where that should go and how to reproduce this in a way people will take it seriously.

Narrowing down the optimization flags that cause this while I wait for a GCC bugzilla account...

Quoted 2 lines

About to have a PR in cts with two modifications to that function that also solve the issue, though. Hoping to get more insight from them.

CTS PR open here if anyone wants to comment:
https://gerrit.khronos.org/c/vk-gl-cts/+/14984

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
Quoted 23 lines

It seems that the array is not initialized before the first iteration. In testing this can result in a random value being used. This can manifest in LINES type being processed twice, resulting in the following error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name 'no_lines' added to group 'misc'.

---
 meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +0 -0
index 1008a5fd4..7492fe9aa 100644
@@ -23,6 +23,9 @@ SRC_URI +=

"file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat

TOOLCHAIN = "gcc"

meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb SRC_URI += "file://0001-cmake-Define-WAYLAND_SCANNER-and-WAYLAND_PROTOCOLS_D.pat · line 27

Quoted 2 lines
meta-oe/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bb +2 -0
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc = "-O2"

Let’s limit it to arm
And gcc using the needed overrides

Quoted 9 lines

+
S = "${WORKDIR}/git"

REQUIRED_DISTRO_FEATURES = "vulkan"
--
2.45.1