arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
Subsystems (2)
PATCH 1/2 arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
use GPIO0_A2 as interrupt pin for PMIC. GPIO2_A6 was used for pre-production board.
--- arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +2 -2
@@ -241,8 +241,8 @@ &i2c1 { rk805: pmic@18 { compatible = "rockchip,rk805"; reg = <0x18>; - interrupt-parent = <&gpio2>; - interrupts = <6 IRQ_TYPE_LEVEL_LOW>; + interrupt-parent = <&gpio0>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; #clock-cells = <1>; clock-output-names = "xin32k", "rk805-clkout2"; gpio-controller;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 2/2 arm64: dts: rockchip: reorder mmc aliases for ROCK Pi E
align with other Radxa products.
- mmc0 is eMMC
- mmc1 is microSD
--- arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +2 -2
@@ -23,8 +23,8 @@ / { aliases { ethernet0 = &gmac2io; ethernet1 = &gmac2phy; - mmc0 = &sdmmc; - mmc1 = &emmc; + mmc0 = &emmc; + mmc1 = &sdmmc; }; chosen {
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: (subset) [PATCH 1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
In reply to FUKAUMI NaokiQuoted 4 lines · FUKAUMI Naoki
use
GPIO0_A2as interrupt pin for PMIC.GPIO2_A6was used for pre-production board.
Applied, thanks!
[1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
commit: 02afd3d5b9fa4ffed284c0f7e7bec609097804fc
Patch 2 is not appropriate, sorry.
The aliases are sorted this way since 2021 and the order is userspace- facing. So for the last 3 years people have boards with the sdmmc as mmc0 and changing this now would possibly break a number of boards.
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>
Re: (subset) [PATCH 1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
Hello,
Quoted 9 lines · Heiko Stuebner
Quoted 4 lines · FUKAUMI Naoki
use
GPIO0_A2as interrupt pin for PMIC.GPIO2_A6was used for pre-production board.Applied, thanks!
[1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
Quoted 8 lines
commit: 02afd3d5b9fa4ffed284c0f7e7bec609097804fcPatch 2 is not appropriate, sorry.
The aliases are sorted this way since 2021 and the order is userspace- facing. So for the last 3 years people have boards with the sdmmc as mmc0 and changing this now would possibly break a number of boards.
this is the reason I didn't add Fixes tag. I think this change in next major release is acceptable... but it's wrong?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerRe: (subset) [PATCH 1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
Am Mittwoch, 19. Juni 2024, 22:07:25 CEST schrieb FUKAUMI Naoki:
Quoted 15 lines
Hello,
Quoted 12 lines · Heiko Stuebner
Quoted 4 lines · FUKAUMI Naoki
use
GPIO0_A2as interrupt pin for PMIC.GPIO2_A6was used for pre-production board.Applied, thanks!
[1/2] arm64: dts: rockchip: fix PMIC interrupt pin on ROCK Pi E
commit: 02afd3d5b9fa4ffed284c0f7e7bec609097804fc
Quoted 8 lines
Quoted 5 lines
Patch 2 is not appropriate, sorry.
The aliases are sorted this way since 2021 and the order is userspace- facing. So for the last 3 years people have boards with the sdmmc as mmc0 and changing this now would possibly break a number of boards.
this is the reason I didn't add Fixes tag. I think this change in next major release is acceptable... but it's wrong?
Correct.
Because with that change, all people mounting /dev/mmcblk0p1 or whatever in their system would break their userspace after a simple kernel update.
And that falls under the "we don't break userspace" mantra.
People should be able to expect their system to keep booting with kernel updates, without neededing to meticulously validate each kernel release.
Hence that mmc order needs to stay that way.
Heiko