Skip to contentSkip to conversation

drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

PATCH Superseded Mitul Golani 2 participants 3 messages Jun 19, 2024

Subsystems (3)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

The dispcnlunit1_cp_xosc_clk should be de-asserted in display off and only asserted in display on. But during observation it found clk remains active in display OFF. As workaround, Display driver shall execute set-reset sequence at the end of the Initialize Sequence.

Wa_14020225554

Mitul Golani (1):
drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

 drivers/gpu/drm/i915/display/intel_display_power.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.45.2
#1 lore raw

PATCH v2 1/1 drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

The dispcnlunit1_cp_xosc_clk should be de-asserted in display off and only asserted in display on. But during observation it found clk remains active in display OFF. As workaround, Display driver shall execute set-reset sequence at the end of the Initialize Sequence.

Wa_14020225554

--v2:
- Update workaround number in commit message.

---
 drivers/gpu/drm/i915/display/intel_display_power.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_display_power.c +8 -0
index e288a1b21d7e..0d8875fa5ef2 100644
@@ -1704,6 +1704,14 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
 	/* Wa_14011503030:xelpd */
 	if (DISPLAY_VER(dev_priv) == 13)
 		intel_de_write(dev_priv, XELPD_DISPLAY_ERR_FATAL_MASK, ~0);
+
+	/* Wa_14020225554 */
+	if (DISPLAY_VER(dev_priv) == 20) {
+		intel_de_write(dev_priv, SOUTH_DSPCLK_GATE_D,
+			       PCH_GMBUSUNIT_CLOCK_GATE_DISABLE);
+		intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D,
+			     PCH_GMBUSUNIT_CLOCK_GATE_DISABLE, 0);
+	}
 }
 
 static void icl_display_core_uninit(struct drm_i915_private *dev_priv)
Signature · 1 line
2.45.2
#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

In reply to Mitul Golani
== Series Details ==

== Series Details ==

Series: drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock
URL : https://patchwork.freedesktop.org/series/135056/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14969 -> Patchwork_135056v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/index.html

Participating hosts (40 -> 38)
------------------------------

Additional (1): fi-kbl-8809g
Missing (3): fi-glk-j4005 fi-snb-2520m fi-bsw-n3050

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_135056v1:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live:
- {bat-mtlp-9}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-mtlp-9/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_135056v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/fi-kbl-8809g/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/fi-kbl-8809g/igt@[email protected]

* igt@i915_module_load@load:
- bat-dg2-8: [PASS][4] -> [DMESG-WARN][5] ([i915#10014])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14969/bat-dg2-8/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-dg2-8/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-8809g: NOTRUN -> [SKIP][6] +30 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/fi-kbl-8809g/igt@[email protected]

#### Possible fixes ####

* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- {bat-mtlp-9}: [DMESG-WARN][7] ([i915#11009]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14969/bat-mtlp-9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-mtlp-9/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-arls-2: [DMESG-WARN][9] ([i915#7507]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14969/bat-arls-2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-arls-2/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-dp-6:
- {bat-mtlp-9}: [DMESG-FAIL][11] ([i915#11009]) -> [PASS][12] +2 other tests pass
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14969/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-7:
- {bat-mtlp-9}: [FAIL][13] ([i915#10979]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14969/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/bat-mtlp-9/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#10014]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10014
[i915#10580]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10580
[i915#10979]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10979
[i915#11009]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11009
[i915#11375]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11375
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#6121]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6121
[i915#7507]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507

Build changes
-------------

* Linux: CI_DRM_14969 -> Patchwork_135056v1

CI-20190529: 20190529
CI_DRM_14969: 5ce321df94a7bbaad2cb8c98f9cb8115dfb566c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7892: 7892
Patchwork_135056v1: 5ce321df94a7bbaad2cb8c98f9cb8115dfb566c7 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135056v1/index.html