KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
Subsystems (4)
PATCH v2 1/1 KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
make allmodconfig && make W=1 C=1 reports for lib/test_*.ko:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
---
Changes in v2:
- Updated the description of lib/test_kprobes.c per Masami
- Removed references to lib/test_user_copy since that is being renamed in
https://lore.kernel.org/all/[email protected]/
and the description added in
https://lore.kernel.org/all/[email protected]/
- Link to v1: https://lore.kernel.org/r/[email protected]
--- lib/dhry_run.c | 1 + lib/test-kstrtox.c | 1 + lib/test_bits.c | 1 + lib/test_blackhole_dev.c | 1 + lib/test_firmware.c | 1 + lib/test_free_pages.c | 1 + lib/test_hash.c | 1 + lib/test_hexdump.c | 1 + lib/test_ida.c | 1 + lib/test_kprobes.c | 3 ++- lib/test_list_sort.c | 1 + lib/test_memcat_p.c | 1 + lib/test_meminit.c | 1 + lib/test_min_heap.c | 1 + lib/test_module.c | 1 + lib/test_ref_tracker.c | 3 ++- lib/test_sort.c | 1 + lib/test_static_key_base.c | 1 + lib/test_static_keys.c | 1 + lib/test_sysctl.c | 1 + 20 files changed, 22 insertions(+), 2 deletions(-)
lib/dhry_run.c +1 -0
@@ -83,4 +83,5 @@ static int __init dhry_init(void)module_init (dhry_init);MODULE_AUTHOR ("Geert Uytterhoeven <[email protected]>" ); +MODULE_DESCRIPTION ("Dhrystone benchmark test module" );MODULE_LICENSE ("GPL" );
lib/test-kstrtox.c +1 -0
@@ -732,4 +732,5 @@ static int __init test_kstrtox_init(void)return -EINVAL ; }module_init (test_kstrtox_init); +MODULE_DESCRIPTION ("Module test for kstrto*() APIs" );MODULE_LICENSE ("Dual BSD/GPL" );
lib/test_bits.c +1 -0
@@ -72,4 +72,5 @@ static struct kunit_suite bits_test_suite = { };kunit_test_suite (bits_test_suite); +MODULE_DESCRIPTION ("Test cases for functions and macros in bits.h" );MODULE_LICENSE ("GPL" );
lib/test_blackhole_dev.c +1 -0
@@ -96,4 +96,5 @@ module_init(test_blackholedev_init);module_exit (test_blackholedev_exit);MODULE_AUTHOR ("Mahesh Bandewar <[email protected]>" ); +MODULE_DESCRIPTION ("module test of the blackhole_dev" );MODULE_LICENSE ("GPL" );
lib/test_firmware.c +1 -0
@@ -1567,4 +1567,5 @@ static void __exit test_firmware_exit(void)module_exit (test_firmware_exit);MODULE_AUTHOR ("Kees Cook <[email protected]>" ); +MODULE_DESCRIPTION ("interface to trigger and test firmware loading" );MODULE_LICENSE ("GPL" );
lib/test_free_pages.c +1 -0
@@ -44,4 +44,5 @@ static void m_ex(void)module_init (m_in);module_exit (m_ex);MODULE_AUTHOR ("Matthew Wilcox <[email protected]>" ); +MODULE_DESCRIPTION ("Check that free_pages() doesn't leak memory" );MODULE_LICENSE ("GPL" );
lib/test_hash.c +1 -0
@@ -235,4 +235,5 @@ static struct kunit_suite hash_test_suite = {kunit_test_suite (hash_test_suite); +MODULE_DESCRIPTION ("Test cases for <linux/hash.h> and <linux/stringhash.h>" );MODULE_LICENSE ("GPL" );
lib/test_hexdump.c +1 -0
@@ -253,4 +253,5 @@ static void __exit test_hexdump_exit(void)module_exit (test_hexdump_exit);MODULE_AUTHOR ("Andy Shevchenko <[email protected]>" ); +MODULE_DESCRIPTION ("Test cases for lib/hexdump.c module" );MODULE_LICENSE ("Dual BSD/GPL" );
lib/test_ida.c +1 -0
@@ -214,4 +214,5 @@ static void ida_exit(void)module_init (ida_checks);module_exit (ida_exit);MODULE_AUTHOR ("Matthew Wilcox <[email protected]>" ); +MODULE_DESCRIPTION ("Test the IDA API" );MODULE_LICENSE ("GPL" );
lib/test_kprobes.c +2 -1
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-or-later /* -* test_kprobes.c - simple sanity test for *probes +* test_kprobes.c - simple sanity test for k*probes * * Copyright IBM Corp. 2008 */
@@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {kunit_test_suites (&kprobes_test_suite); +MODULE_DESCRIPTION ("simple sanity test for k*probes" );MODULE_LICENSE ("GPL" );
lib/test_list_sort.c +1 -0
@@ -119,4 +119,5 @@ static struct kunit_suite list_sort_suite = {kunit_test_suites (&list_sort_suite); +MODULE_DESCRIPTION ("list_sort() KUnit test suite" );MODULE_LICENSE ("GPL" );
lib/test_memcat_p.c +1 -0
@@ -112,4 +112,5 @@ static void __exit test_memcat_p_exit(void)module_init (test_memcat_p_init);module_exit (test_memcat_p_exit); +MODULE_DESCRIPTION ("Test cases for memcat_p() in lib/memcat_p.c" );MODULE_LICENSE ("GPL" );
lib/test_meminit.c +1 -0
@@ -436,4 +436,5 @@ static int __init test_meminit_init(void) }module_init (test_meminit_init); +MODULE_DESCRIPTION ("Test cases for SL[AOU]B/page initialization at alloc/free time" );MODULE_LICENSE ("GPL" );
lib/test_min_heap.c +1 -0
@@ -191,4 +191,5 @@ static void __exit test_min_heap_exit(void) }module_exit (test_min_heap_exit); +MODULE_DESCRIPTION ("Test cases for the min max heap" );MODULE_LICENSE ("GPL" );
lib/test_module.c +1 -0
@@ -31,4 +31,5 @@ static void __exit test_module_exit(void)module_exit (test_module_exit);MODULE_AUTHOR ("Kees Cook <[email protected]>" ); +MODULE_DESCRIPTION ("module loading subsystem test module" );MODULE_LICENSE ("GPL" );
lib/test_ref_tracker.c +2 -1
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Referrence tracker self test. +* Reference tracker self test. * * Copyright (c) 2021 Eric Dumazet <[email protected]> */
@@ -112,4 +112,5 @@ static void __exit test_ref_tracker_exit(void)module_init (test_ref_tracker_init);module_exit (test_ref_tracker_exit); +MODULE_DESCRIPTION ("Reference tracker self test" );MODULE_LICENSE ("GPL v2" );
lib/test_sort.c +1 -0
@@ -45,4 +45,5 @@ static struct kunit_suite sort_test_suite = {kunit_test_suites (&sort_test_suite); +MODULE_DESCRIPTION ("sort() KUnit test suite" );MODULE_LICENSE ("GPL" );
lib/test_static_key_base.c +1 -0
@@ -57,4 +57,5 @@ module_init(test_static_key_base_init);module_exit (test_static_key_base_exit);MODULE_AUTHOR ("Jason Baron <[email protected]>" ); +MODULE_DESCRIPTION ("Kernel module to support testing static keys" );MODULE_LICENSE ("GPL" );
lib/test_static_keys.c +1 -0
@@ -236,4 +236,5 @@ module_init(test_static_key_init);module_exit (test_static_key_exit);MODULE_AUTHOR ("Jason Baron <[email protected]>" ); +MODULE_DESCRIPTION ("Kernel module for testing static keys" );MODULE_LICENSE ("GPL" );
lib/test_sysctl.c +1 -0
@@ -280,4 +280,5 @@ static void __exit test_sysctl_exit(void)module_exit (test_sysctl_exit);MODULE_AUTHOR ("Luis R. Rodriguez <[email protected]>" ); +MODULE_DESCRIPTION ("proc sysctl test driver" );MODULE_LICENSE ("GPL" );
---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-lib-test-16083d9d77e2
Quoted 21 lines · Jeff Johnson
make allmodconfig && make W=1 C=1 reports for
lib/test_*.ko:
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_hexdump.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_dhry.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_firmware.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_sysctl.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_hash.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_ida.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_list_sort.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_min_heap.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_module.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_sort.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_static_keys.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_static_key_base.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_memcat_p.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_blackhole_dev.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_meminit.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_free_pages.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_kprobes.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_ref_tracker.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_bits.o
Quoted 3 lines
Add the missing invocations of the
MODULE_DESCRIPTION()macro.Signed-off-by Jeff Johnson <[email protected]>
Thanks for chasing these down!
Signature · 1 line
Kees Cook
Quoted 21 lines · On Wed, 19 Jun 2024 13:59:15 -0700 Jeff Johnson <[email protected]>…
make allmodconfig && make W=1 C=1 reports for
lib/test_*.ko:
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_hexdump.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_dhry.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_firmware.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_sysctl.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_hash.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_ida.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_list_sort.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_min_heap.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_module.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_sort.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_static_keys.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_static_key_base.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_memcat_p.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_blackhole_dev.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_meminit.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_free_pages.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_kprobes.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_ref_tracker.o
WARNING: modpost: missingMODULE_DESCRIPTION()inlib/test_bits.o
Quoted 6 lines
Add the missing invocations of the
MODULE_DESCRIPTION()macro.Signed-off-by Jeff Johnson <[email protected]>---
Changes in v2:
- Updated the description oflib/test_kprobes.cper Masami
Confirmed. Thanks!
Quoted 249 lines
- Removed references to
lib/test_user_copysince that is being renamed in
https://lore.kernel.org/all/[email protected]/
and the description added in
https://lore.kernel.org/all/[email protected]/
- Link to v1: https://lore.kernel.org/r/[email protected]--- lib/dhry_run.c | 1 + lib/test-kstrtox.c | 1 + lib/test_bits.c | 1 + lib/test_blackhole_dev.c | 1 + lib/test_firmware.c | 1 + lib/test_free_pages.c | 1 + lib/test_hash.c | 1 + lib/test_hexdump.c | 1 + lib/test_ida.c | 1 + lib/test_kprobes.c | 3 ++- lib/test_list_sort.c | 1 + lib/test_memcat_p.c | 1 + lib/test_meminit.c | 1 + lib/test_min_heap.c | 1 + lib/test_module.c | 1 + lib/test_ref_tracker.c | 3 ++- lib/test_sort.c | 1 + lib/test_static_key_base.c | 1 + lib/test_static_keys.c | 1 + lib/test_sysctl.c | 1 + 20 files changed, 22 insertions(+), 2 deletions(-)lib/dhry_run.c +1
-0@@ -83,4 +83,5 @@ static int __init dhry_init(void)module_init (dhry_init);MODULE_AUTHOR ("Geert Uytterhoeven <[email protected]>" ); +MODULE_DESCRIPTION ("Dhrystone benchmark test module" );MODULE_LICENSE ("GPL" );lib/test-kstrtox.c +1
-0@@ -732,4 +732,5 @@ static int __init test_kstrtox_init(void)return -EINVAL ; }module_init (test_kstrtox_init); +MODULE_DESCRIPTION ("Module test for kstrto*() APIs" );MODULE_LICENSE ("Dual BSD/GPL" );lib/test_bits.c +1
-0@@ -72,4 +72,5 @@ static struct kunit_suite bits_test_suite = { };kunit_test_suite (bits_test_suite); +MODULE_DESCRIPTION ("Test cases for functions and macros in bits.h" );MODULE_LICENSE ("GPL" );lib/test_blackhole_dev.c +1
-0@@ -96,4 +96,5 @@ module_init(test_blackholedev_init);module_exit (test_blackholedev_exit);MODULE_AUTHOR ("Mahesh Bandewar <[email protected]>" ); +MODULE_DESCRIPTION ("module test of the blackhole_dev" );MODULE_LICENSE ("GPL" );lib/test_firmware.c +1
-0@@ -1567,4 +1567,5 @@ static void __exit test_firmware_exit(void)module_exit (test_firmware_exit);MODULE_AUTHOR ("Kees Cook <[email protected]>" ); +MODULE_DESCRIPTION ("interface to trigger and test firmware loading" );MODULE_LICENSE ("GPL" );lib/test_free_pages.c +1
-0@@ -44,4 +44,5 @@ static void m_ex(void)module_init (m_in);module_exit (m_ex);MODULE_AUTHOR ("Matthew Wilcox <[email protected]>" ); +MODULE_DESCRIPTION ("Check that free_pages() doesn't leak memory" );MODULE_LICENSE ("GPL" );lib/test_hash.c +1
-0@@ -235,4 +235,5 @@ static struct kunit_suite hash_test_suite = {kunit_test_suite (hash_test_suite); +MODULE_DESCRIPTION ("Test cases for <linux/hash.h> and <linux/stringhash.h>" );MODULE_LICENSE ("GPL" );lib/test_hexdump.c +1
-0@@ -253,4 +253,5 @@ static void __exit test_hexdump_exit(void)module_exit (test_hexdump_exit);MODULE_AUTHOR ("Andy Shevchenko <[email protected]>" ); +MODULE_DESCRIPTION ("Test cases for lib/hexdump.c module" );MODULE_LICENSE ("Dual BSD/GPL" );lib/test_ida.c +1
-0@@ -214,4 +214,5 @@ static void ida_exit(void)module_init (ida_checks);module_exit (ida_exit);MODULE_AUTHOR ("Matthew Wilcox <[email protected]>" ); +MODULE_DESCRIPTION ("Test the IDA API" );MODULE_LICENSE ("GPL" );lib/test_kprobes.c +2
-1@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-or-later /* -* test_kprobes.c - simple sanity test for *probes +* test_kprobes.c - simple sanity test for k*probes * * Copyright IBM Corp. 2008 */ @@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {kunit_test_suites (&kprobes_test_suite); +MODULE_DESCRIPTION ("simple sanity test for k*probes" );MODULE_LICENSE ("GPL" );lib/test_list_sort.c +1
-0@@ -119,4 +119,5 @@ static struct kunit_suite list_sort_suite = {kunit_test_suites (&list_sort_suite); +MODULE_DESCRIPTION ("list_sort() KUnit test suite" );MODULE_LICENSE ("GPL" );lib/test_memcat_p.c +1
-0@@ -112,4 +112,5 @@ static void __exit test_memcat_p_exit(void)module_init (test_memcat_p_init);module_exit (test_memcat_p_exit); +MODULE_DESCRIPTION ("Test cases for memcat_p() in lib/memcat_p.c" );MODULE_LICENSE ("GPL" );lib/test_meminit.c +1
-0@@ -436,4 +436,5 @@ static int __init test_meminit_init(void) }module_init (test_meminit_init); +MODULE_DESCRIPTION ("Test cases for SL[AOU]B/page initialization at alloc/free time" );MODULE_LICENSE ("GPL" );lib/test_min_heap.c +1
-0@@ -191,4 +191,5 @@ static void __exit test_min_heap_exit(void) }module_exit (test_min_heap_exit); +MODULE_DESCRIPTION ("Test cases for the min max heap" );MODULE_LICENSE ("GPL" );lib/test_module.c +1
-0@@ -31,4 +31,5 @@ static void __exit test_module_exit(void)module_exit (test_module_exit);MODULE_AUTHOR ("Kees Cook <[email protected]>" ); +MODULE_DESCRIPTION ("module loading subsystem test module" );MODULE_LICENSE ("GPL" );lib/test_ref_tracker.c +2
-1@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Referrence tracker self test. +* Reference tracker self test. * * Copyright (c) 2021 Eric Dumazet <[email protected]> */ @@ -112,4 +112,5 @@ static void __exit test_ref_tracker_exit(void)module_init (test_ref_tracker_init);module_exit (test_ref_tracker_exit); +MODULE_DESCRIPTION ("Reference tracker self test" );MODULE_LICENSE ("GPL v2" );lib/test_sort.c +1
-0@@ -45,4 +45,5 @@ static struct kunit_suite sort_test_suite = {kunit_test_suites (&sort_test_suite); +MODULE_DESCRIPTION ("sort() KUnit test suite" );MODULE_LICENSE ("GPL" );lib/test_static_key_base.c +1
-0@@ -57,4 +57,5 @@ module_init(test_static_key_base_init);module_exit (test_static_key_base_exit);MODULE_AUTHOR ("Jason Baron <[email protected]>" ); +MODULE_DESCRIPTION ("Kernel module to support testing static keys" );MODULE_LICENSE ("GPL" );lib/test_static_keys.c +1
-0@@ -236,4 +236,5 @@ module_init(test_static_key_init);module_exit (test_static_key_exit);MODULE_AUTHOR ("Jason Baron <[email protected]>" ); +MODULE_DESCRIPTION ("Kernel module for testing static keys" );MODULE_LICENSE ("GPL" );lib/test_sysctl.c +1
-1@@ -280,4 +280,5 @@ static void __exit test_sysctl_exit(void)module_exit (test_sysctl_exit);MODULE_AUTHOR ("Luis R. Rodriguez <[email protected]>" ); +MODULE_DESCRIPTION ("proc sysctl test driver" );MODULE_LICENSE ("GPL" ); ---base-commit:
b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-lib-test-16083d9d77e2
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>