cmd: gpt: Fix freeing gpt_pte in gpt_verify()
PATCH 1/1 cmd: gpt: Fix freeing gpt_pte in gpt_verify()
In case when either gpt_verify_headers() or gpt_verify_partitions() fails, the memory allocated for gpt_pte will be freed in those functions internally, but gpt_pte will still contain non-NULL dangling pointer. The attempt to free it in those cases in gpt_verify() leads to "use after free" error, which leads to a "Synchronous abort" exception.
This issue was found by running the next command on the device with incorrect partition table:
=> gpt verify mmc 0 $partitions
which results to:
No partition list provided - only basic check
"Synchronous Abort" handler, esr 0x96000021, far 0xba247bff
....Fix the issue by only freeing gpt_pte if none of those functions failed.
--- cmd/gpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
cmd/gpt.c +2 -1
@@ -683,7 +683,8 @@ static int gpt_verify(struct blk_desc *blk_dev_desc, const char *str_part)free (str_disk_guid);free (partitions); out: -free (gpt_pte); +if (!ret) +free (gpt_pte);return ret; }
Signature · 1 line
2.39.2
Quoted 10 lines · Sam Protsenko
In case when either
gpt_verify_headers()orgpt_verify_partitions()fails, the memory allocated forgpt_ptewill be freed in those functions internally, butgpt_ptewill still contain non-NULL dangling pointer. The attempt to free it in those cases ingpt_verify()leads to "use after free" error, which leads to a "Synchronous abort" exception.This issue was found by running the next command on the device with incorrect partition table:
[...]
Applied to u-boot/next, thanks!
Signature · 1 line
Tom