Skip to contentSkip to conversation

imx8mp-venice-gw702x: Drop EQos clock workaround

PATCH In review Tim Harvey 2 participants 4 messages Jun 20, 2024 – Jun 24, 2024

Subsystems (2)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 imx8mp-venice-gw702x: Drop EQos clock workaround

The assigned-clock no longer have to be dropped, the clock are now defined in clk-imx8mp.c and used by DWMAC driver to configure the DWMAC clock. Drop the workarounds from U-Boot specific DT extras.

Having the clocks dropped causes the EQoS to be non-functional.

See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock workaround").

Fixes 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support")
---
 arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi +0 -6
index b9e3db7de937..98f71c73c986 100644
@@ -4,9 +4,3 @@
  */
 
 #include "imx8mp-venice-u-boot.dtsi"
-
-&eqos {
-	/delete-property/ assigned-clocks;
-	/delete-property/ assigned-clock-parents;
-	/delete-property/ assigned-clock-rates;
-};
Signature · 1 line
2.25.1
reviewer
#1 lore raw

Hi Tim,

Quoted 5 lines · Tim Harvey

The assigned-clock no longer have to be dropped, the clock are now defined in clk-imx8mp.c and used by DWMAC driver to configure the DWMAC clock. Drop the workarounds from U-Boot specific DT extras.

Quoted 7 lines

Having the clocks dropped causes the EQoS to be non-functional.

See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock workaround").

Fixes 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support")

Is this targetted for master or next?

author
#2 lore raw
Quoted 11 lines · Fabio Estevam

Hi Tim,

Quoted 7 lines · Tim Harvey

The assigned-clock no longer have to be dropped, the clock are now defined in clk-imx8mp.c and used by DWMAC driver to configure the DWMAC clock. Drop the workarounds from U-Boot specific DT extras.

Having the clocks dropped causes the EQoS to be non-functional.

Quoted 7 lines
Quoted 5 lines

See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock workaround").

Fixes 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support")

Is this targetted for master or next?

Hi Fabio,

It doesn't make much difference to me. This is a fix for a board model that was renamed from gw7905 to gw7500 anyway which is a change in dts/upstream I'm going to have to wait for anyway so you can leave it for next if you want. I actually have about 8 patches in my repo to dts/upstream from linux 6.9 and upcoming linux 6.10 as dts/upstream was last merged from v6.8.

The set of 5 or so patches I sent in the last few days are all fixes of sorts and they are all isolated to board/gateworks/venice so don't affect anyone else.

Best Regards,

Tim

reviewer
#3 lore raw

Hi Tim,

Quoted 9 lines · Tim Harvey

Hi Fabio,

It doesn't make much difference to me. This is a fix for a board model that was renamed from gw7905 to gw7500 anyway which is a change in dts/upstream I'm going to have to wait for anyway so you can leave it for next if you want. I actually have about 8 patches in my repo to dts/upstream from linux 6.9 and upcoming linux 6.10 as dts/upstream was last merged from v6.8.

Quoted 3 lines

The set of 5 or so patches I sent in the last few days are all fixes of sorts and they are all isolated to board/gateworks/venice so don't affect anyone else.

Applied this one and your other patches to u-boot-imx/next, thanks.