Skip to contentSkip to conversation

media: i2c: Kconfig: Fix missing firmware upload config select

PATCH In review Kory Maincent 3 participants 3 messages Jun 20, 2024 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: Kconfig: Fix missing firmware upload config select

FW_LOADER config only selects the firmware loader API, but we also need the sysfs_upload symbols for firmware_upload_unregister() and firmware_upload_register() to function properly.

Fixes 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
---
 drivers/media/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/Kconfig +1 -0
index c6d3ee472d81..742bc665602e 100644
@@ -679,6 +679,7 @@ config VIDEO_THP7312
 	tristate "THine THP7312 support"
 	depends on I2C
 	select FW_LOADER
+	select FW_UPLOAD
 	select MEDIA_CONTROLLER
 	select V4L2_CCI_I2C
 	select V4L2_FWNODE
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Kory,

Thank you for the patch.

Quoted 6 lines · Kory Maincent

FW_LOADER config only selects the firmware loader API, but we also need the sysfs_upload symbols for firmware_upload_unregister() and firmware_upload_register() to function properly.

Fixes 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
Quoted 16 lines
---
 drivers/media/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/Kconfig +1 -0
index c6d3ee472d81..742bc665602e 100644
@@ -679,6 +679,7 @@ config VIDEO_THP7312
 	tristate "THine THP7312 support"
 	depends on I2C
 	select FW_LOADER
+	select FW_UPLOAD
 	select MEDIA_CONTROLLER
 	select V4L2_CCI_I2C
 	select V4L2_FWNODE
Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by on v1 1/1
#2 lore raw
In reply to Kory Maincent
Quoted 6 lines · Kory Maincent

FW_LOADER config only selects the firmware loader API, but we also need the sysfs_upload symbols for firmware_upload_unregister() and firmware_upload_register() to function properly.

Fixes 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
Quoted 20 lines
---
 drivers/media/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/Kconfig +1 -0
index c6d3ee472d81..742bc665602e 100644
@@ -679,6 +679,7 @@ config VIDEO_THP7312
 	tristate "THine THP7312 support"
 	depends on I2C
 	select FW_LOADER
+	select FW_UPLOAD
 	select MEDIA_CONTROLLER
 	select V4L2_CCI_I2C
 	select V4L2_FWNODE
Signature · 1 line
2.34.1