Skip to contentSkip to conversation

btrfs: Fix typo in error message

PATCH In review Mark Harmstone 3 participants 3 messages Jun 20, 2024 – Jun 26, 2024 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: Fix typo in error message

---
 fs/btrfs/disk-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/disk-io.c +1 -1
index d0882536b923..9b1ac0e2cdf3 100644
@@ -2467,7 +2467,7 @@ int btrfs_validate_super(struct btrfs_fs_info *fs_info,
 	    (!btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID) ||
 	     !btrfs_fs_incompat(fs_info, NO_HOLES))) {
 		btrfs_err(fs_info,
-		"block-group-tree feature requires fres-space-tree and no-holes");
+		"block-group-tree feature requires free-space-tree and no-holes");
 		ret = -EINVAL;
 	}
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 2 lines · Mark Harmstone

Please provide a change log, no matter how trivial a patch is, it should always have one.
Something like for example:

"There's a typo in an error message when checking the block group tree feature, it mentions fres-space-tree instead of free-space-tree. Fix that."

Also, in the subject don't capitalize the first word, it's the style we follow for all commit subjects.
Could also make the subject less generic like:

btrfs: fix typo in error message when validating the block-group-tree feature

Thanks.

Quoted 21 lines
---
 fs/btrfs/disk-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/disk-io.c +1 -2
index d0882536b923..9b1ac0e2cdf3 100644
@@ -2467,7 +2467,7 @@ int btrfs_validate_super(struct btrfs_fs_info *fs_info,
            (!btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID) ||
             !btrfs_fs_incompat(fs_info, NO_HOLES))) {
                btrfs_err(fs_info,
-               "block-group-tree feature requires fres-space-tree and no-holes");
+               "block-group-tree feature requires free-space-tree and no-holes");
                ret = -EINVAL;
        }
 
--

2.43.0