Skip to contentSkip to conversation

tpm_tis_spi: add missing attpm20p SPI device ID entry

PATCH In review Vitor Soares 4 participants 6 messages Jun 21, 2024 – Jul 1, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm_tis_spi: add missing attpm20p SPI device ID entry

From: Vitor Soares <[email protected]>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

"SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Based on:
commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
---
 drivers/char/tpm/tpm_tis_spi_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_tis_spi_main.c +1 -0
index c9eca24bbad4..61b42c83ced8 100644
@@ -318,6 +318,7 @@ static void tpm_tis_spi_remove(struct spi_device *dev)
 }
 
 static const struct spi_device_id tpm_tis_spi_id[] = {
+	{ "attpm20p", (unsigned long)tpm_tis_spi_probe },
 	{ "st33htpm-spi", (unsigned long)tpm_tis_spi_probe },
 	{ "slb9670", (unsigned long)tpm_tis_spi_probe },
 	{ "tpm_tis_spi", (unsigned long)tpm_tis_spi_probe },
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

[removing [email protected] from cc -- they're only interested in your patch once it's in Linus' tree]

Quoted 4 lines · Vitor Soares

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

"SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

[...]

Quoted 5 lines

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")

The old problem that spi modules aren't auto-loaded based on MODULE_DEVICE_TABLE(of, ...), but only on MODULE_DEVICE_TABLE(spi, ...):

https://lore.kernel.org/all/[email protected]/

Completely forgot that this is still a problem after all these years. :(

Thanks,

Lukas

maintainer
#2 lore raw
In reply to Vitor Soares
Quoted 7 lines · Vitor Soares

From: Vitor Soares <[email protected]>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

  "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Quoted 8 lines

Based on:
  commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")

This is not a bug fix. This is a feature.

BR, Jarkko

#3 lore raw
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Vitor Soares

From: Vitor Soares <[email protected]>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

  "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Based on:
  commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Quoted 7 lines
Quoted 5 lines

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")

This is not a bug fix. This is a feature.

I believe that some maintainer have a different view on this kind of patches compared to you, adding new device id would be material for stable, or this specific issue preventing module auto loading.

I noticed that this specific view is not new from you, see
https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.

With that said, I am ok with it.

Do you want a new patch version without Fixes/Cc:stable tags or you can remove those while applying?

Francesco

maintainer Reviewed-by
#4 lore raw
Quoted 27 lines · Francesco Dolcini
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Vitor Soares

From: Vitor Soares <[email protected]>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

  "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Based on:
  commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Quoted 7 lines
Quoted 5 lines

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")

This is not a bug fix. This is a feature.

I believe that some maintainer have a different view on this kind of patches compared to you, adding new device id would be material for stable, or this specific issue preventing module auto loading.

I noticed that this specific view is not new from you, see
https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.

Quoted 6 lines

With that said, I am ok with it.

Do you want a new patch version without Fixes/Cc:stable tags or you can remove those while applying?

Francesco

Hmm... OK, I'll apply this version, I see your point here!

BR, Jarkko

maintainer
#5 lore raw
Quoted 30 lines · Jarkko Sakkinen
Quoted 29 lines · Francesco Dolcini
Quoted 11 lines · Jarkko Sakkinen
Quoted 10 lines · Vitor Soares

From: Vitor Soares <[email protected]>

"atmel,attpm20p" DT compatible is missing its SPI device ID entry, not allowing module autoloading and leading to the following message:

  "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"

Based on:
  commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")

Quoted 7 lines
Quoted 5 lines

Fix this by adding the corresponding "attpm20p" spi_device_id entry.

Fixes 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")

This is not a bug fix. This is a feature.

I believe that some maintainer have a different view on this kind of patches compared to you, adding new device id would be material for stable, or this specific issue preventing module auto loading.

I noticed that this specific view is not new from you, see
https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.

With that said, I am ok with it.

Quoted 8 lines
Quoted 4 lines

Do you want a new patch version without Fixes/Cc:stable tags or you can remove those while applying?

Francesco

Hmm... OK, I'll apply this version, I see your point here!

Should be soon available in -next.

BR, Jarkko