Skip to contentSkip to conversation

dt-bindings: nvmem: sfp: add child node unique-id

PATCH In review Frank Li 2 participants 2 messages Jun 21, 2024 – Jun 22, 2024

Subsystems (3)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: nvmem: sfp: add child node unique-id

Add child node unique-id to fix below CHECK_DTBS warning. efuse@1e80000: Unevaluated properties are not allowed ('unique-id@1c' was unexpected)

---
 .../bindings/nvmem/fsl,layerscape-sfp.yaml      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml +17 -0
index 70fb2ad251037..8c0bdaab711a7 100644
@@ -42,6 +42,23 @@ properties:
       The regulator for the TA_PROG_SFP pin. It will be enabled for programming
       and disabled for reading.
 
+patternProperties:
+  '^unique-id@[0-9a-f]*$':
+    type: object
+    description:
+      Chip unique id.
+
+    properties:
+      reg:
+        description:
+          Byte offset where the unique id is stored
+        maxItems: 1
+
+    required:
+      - reg
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Frank Li

Add child node unique-id to fix below CHECK_DTBS warning. efuse@1e80000: Unevaluated properties are not allowed ('unique-id@1c' was unexpected)

That's not sufficient justification. Why is this even needed? What can't it be determined from a compatible etc? Just because it slipped into a dts doesn't mean you get to avoid the usual requirements for justifying new properties.

Thanks,
Conor.

Quoted 37 lines
---
 .../bindings/nvmem/fsl,layerscape-sfp.yaml      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml +17 -0
index 70fb2ad251037..8c0bdaab711a7 100644
@@ -42,6 +42,23 @@ properties:
       The regulator for the TA_PROG_SFP pin. It will be enabled for programming
       and disabled for reading.
 
+patternProperties:
+  '^unique-id@[0-9a-f]*$':
+    type: object
+    description:
+      Chip unique id.
+
+    properties:
+      reg:
+        description:
+          Byte offset where the unique id is stored
+        maxItems: 1
+
+    required:
+      - reg
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
Signature · 1 line
2.34.1