cpupower: Add 'help' target to all the makefiles that don't have it
cover cpupower: Add 'help' target to all the makefiles that don't have it
This patch series adds the 'help' target describing all the user-available targets to the makefiles which haven't had that target yet.
---
Roman Storozhenko (4):
cpupower: Add 'help' target to the 'bench' subproject makefile
cpupower: Add 'help' target to the 'debug/kernel' subproject makefile
cpupower: Add 'help' target to the 'debug/x86_64' subproject makefile
cpupower: Add 'help' target to the 'debug/i386' subproject makefile
tools/power/cpupower/bench/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/i386/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/kernel/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/x86_64/Makefile | 12 ++++++++++++ 4 files changed, 48 insertions(+)
---
base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7
change-id: 20240623-make_help_rest-e799889f43a1
Best regards,
Signature · 1 line
Roman Storozhenko <[email protected]>
PATCH 1/4 cpupower: Add 'help' target to the 'bench' subproject makefile
Add 'help' target, describing all user-available targets, to the 'bench' subproject makefile.
--- tools/power/cpupower/bench/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)
tools/power/cpupower/bench/Makefile +12 -0
@@ -41,3 +41,15 @@ install: $(OUTPUT)cpufreq-bench clean: rm -f $(OUTPUT)*.o rm -f $(OUTPUT)cpufreq-bench + +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts' + @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)'
Signature · 1 line
2.34.1
Shuah Khan
maintainerRe: [PATCH 1/4] cpupower: Add 'help' target to the 'bench' subproject makefile
Quoted 19 lines · Roman Storozhenko
Add 'help' target, describing all user-available targets, to the 'bench' subproject makefile.
Signed-off-by Roman Storozhenko <[email protected]>--- tools/power/cpupower/bench/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)tools/power/cpupower/bench/Makefile +2
-0@@ -41,3 +41,15 @@ install: $(OUTPUT)cpufreq-bench clean: rm -f $(OUTPUT)*.o rm -f $(OUTPUT)cpufreq-bench + +help:
tools/power/cpupower/bench/Makefile install: $(OUTPUT)cpufreq-bench · line 55
Quoted 10 lines
tools/power/cpupower/bench/Makefile +10
-0+ @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts' + @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)'
Is this help message necessary if bench can't be built standalone?
cpupower: Disable direct build of the 'bench' subproject
https://patchwork.kernel.org/project/linux-pm/patch/[email protected]/
thanks,
-- Shuah
PATCH 2/4 cpupower: Add 'help' target to the 'debug/kernel' subproject makefile
In reply to Roman StorozhenkoAdd 'help' target, describing all user-available targets, to the 'debug/kernel' subproject makefile.
--- tools/power/cpupower/debug/kernel/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)
tools/power/cpupower/debug/kernel/Makefile +12 -0
@@ -21,3 +21,15 @@ install: default /sbin/depmod -a all: default + +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Builds "cpufreq-test_tsc"' + @echo ' kernel module against the running kernel if the "CONFIG_X86_TSC"' + @echo ' kernel config parameter is enabled. Puts the built module' + @echo ' to the current dir' + @echo ' install - Install previously built "cpufreq-test_tsc.ko" module' + @echo ' to the running kernel "modules" dir' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean "cpufreq-test_tsc" module build artifacts'
Signature · 1 line
2.34.1
Shuah Khan
maintainerRe: [PATCH 2/4] cpupower: Add 'help' target to the 'debug/kernel' subproject makefile
Quoted 19 lines · Roman Storozhenko
Add 'help' target, describing all user-available targets, to the 'debug/kernel' subproject makefile.
Signed-off-by Roman Storozhenko <[email protected]>--- tools/power/cpupower/debug/kernel/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)tools/power/cpupower/debug/kernel/Makefile +2
-0@@ -21,3 +21,15 @@ install: default /sbin/depmod -a all: default + +help:
tools/power/cpupower/debug/kernel/Makefile install: default · line 35
Quoted 10 lines
tools/power/cpupower/debug/kernel/Makefile +10
-0+ @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Builds "cpufreq-test_tsc"' + @echo ' kernel module against the running kernel if the "CONFIG_X86_TSC"' + @echo ' kernel config parameter is enabled. Puts the built module' + @echo ' to the current dir' + @echo ' install - Install previously built "cpufreq-test_tsc.ko" module' + @echo ' to the running kernel "modules" dir' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean "cpufreq-test_tsc" module build artifacts'
I don't see a value in adding this - these are common targets and nothing new about them.
thanks,
-- Shuah
PATCH 3/4 cpupower: Add 'help' target to the 'debug/x86_64' subproject makefile
In reply to Roman StorozhenkoAdd 'help' target, describing all user-available targets, to the 'debug/x86_64' subproject makefile.
--- tools/power/cpupower/debug/x86_64/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)
tools/power/cpupower/debug/x86_64/Makefile +12 -0
@@ -28,4 +28,16 @@ install: $(INSTALL) $(OUTPUT)centrino-decode $(DESTDIR)${bindir} $(INSTALL) $(OUTPUT)powernow-k8-decode $(DESTDIR)${bindir} +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts' + @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)' + .PHONY: all default clean install
Signature · 1 line
2.34.1
Shuah Khan
maintainerRe: [PATCH 3/4] cpupower: Add 'help' target to the 'debug/x86_64' subproject makefile
Quoted 20 lines · Roman Storozhenko
Add 'help' target, describing all user-available targets, to the 'debug/x86_64' subproject makefile.
Signed-off-by Roman Storozhenko <[email protected]>--- tools/power/cpupower/debug/x86_64/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)tools/power/cpupower/debug/x86_64/Makefile +3
-0@@ -28,4 +28,16 @@ install: $(INSTALL) $(OUTPUT)centrino-decode $(DESTDIR)${bindir} $(INSTALL) $(OUTPUT)powernow-k8-decode $(DESTDIR)${bindir} +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts'
tools/power/cpupower/debug/x86_64/Makefile install: · line 43
Quoted 10 lines
tools/power/cpupower/debug/x86_64/Makefile +9
-0+ @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)' + .PHONY: all default clean install
I don't see a value in adding this - these are common targets and nothing new about them.
thanks,
-- Shuah
PATCH 4/4 cpupower: Add 'help' target to the 'debug/i386' subproject makefile
In reply to Roman StorozhenkoAdd 'help' target, describing all user-available targets, to the 'debug/i386' subproject makefile.
--- tools/power/cpupower/debug/i386/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)
tools/power/cpupower/debug/i386/Makefile +12 -0
@@ -39,4 +39,16 @@ install: $(INSTALL) $(OUTPUT)dump_psb $(DESTDIR)${bindir} $(INSTALL) $(OUTPUT)intel_gsic $(DESTDIR)${bindir} +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts' + @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)' + .PHONY: all default clean install
Signature · 1 line
2.34.1
Shuah Khan
maintainerRe: [PATCH 4/4] cpupower: Add 'help' target to the 'debug/i386' subproject makefile
Quoted 20 lines · Roman Storozhenko
Add 'help' target, describing all user-available targets, to the 'debug/i386' subproject makefile.
Signed-off-by Roman Storozhenko <[email protected]>--- tools/power/cpupower/debug/i386/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+)tools/power/cpupower/debug/i386/Makefile +3
-0@@ -39,4 +39,16 @@ install: $(INSTALL) $(OUTPUT)dump_psb $(DESTDIR)${bindir} $(INSTALL) $(OUTPUT)intel_gsic $(DESTDIR)${bindir} +help: + @echo 'Build targets:' + @echo ' all - Default target. Could be omitted. Put build artifacts'
tools/power/cpupower/debug/i386/Makefile install: · line 54
Quoted 10 lines
tools/power/cpupower/debug/i386/Makefile +9
-0+ @echo ' to "O" cmdline option dir (default: current dir)' + @echo ' install - Install previously built project files from the output' + @echo ' dir defined by "O" cmdline option (default: current dir)' + @echo ' to the install dir defined by "DESTDIR" cmdline' + @echo '' + @echo 'Clean targets:' + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' + @echo ' option (default: current dir)' + .PHONY: all default clean install
I don't see a value in adding this - these are common targets and nothing new about them.
thanks,
-- Shuah
Shuah Khan
maintainerQuoted 16 lines · Roman Storozhenko
This patch series adds the 'help' target describing all the user-available targets to the makefiles which haven't had that target yet.
Signed-off-by Roman Storozhenko <[email protected]>---
Roman Storozhenko (4):
cpupower: Add 'help' target to the 'bench' subproject makefile
cpupower: Add 'help' target to the 'debug/kernel' subproject makefile
cpupower: Add 'help' target to the 'debug/x86_64' subproject makefile
cpupower: Add 'help' target to the 'debug/i386' subproject makefiletools/power/cpupower/bench/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/i386/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/kernel/Makefile | 12 ++++++++++++ tools/power/cpupower/debug/x86_64/Makefile | 12 ++++++++++++ 4 files changed, 48 insertions(+)
Quoted 5 lines
---
base-commit:f76698bd9a8ca01d3581236082d786e9a6b72bb7
change-id: 20240623-make_help_rest-e799889f43a1Best regards,
Sorry. I don't see value in adding help messages for common make targets
thanks,
-- Shuah