arm64: dts: rockchip: add SFC support for Radxa ROCK 5B
Subsystems (2)
PATCH 1/3 arm64: dts: rockchip: add SFC support for Radxa ROCK 5B
This commit adds support for SPI NOR flash on Radxa ROCK 5B.
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
--- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +14 -0
@@ -449,6 +449,20 @@ &sdio { status = "okay"; }; +&sfc { + pinctrl-names = "default"; + pinctrl-0 = <&fspim2_pins>; + status = "okay"; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <104000000>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <1>; + }; +}; + &uart6 { pinctrl-names = "default"; pinctrl-0 = <&uart6m1_xfer &uart6m1_ctsn &uart6m1_rtsn>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 2/3 arm64: dts: rockchip: add (but disabled) SFC node for Radxa ROCK 5A
This commit adds SFC node for Radxa ROCK 5A.
since sdhci and sfc on RK3588s share pins(i.e. exclusive), it cannot be enabled both nodes at the same time. so status = "okay" is omitted here.
you may be able to enable sfc (and disable sdhci) by fdt overlay.
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +13 -0
@@ -377,6 +377,19 @@ &sdmmc { status = "okay"; }; +&sfc { + pinctrl-names = "default"; + pinctrl-0 = <&fspim0_pins>; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <104000000>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <1>; + }; +}; + &spi2 { status = "okay"; assigned-clocks = <&cru CLK_SPI2>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 3/3 arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
In reply to FUKAUMI NaokiSPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -1
@@ -633,7 +633,7 @@ &sfc { flash@0 { compatible = "jedec,spi-nor"; reg = <0x0>; - spi-max-frequency = <120000000>; + spi-max-frequency = <104000000>; spi-rx-bus-width = <4>; spi-tx-bus-width = <1>; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
Hi,
Quoted 1 line
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
I don't think a fixes tag is needed, because there is no documentation for this. See also (sfc part):
https://lore.kernel.org/lkml/[email protected]/
Quoted 3 lines
Fixes ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")Signed-off-by FUKAUMI Naoki <[email protected]>
Thanks,
Chukun
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
Hi,
Thank you very much for your comment!
Quoted 6 lines · Chukun Pan
Hi,
Quoted 1 line
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
I don't think a fixes tag is needed, because there is no documentation for this. See also (sfc part):
https://lore.kernel.org/lkml/[email protected]/
I see, I'll remove fixes tag in v2.
btw, is this change reasonable(acceptable)?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 7 lines
Quoted 3 lines
Fixes ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")Signed-off-by FUKAUMI Naoki <[email protected]>Thanks,
Chukun
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
Hi,
Quoted 2 lines
I see, I'll remove fixes tag in v2.
btw, is this change reasonable(acceptable)?
I think there's no problem and it's acceptable. It would be better if you could give examples of flash chips that might be used.
Thanks,
Chukun
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
Hi,
Quoted 6 lines · Chukun Pan
Hi,
Quoted 2 lines
I see, I'll remove fixes tag in v2.
btw, is this change reasonable(acceptable)?I think there's no problem and it's acceptable. It would be better if you could give examples of flash chips that might be used.
here is a list of my board:
ROCK 5A: MXIC (SPI flash module, no schematic)
ROCK 5B: MXIC (XTX in schematic)
ROCK 3A: MXIC (Winbond in schematic)
ROCK 3B: MXIC (Winbond in schematic)
ROCK 3C: GigaDevice (same as schematic)
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Thanks,
Chukun
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerRe: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
In reply to FUKAUMI NaokiAm Sonntag, 23. Juni 2024, 06:24:56 CEST schrieb FUKAUMI Naoki:
Quoted 6 lines
Hi,
Thank you very much for your comment!
Quoted 1 line · Chukun Pan
Hi,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
I don't think a fixes tag is needed, because there is no documentation for this. See also (sfc part):
https://lore.kernel.org/lkml/[email protected]/I see, I'll remove fixes tag in v2.
btw, is this change reasonable(acceptable)?
it is, also no need to resend, I just dropped the Fixes tag myself
Quoted 5 lines · FUKAUMI Naoki
This commit adds support for SPI NOR flash on Radxa ROCK 5B.
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
Applied, thanks!
[1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B
commit: 9204a7ecca96403ee3d61c14cb9eb87ec89b0fcd
[2/3] arm64: dts: rockchip: add (but disabled) SFC node for Radxa ROCK 5A
commit: 00224650dd45e166ea6eb1593f5f064583963ccf
[3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
commit: 06f6dd4d607766a527e37529f2f3f90dd1464293Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>