Skip to contentSkip to conversation

iommu/vt-d: Remove comment for def_domain_type

PATCH In review Lu Baolu 2 participants 2 messages Jun 24, 2024 – Jun 25, 2024

Subsystems (2)
lore
Share & tools
lore

Lu Baolu

author maintainer
#0 lore raw

PATCH 1/1 iommu/vt-d: Remove comment for def_domain_type

The comment for def_domain_type is outdated. Part of it is irrelevant. Furthermore, it could just be deleted since the iommu_ops::def_domain_type callback is properly documented in iommu.h, so individual implementations shouldn't need to repeat that. Remove it to avoid confusion.

---
 drivers/iommu/intel/iommu.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/iommu/intel/iommu.c +0 -11
index ccde5f5972e4..640081933aed 100644
@@ -2177,17 +2177,6 @@ static bool device_rmrr_is_relaxable(struct device *dev)
 		return false;
 }
 
-/*
- * Return the required default domain type for a specific device.
- *
- * @dev: the device in query
- * @startup: true if this is during early boot
- *
- * Returns:
- *  - IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain
- *  - IOMMU_DOMAIN_IDENTITY: device requires an identical mapping domain
- *  - 0: both identity and dynamic domains work for this device
- */
 static int device_def_domain_type(struct device *dev)
 {
 	if (dev_is_pci(dev)) {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines

From: Lu Baolu <[email protected]>
Sent: Monday, June 24, 2024 10:43 AM

The comment for def_domain_type is outdated. Part of it is irrelevant. Furthermore, it could just be deleted since the iommu_ops::def_domain_type
callback is properly documented in iommu.h, so individual implementations shouldn't need to repeat that. Remove it to avoid confusion.