Skip to contentSkip to conversation

.travis.yml: Install python3-tomli in all build jobs

PATCH In review Thomas Huth 3 participants 4 messages Jun 24, 2024 – Aug 20, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 .travis.yml: Install python3-tomli in all build jobs

Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too.

---
 .travis.yml | 6 ++++++
 1 file changed, 6 insertions(+)
.travis.yml +6 -0
index cef0308952..8fc1ae0cf2 100644
@@ -106,6 +106,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -141,6 +142,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -175,6 +177,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -215,6 +218,7 @@ jobs:
           - libzstd-dev
           - nettle-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -231,6 +235,7 @@ jobs:
           - ninja-build
           - flex
           - bison
+          - python3-tomli
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --disable-system"
@@ -263,6 +268,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
       env:
         - TEST_CMD="make check-unit"
         - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools
Signature · 1 line
2.45.2
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Thomas Huth

Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too.

AFAICT the only repo currently running these tests is your github mirror:

https://app.travis-ci.com/github/huth/qemu/builds?serverType=git

Because both the official github mirror and the gitlab project haven't run anything for a while:

https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
https://app.travis-ci.com/github/qemu/qemu/branches

I've never been able to get anything to build since they transitioned to TravisCI.com

Quoted 51 lines
---
 .travis.yml | 6 ++++++
 1 file changed, 6 insertions(+)
.travis.yml +5 -0
index cef0308952..8fc1ae0cf2 100644
@@ -106,6 +106,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -141,6 +142,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -175,6 +177,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -215,6 +218,7 @@ jobs:
           - libzstd-dev
           - nettle-dev
           - ninja-build
+          - python3-tomli
           # Tests dependencies
           - genisoimage
       env:
@@ -231,6 +235,7 @@ jobs:
           - ninja-build
           - flex
           - bison
+          - python3-tomli
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --disable-system"

.travis.yml jobs: · line 274

Quoted 7 lines
.travis.yml +1 -0
@@ -263,6 +268,7 @@ jobs:
           - libvdeplug-dev
           - libvte-2.91-dev
           - ninja-build
+          - python3-tomli
       env:
         - TEST_CMD="make check-unit"
         - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools

FWIW the changes themselves look fine:

Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro
#2 lore raw
Quoted 9 lines · Alex Bennée
Quoted 3 lines · Thomas Huth

Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too.

AFAICT the only repo currently running these tests is your github mirror:

Quoted 7 lines

https://app.travis-ci.com/github/huth/qemu/builds?serverType=git

Because both the official github mirror and the gitlab project haven't run anything for a while:

https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
https://app.travis-ci.com/github/qemu/qemu/branches

AFAIK the gitlab integration broke completely at one point in time. But as you can see with my account, it still works fine for the github repo - I just need to write a short mail to the travis support once a year to ask them to extend the open source credits for my repo. So apart from that minor effort, it's a very convenient way to test QEMU on non-x86 hosts.

Quoted 3 lines

FWIW the changes themselves look fine:

Thanks!

Thomas

#3 lore raw

Am 24.06.24 um 12:31 schrieb Thomas Huth:

Quoted 15 lines · Alex Bennée
Quoted 14 lines
Quoted 3 lines · Thomas Huth

Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too.

AFAICT the only repo currently running these tests is your github mirror:

   https://app.travis-ci.com/github/huth/qemu/builds?serverType=git

Because both the official github mirror and the gitlab project haven't run anything for a while:

Quoted 6 lines
Quoted 2 lines

   https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
   https://app.travis-ci.com/github/qemu/qemu/branches

AFAIK the gitlab integration broke completely at one point in time. But as you can see with my account, it still works fine for the github repo
- I just need to write a short mail to the travis support once a year to
ask them to extend the open source credits for my repo. So apart from that minor effort, it's a very convenient way to test QEMU on non-x86 hosts.

https://app.travis-ci.com/github/qemu/qemu/requests shows recent requests. But all requests are refused: "Owner qemu is not on a new pricing". So whoever is "qemu", he/she might do the same as you did and write to the Travis support.

And https://travis-ci.org/qemu/qemu could be replaced by https://app.travis-ci.com/github/qemu/qemu in MAINTAINERS.

Stefan