Skip to contentSkip to conversation

fbdev: Drop explicit initialization of struct i2c_device_id::driver_data to 0

PATCH Applied Uwe Kleine-König 2 participants 2 messages Jun 24, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: Drop explicit initialization of struct i2c_device_id::driver_data to 0

From: Uwe Kleine-König <[email protected]>

These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own.

---
 drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
 drivers/video/fbdev/ssd1307fb.c             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/video/fbdev/matrox/matroxfb_maven.c +1 -1
index b15a8ad92ba7..dcfae770b42d 100644
@@ -1282,7 +1282,7 @@ static void maven_remove(struct i2c_client *client)
 }
 
 static const struct i2c_device_id maven_id[] = {
-	{ "maven", 0 },
+	{ "maven" },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, maven_id);
drivers/video/fbdev/ssd1307fb.c +4 -4
index 3f30af3c059e..aa6cc0a8151a 100644
@@ -782,10 +782,10 @@ static void ssd1307fb_remove(struct i2c_client *client)
 }
 
 static const struct i2c_device_id ssd1307fb_i2c_id[] = {
-	{ "ssd1305fb", 0 },
-	{ "ssd1306fb", 0 },
-	{ "ssd1307fb", 0 },
-	{ "ssd1309fb", 0 },
+	{ "ssd1305fb" },
+	{ "ssd1306fb" },
+	{ "ssd1307fb" },
+	{ "ssd1309fb" },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);

base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7

Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 9 lines · Uwe Kleine-König

From: Uwe Kleine-König <[email protected]>

These drivers don't use the driver_data member of struct i2c_device_id, so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires either no initialization or named designators. But it's also a nice cleanup on its own.

Quoted 5 lines
---
  drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
  drivers/video/fbdev/ssd1307fb.c             | 8 ++++----
  2 files changed, 5 insertions(+), 5 deletions(-)

applied.

Thanks!
Helge