drm/panel: synaptics-r63353: Fix regulator unbalance
Michael Trimarchi
maintainerRFC PATCH 1/1 drm/panel: synaptics-r63353: Fix regulator unbalance
The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the drm_panel_unprepare, allow us to avoid to trigger the kernel warning
---
It's not obviovus if shutdown can be dropped or this problem depends on the display stack as it is implmented. More feedback is required here
--- drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-synaptics-r63353.c +1 -1
@@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi) {struct r63353_panel *rpanel =mipi_dsi_get_drvdata (dsi); -r63353_panel_unprepare (&rpanel->base); +drm_panel_unprepare (&rpanel->base); }static const struct r63353_desc sharp_ls068b3sx02_data = {
Signature · 1 line
2.43.0
Michael Nazzareno Trimarchi
maintainerHi Doug
+cc Doug
I have seen that you have done some re-working and investigation on drm stack, do you have some
suggestion on this case?
Quoted 33 lines · Michael Trimarchi
The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the
drm_panel_unprepare, allow us to avoid to trigger the kernel warningSigned-off-by Michael Trimarchi <[email protected]>---
It's not obviovus if shutdown can be dropped or this problem depends on the display stack as it is implmented. More feedback is required here
--- drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/panel/panel-synaptics-r63353.c +1
-2@@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi) {struct r63353_panel *rpanel =mipi_dsi_get_drvdata (dsi); -r63353_panel_unprepare (&rpanel->base); +drm_panel_unprepare (&rpanel->base); }static const struct r63353_desc sharp_ls068b3sx02_data = { --2.43.0
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com
Hi,
Quoted 23 lines · Michael Nazzareno Trimarchi
Hi Doug
+cc Doug
I have seen that you have done some re-working and investigation on drm stack, do you have some
suggestion on this case?Quoted 12 lines · Michael Trimarchi
The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the
drm_panel_unprepare, allow us to avoid to trigger the kernel warningSigned-off-by Michael Trimarchi <[email protected]>---
It's not obviovus if shutdown can be dropped or this problem depends on the display stack as it is implmented. More feedback is required here
In general the shutdown should be dropped and it should be up to the display driver to do the shutdown. If your panel needs to be used with a DRM Modeset driver that doesn't properly call shutdown then the ideal solution would be to fix the DRM Modeset driver. If this is somehow impossible, I suspect folks would (begrudgingly) accept some other solution.
From a super quick look, I see:
* This panel seems to be used upstream by "imx8mn-bsh-smm-s2-display.dtsi"
* In "imx8mn.dtsi" I see "lcdif" is "fsl,imx6sx-lcdif".
* "fsl,imx6sx-lcdif" seems to be handled by "drivers/gpu/drm/mxsfb/mxsfb_drv.c"
* Previously I determined that "mxsfb-drm" was indeed calling drm_atomic_helper_shutdown() properly [1]
...so it seems like just dropping the shutdown handler in this panel is correct.
[1] https://lore.kernel.org/r/20240611074846.1.Ieb287c2c3ee3f6d3b0d5f49b29f746b93621749c@changeid
-Doug
Michael Nazzareno Trimarchi
maintainerHi Doug
Quoted 44 lines · Doug Anderson
Hi,
Quoted 23 lines · Michael Nazzareno Trimarchi
Hi Doug
+cc Doug
I have seen that you have done some re-working and investigation on drm stack, do you have some
suggestion on this case?Quoted 12 lines · Michael Trimarchi
The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the
drm_panel_unprepare, allow us to avoid to trigger the kernel warningSigned-off-by Michael Trimarchi <[email protected]>---
It's not obviovus if shutdown can be dropped or this problem depends on the display stack as it is implmented. More feedback is required here
In general the shutdown should be dropped and it should be up to the display driver to do the shutdown. If your panel needs to be used with a DRM Modeset driver that doesn't properly call shutdown then the ideal solution would be to fix the DRM Modeset driver. If this is somehow impossible, I suspect folks would (begrudgingly) accept some other solution.
From a super quick look, I see:
* This panel seems to be used upstream by "
imx8mn-bsh-smm-s2-display.dtsi"* In "
imx8mn.dtsi" I see "lcdif" is "fsl,imx6sx-lcdif".* "fsl,imx6sx-lcdif" seems to be handled by "
drivers/gpu/drm/mxsfb/mxsfb_drv.c"
Quoted 8 lines
* Previously I determined that "mxsfb-drm" was indeed calling
drm_atomic_helper_shutdown()properly [1]...so it seems like just dropping the shutdown handler in this panel is correct.
[1] https://lore.kernel.org/r/20240611074846.1.Ieb287c2c3ee3f6d3b0d5f49b29f746b93621749c@changeid
Good, that is the information I need to know, I have read some of your threads and it's ok for me to just drop it.
I will resend a proper patch for it
Michael
Quoted 1 line
-Doug
Signature · 11 lines
Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 [email protected] __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 [email protected] www.amarulasolutions.com