Skip to contentSkip to conversation

cpupower: Add 'uninstall' targers for arch-related debug subprojects

PATCH In review Roman Storozhenko 2 participants 4 messages Jun 25, 2024 – Jun 28, 2024 CPU power monitoring

lore
Share & tools
lore
#0 lore raw

cover cpupower: Add 'uninstall' targers for arch-related debug subprojects

This patch series adds 'uninstall' targets to the makefiles of 'debug/i386' and 'debug/x86_64' architecture-specifics debug subprojects

---
Roman Storozhenko (2):
cpupower: Add 'uninstall' target for 'debug/i386' subproject
cpupower: Add 'uninstall' target for 'debug/x86_64' subproject

 tools/power/cpupower/debug/i386/Makefile   | 8 +++++++-
 tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

---
base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
change-id: 20240625-add_uninstall-14246eeec69a

Best regards,

Signature · 1 line
Roman Storozhenko <[email protected]>
#1 lore raw

PATCH 1/2 cpupower: Add 'uninstall' target for 'debug/i386' subproject

Add 'uninstall' target for the 'debug/i386' subproject. The target removes binaries previously installed to the '${DESTDIR}${bindir}' dir.

---
 tools/power/cpupower/debug/i386/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
tools/power/cpupower/debug/i386/Makefile +7 -1
index b3f771039b17..355f44dafa00 100644
@@ -39,4 +39,10 @@ install:
 	$(INSTALL) $(OUTPUT)dump_psb $(DESTDIR)${bindir}
 	$(INSTALL) $(OUTPUT)intel_gsic $(DESTDIR)${bindir}
 
-.PHONY: all default clean install
+uninstall:
+	- rm -f $(DESTDIR)${bindir}/centrino-decode
+	- rm -f $(DESTDIR)${bindir}/powernow-k8-decode
+	- rm -f $(DESTDIR)${bindir}/dump_psb
+	- rm -f $(DESTDIR)${bindir}/intel_gsic
+
+.PHONY: all default clean install uninstall
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 cpupower: Add 'uninstall' target for 'debug/x86_64' subproject

In reply to Roman Storozhenko

Add 'uninstall' target for the 'debug/x86_64' subproject. The target removes binaries previously installed to the '${DESTDIR}${bindir}' dir.

---
 tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/power/cpupower/debug/x86_64/Makefile +5 -1
index b1b6c43644e7..37fd414835b8 100644
@@ -28,4 +28,8 @@ install:
 	$(INSTALL) $(OUTPUT)centrino-decode $(DESTDIR)${bindir}
 	$(INSTALL) $(OUTPUT)powernow-k8-decode $(DESTDIR)${bindir}
 
-.PHONY: all default clean install
+uninstall:
+	- rm -f $(DESTDIR)${bindir}/centrino-decode
+	- rm -f $(DESTDIR)${bindir}/powernow-k8-decode
+
+.PHONY: all default clean install uninstall
Signature · 1 line
2.34.1
maintainer
#3 lore raw
In reply to Roman Storozhenko
Quoted 9 lines · Roman Storozhenko

This patch series adds 'uninstall' targets to the makefiles of 'debug/i386' and 'debug/x86_64' architecture-specifics debug subprojects

---
Roman Storozhenko (2):
cpupower: Add 'uninstall' target for 'debug/i386' subproject
cpupower: Add 'uninstall' target for 'debug/x86_64' subproject

Quoted 8 lines
  tools/power/cpupower/debug/i386/Makefile   | 8 +++++++-
  tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
  2 files changed, 12 insertions(+), 2 deletions(-)

---
base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
change-id: 20240625-add_uninstall-14246eeec69a

Best regards,

I am inclined to not take these as these are special case debug tools and modules for developers.

thanks,
-- Shuah