Skip to contentSkip to conversation

mm-do-not-start-end-writeback-for-pages-stored-in-zswap.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jun 25, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: do not start/end writeback for pages stored in zswap
has been removed from the -mm tree. Its filename was
mm-do-not-start-end-writeback-for-pages-stored-in-zswap.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Usama Arif <[email protected]>
Subject: mm: do not start/end writeback for pages stored in zswap
Date: Mon, 10 Jun 2024 15:30:37 +0100

Most of the work done in folio_start_writeback is reversed in folio_end_writeback. For e.g. NR_WRITEBACK and NR_ZONE_WRITE_PENDING are incremented in start_writeback and decremented in end_writeback. Calling end_writeback immediately after start_writeback (separated by folio_unlock) cancels the affect of most of the work done in start hence can be removed.

There is some extra work done in folio_end_writeback, however it is incorrect/not applicable to zswap:
- folio_end_writeback incorrectly increments NR_WRITTEN counter, eventhough the pages aren't written to disk, hence this change corrects this behaviour.
- folio_end_writeback calls folio_rotate_reclaimable, but that only makes sense for async writeback pages, while for zswap pages are synchronously reclaimed.

---

 mm/page_io.c |    2 --
 1 file changed, 2 deletions(-)
mm/page_io.c renamed from mm/page_io.c~mm-do-not-start-end-writeback-for-pages-stored-in-zswap +0 -2
@@ -196,9 +196,7 @@ int swap_writepage(struct page *page, st
 		return ret;
 	}
 	if (zswap_store(folio)) {
-		folio_start_writeback(folio);
 		folio_unlock(folio);
-		folio_end_writeback(folio);
 		return 0;
 	}
 	if (!mem_cgroup_zswap_writeback_enabled(folio_memcg(folio))) {

_

Patches currently in -mm which might be from [email protected] are

mm-store-zero-pages-to-be-swapped-out-in-a-bitmap.patch mm-store-zero-pages-to-be-swapped-out-in-a-bitmap-v6.patch mm-remove-code-to-handle-same-filled-pages.patch