hw/sd/sdcard: Accumulation of cleanups and fixes
v2 cover hw/sd/sdcard: Accumulation of cleanups and fixes
Since v1:
- various patches merged, few more added
Various SD card cleanups and fixes accumulated over the years. Various have been useful to help integrating eMMC support (which will come later).
Philippe Mathieu-Daudé (12):
tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA hw/sd/sdcard: Generate random RCA value
hw/sd/sdcard: Track last command used to help logging hw/sd/sdcard: Trace block offset in READ/WRITE data accesses hw/sd/sdcard: Do not store vendor data on block drive (CMD56) hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30) hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22) hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value hw/sd/sdcard: Assign SDCardStates enum values hw/sd/sdcard: Simplify sd_inactive_state handling hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6) hw/sd/sdcard: Add direct reference to SDProto in SDState
hw/sd/sd.c | 119 ++++++++++++++++--------------- tests/qtest/npcm7xx_sdhci-test.c | 7 ++ hw/sd/trace-events | 4 +- 3 files changed, 70 insertions(+), 60 deletions(-)
Signature · 1 line
2.41.0
PATCH v2 1/12 tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA
Disable tests using 0x4567 hardcoded RCA otherwise when using random RCA we get:
ERROR:../../tests/qtest/npcm7xx_sdhci-test.c:69:write_sdread: assertion failed: (ret == len)
not ok /arm/npcm7xx_sdhci/read_sd - ERROR:../../tests/qtest/npcm7xx_sdhci-test.c:69:write_sdread: assertion failed: (ret == len) Bail out!
See https://lore.kernel.org/qemu-devel/[email protected]/
---
Cc: Hao Wu <[email protected]>
Cc: Shengtan Mao <[email protected]>
Cc: Tyrone Ting <[email protected]>
--- tests/qtest/npcm7xx_sdhci-test.c | 7 +++++++ 1 file changed, 7 insertions(+)
tests/qtest/npcm7xx_sdhci-test.c +7 -0
@@ -44,6 +44,7 @@ static QTestState *setup_sd_card(void)sdhci_cmd_regs (qts,NPCM7XX_MMC_BA ,0 ,0 ,0x41200000 ,0 , (41 <<8 ));sdhci_cmd_regs (qts,NPCM7XX_MMC_BA ,0 ,0 ,0 ,0 ,SDHC_ALL_SEND_CID );sdhci_cmd_regs (qts,NPCM7XX_MMC_BA ,0 ,0 ,0 ,0 ,SDHC_SEND_RELATIVE_ADDR ); +g_test_skip ("hardcoded 0x4567 card address" );sdhci_cmd_regs (qts,NPCM7XX_MMC_BA ,0 ,0 ,0x45670000 ,0 ,SDHC_SELECT_DESELECT_CARD );
@@ -76,6 +77,9 @@ static void test_read_sd(void) {QTestState *qts =setup_sd_card (); +g_test_skip ("hardcoded 0x4567 card address used in setup_sd_card()" ); +return ; +write_sdread (qts,"hello world" );write_sdread (qts,"goodbye" );
@@ -108,6 +112,9 @@ static void test_write_sd(void) {QTestState *qts =setup_sd_card (); +g_test_skip ("hardcoded 0x4567 card address used in setup_sd_card()" ); +return ; +sdwrite_read (qts,"hello world" );sdwrite_read (qts,"goodbye" );
Signature · 1 line
2.41.0
PATCH v2 2/12 hw/sd/sdcard: Generate random RCA value
In reply to Philippe Mathieu-DaudéRather than using the obscure 0x4567 magic value,
use a real random one.
--- hw/sd/sd.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
hw/sd/sd.c +2 -6
@@ -46,6 +46,7 @@#include "qemu/error-report.h" #include "qemu/timer.h" #include "qemu/log.h" +#include "qemu/guest-random.h" #include "qemu/module.h" #include "sdmmc-internal.h" #include "trace.h"
@@ -490,11 +491,6 @@ static void sd_set_csd(SDState *sd, uint64_t size)/* Relative Card Address register */ -static void sd_set_rca (SDState *sd) -{ - sd->rca +=0x4567 ; -} -static uint16_t sd_req_get_rca (SDState *s,SDRequest req) {if (sd_cmd_type[req.cmd] == sd_ac || sd_cmd_type[req.cmd] == sd_adtc) {
@@ -1107,7 +1103,7 @@ static sd_rsp_type_t sd_cmd_SEND_RELATIVE_ADDR(SDState *sd, SDRequest req)case sd_identification_state:case sd_standby_state: sd->state = sd_standby_state; -sd_set_rca (sd); +qemu_guest_getrandom_nofail (&sd->rca,sizeof (sd->rca));return sd_r6;default :
Signature · 1 line
2.41.0
PATCH v2 3/12 hw/sd/sdcard: Track last command used to help logging
In reply to Philippe Mathieu-DaudéThe command is selected on the I/O lines, and further processing might be done on the DAT lines via the sd_read_byte() and sd_write_byte() handlers. Since these methods can't distinct between normal and APP commands, keep the name of the current command in the SDState and use it in the DAT handlers. This fixes a bug that all normal commands were displayed as APP commands.
--- hw/sd/sd.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
hw/sd/sd.c +8 -4
@@ -134,6 +134,7 @@ struct SDState {uint32_t pwd_len;uint8_t function_group[6 ];uint8_t current_cmd; +const char *last_cmd_name;/* True if we will handle the next command as an ACMD. Note that this does * *not* track the APP_CMD status bit! */
@@ -1150,12 +1151,13 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)uint16_t rca;uint64_t addr; + sd->last_cmd_name =sd_cmd_name (req.cmd);/* CMD55 precedes an ACMD, so we are not interested in tracing it. * However there is no ACMD55, so we want to trace this particular case. */ if (req.cmd !=55 || sd->expecting_acmd) {trace_sdcard_normal_command (sd_proto (sd)->name, -sd_cmd_name (req.cmd), req.cmd, + sd->last_cmd_name, req.cmd, req.arg,sd_state_name (sd->state)); }
@@ -1616,7 +1618,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)static sd_rsp_type_t sd_app_command (SDState *sd,SDRequest req) { -trace_sdcard_app_command (sd_proto (sd)->name,sd_acmd_name (req.cmd), + sd->last_cmd_name =sd_acmd_name (req.cmd); +trace_sdcard_app_command (sd_proto (sd)->name, sd->last_cmd_name, req.cmd, req.arg,sd_state_name (sd->state)); sd->card_status |=APP_CMD ;
@@ -1909,7 +1912,7 @@ void sd_write_byte(SDState *sd, uint8_t value)return ;trace_sdcard_write_data (sd_proto (sd)->name, -sd_acmd_name (sd->current_cmd), + sd->last_cmd_name, sd->current_cmd, value);switch (sd->current_cmd) {case 24 :/* CMD24: WRITE_SINGLE_BLOCK */
@@ -2065,7 +2068,7 @@ uint8_t sd_read_byte(SDState *sd) io_len = (sd->ocr & (1 <<30 )) ?512 : sd->blk_len;trace_sdcard_read_data (sd_proto (sd)->name, -sd_acmd_name (sd->current_cmd), + sd->last_cmd_name, sd->current_cmd, io_len);switch (sd->current_cmd) {case 6 :/* CMD6: SWITCH_FUNCTION */
@@ -2210,6 +2213,7 @@ static void sd_instance_init(Object *obj) {SDState *sd =SD_CARD (obj); + sd->last_cmd_name ="UNSET" ; sd->enable = true; sd->ocr_power_timer =timer_new_ns (QEMU_CLOCK_VIRTUAL , sd_ocr_powerup, sd); }
Signature · 1 line
2.41.0
PATCH v2 4/12 hw/sd/sdcard: Trace block offset in READ/WRITE data accesses
In reply to Philippe Mathieu-DaudéUseful to detect out of bound accesses.
--- hw/sd/sd.c | 4 ++-- hw/sd/trace-events | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
hw/sd/sd.c +2 -2
@@ -1913,7 +1913,7 @@ void sd_write_byte(SDState *sd, uint8_t value)trace_sdcard_write_data (sd_proto (sd)->name, sd->last_cmd_name, - sd->current_cmd, value); + sd->current_cmd, sd->data_offset, value);switch (sd->current_cmd) {case 24 :/* CMD24: WRITE_SINGLE_BLOCK */ sd->data[sd->data_offset ++] = value;
@@ -2069,7 +2069,7 @@ uint8_t sd_read_byte(SDState *sd)trace_sdcard_read_data (sd_proto (sd)->name, sd->last_cmd_name, - sd->current_cmd, io_len); + sd->current_cmd, sd->data_offset, io_len);switch (sd->current_cmd) {case 6 :/* CMD6: SWITCH_FUNCTION */ ret = sd->data[sd->data_offset ++];
hw/sd/trace-events +2 -2
@@ -52,8 +52,8 @@ sdcard_lock(void) "" sdcard_unlock(void) "" sdcard_read_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x" sdcard_write_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x" -sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint8_t value) "%s %20s/ CMD%02d value 0x%02x" -sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t length) "%s %20s/ CMD%02d len %" PRIu32 +sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t offset, uint8_t value) "%s %20s/ CMD%02d ofs %"PRIu32" value 0x%02x" +sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, uint32_t offset, uint32_t length) "%s %20s/ CMD%02d ofs %"PRIu32" len %" PRIu32 sdcard_set_voltage(uint16_t millivolts) "%u mV" # pxa2xx_mmci.c
Signature · 1 line
2.41.0
PATCH v2 5/12 hw/sd/sdcard: Do not store vendor data on block drive (CMD56)
In reply to Philippe Mathieu-Daudé"General command" (GEN_CMD, CMD56) is described as:
GEN_CMD is the same as the single block read or write commands (CMD24 or CMD17). The difference is that [...] the data block is not a memory payload data but has a vendor specific format and meaning.
Thus this block must not be stored overwriting data block on underlying storage drive. Keep it in a dedicated 'vendor_data[]' array.
---
RFC: Is it safe to reuse VMSTATE_UNUSED_V() (which happens to be the same size)?
--- hw/sd/sd.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
hw/sd/sd.c +9 -8
@@ -143,6 +143,8 @@ struct SDState {uint64_t data_start;uint32_t data_offset;uint8_t data[512 ]; +uint8_t vendor_data[512 ]; +qemu_irq readonly_cb;qemu_irq inserted_cb;QEMUTimer *ocr_power_timer;
@@ -647,6 +649,7 @@ static void sd_reset(DeviceState *dev) sd->wp_switch = sd->blk ? !blk_is_writable (sd->blk) : false; sd->wp_group_bits = sect; sd->wp_group_bmap =bitmap_new (sd->wp_group_bits); +memset (sd->vendor_data,0xec ,sizeof (sd->vendor_data));memset (sd->function_group,0 ,sizeof (sd->function_group)); sd->erase_start =INVALID_ADDRESS ; sd->erase_end =INVALID_ADDRESS ;
@@ -762,7 +765,7 @@ static const VMStateDescription sd_vmstate = {VMSTATE_UINT64 (data_start, SDState),VMSTATE_UINT32 (data_offset, SDState),VMSTATE_UINT8_ARRAY (data, SDState,512 ), -VMSTATE_UNUSED_V (1 ,512 ), +VMSTATE_UINT8_ARRAY (vendor_data, SDState,512 ),VMSTATE_BOOL (enable, SDState),VMSTATE_END_OF_LIST () },
@@ -2020,9 +2023,8 @@ void sd_write_byte(SDState *sd, uint8_t value)break ;case 56 :/* CMD56: GEN_CMD */ - sd->data[sd->data_offset ++] = value; -if (sd->data_offset >= sd->blk_len) { -APP_WRITE_BLOCK (sd->data_start, sd->data_offset); + sd->vendor_data[sd->data_offset ++] = value; +if (sd->data_offset >=sizeof (sd->vendor_data)) { sd->state = sd_transfer_state; }break ;
@@ -2156,12 +2158,11 @@ uint8_t sd_read_byte(SDState *sd)break ;case 56 :/* CMD56: GEN_CMD */ -if (sd->data_offset ==0 ) -APP_READ_BLOCK (sd->data_start, sd->blk_len); - ret = sd->data[sd->data_offset ++]; + ret = sd->vendor_data[sd->data_offset ++]; -if (sd->data_offset >= sd->blk_len) +if (sd->data_offset >=sizeof (sd->vendor_data)) { sd->state = sd_transfer_state; + }break ;default :
Signature · 1 line
2.41.0
PATCH v2 6/12 hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30)
In reply to Philippe Mathieu-DaudéPer sections 3.6.1 (SD Bus Protocol) and 7.3.2 (Responses):
In the CMD line the Most Significant Bit is transmitted first.
Use the stl_be_p() helper to store the value in big-endian.
---
RFC because I'm surprised this has been unnoticed for 17 years (commit a1bb27b1e9 "initial SD card emulation", April 2007).
--- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/sd/sd.c +1 -1
@@ -1498,7 +1498,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) } sd->state = sd_sendingdata_state; - *(uint32_t *) sd->data =sd_wpbits (sd, req.arg); +stl_be_p (sd->data,sd_wpbits (sd, req.arg)); sd->data_start = addr; sd->data_offset =0 ;return sd_r1;
Signature · 1 line
2.41.0
PATCH v2 7/12 hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22)
In reply to Philippe Mathieu-DaudéPer sections 3.6.1 (SD Bus Protocol), 4.3.4 "Data Write" and 7.3.2 (Responses):
In the CMD line the Most Significant Bit is transmitted first.
Use the stl_be_p() helper to store the value in big-endian.
---
RFC because I'm surprised this has been unnoticed for 17 years (commit a1bb27b1e9 "initial SD card emulation", April 2007).
--- hw/sd/sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
hw/sd/sd.c +1 -2
@@ -1659,8 +1659,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd,case 22 :/* ACMD22: SEND_NUM_WR_BLOCKS */ switch (sd->state) {case sd_transfer_state: - *(uint32_t *) sd->data = sd->blk_written; - +stl_be_p (sd->data, sd->blk_written); sd->state = sd_sendingdata_state; sd->data_start =0 ; sd->data_offset =0 ;
Signature · 1 line
2.41.0
PATCH v2 8/12 hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value
In reply to Philippe Mathieu-Daudé--- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/sd/sd.c +1 -1
@@ -557,7 +557,7 @@ FIELD(CSR, OUT_OF_RANGE, 31, 1)static void sd_set_cardstatus (SDState *sd) { - sd->card_status =0x00000100 ; + sd->card_status =READY_FOR_DATA ; }static void sd_set_sdstatus (SDState *sd)
Signature · 1 line
2.41.0
PATCH v2 9/12 hw/sd/sdcard: Assign SDCardStates enum values
In reply to Philippe Mathieu-DaudéSDCardStates enum values are specified, so assign them correspondingly. It will be useful later when we add states from later specs, which might not be continuous.
See CURRENT_STATE bits in section 4.10.1 "Card Status".
--- hw/sd/sd.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
hw/sd/sd.c +10 -10
@@ -76,16 +76,16 @@ enum SDCardModes { };enum SDCardStates { - sd_inactive_state =-1 , - sd_idle_state =0 , - sd_ready_state, - sd_identification_state, - sd_standby_state, - sd_transfer_state, - sd_sendingdata_state, - sd_receivingdata_state, - sd_programming_state, - sd_disconnect_state, + sd_inactive_state =-1 , + sd_idle_state =0 , + sd_ready_state =1 , + sd_identification_state =2 , + sd_standby_state =3 , + sd_transfer_state =4 , + sd_sendingdata_state =5 , + sd_receivingdata_state =6 , + sd_programming_state =7 , + sd_disconnect_state =8 , };typedef sd_rsp_type_t (*sd_cmd_handler )(SDState *sd,SDRequest req);
Signature · 1 line
2.41.0
PATCH v2 10/12 hw/sd/sdcard: Simplify sd_inactive_state handling
In reply to Philippe Mathieu-DaudéCard entering sd_inactive_state powers off, and won't respond anymore. Handle that once when entering sd_do_command().
Remove condition always true in sd_cmd_GO_IDLE_STATE().
--- hw/sd/sd.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
hw/sd/sd.c +7 -5
@@ -1072,10 +1072,8 @@ static sd_rsp_type_t sd_cmd_unimplemented(SDState *sd, SDRequest req)/* CMD0 */ static sd_rsp_type_t sd_cmd_GO_IDLE_STATE (SDState *sd,SDRequest req) { -if (sd->state != sd_inactive_state) { - sd->state = sd_idle_state; -sd_reset (DEVICE (sd)); - } + sd->state = sd_idle_state; +sd_reset (DEVICE (sd));return sd_is_spi (sd) ? sd_r1 : sd_r0; }
@@ -1570,7 +1568,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)switch (sd->state) {case sd_ready_state:case sd_identification_state: -case sd_inactive_state:return sd_illegal;case sd_idle_state:if (rca) {
@@ -1791,6 +1788,11 @@ int sd_do_command(SDState *sd, SDRequest *req,return 0 ; } +if (sd->state == sd_inactive_state) { + rtype = sd_illegal; + goto send_response; + } +if (sd_req_crc_validate (req)) { sd->card_status |=COM_CRC_ERROR ; rtype = sd_illegal;
Signature · 1 line
2.41.0
PATCH v2 11/12 hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6)
In reply to Philippe Mathieu-DaudéSWITCH_FUNCTION is only allowed in TRANSFER state
(See 4.8 "Card State Transition Table).
--- hw/sd/sd.c | 4 ++++ 1 file changed, 4 insertions(+)
hw/sd/sd.c +4 -0
@@ -1196,6 +1196,10 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)if (sd->mode != sd_data_transfer_mode) {return sd_invalid_mode_for_cmd (sd, req); } +if (sd->state != sd_transfer_state) { +return sd_invalid_state_for_cmd (sd, req); + } +sd_function_switch (sd, req.arg); sd->state = sd_sendingdata_state; sd->data_start =0 ;
Signature · 1 line
2.41.0
PATCH v2 12/12 hw/sd/sdcard: Add direct reference to SDProto in SDState
In reply to Philippe Mathieu-DaudéKeep direct reference to SDProto in SDState,
remove then unnecessary sd_proto().
--- hw/sd/sd.c | 37 +++++++++++++++++-------------------- 1 file changed, 17 insertions(+), 20 deletions(-)
hw/sd/sd.c +17 -20
@@ -117,6 +117,8 @@ struct SDState {uint8_t spec_version;BlockBackend *blk; +const SDProto *proto; +/* Runtime changeables */ uint32_t mode;/* current card mode, one of SDCardModes */
@@ -155,18 +157,11 @@ struct SDState {static void sd_realize (DeviceState *dev,Error **errp); -static const struct SDProto *sd_proto (SDState *sd) -{ -SDCardClass *sc =SD_CARD_GET_CLASS (sd); - -return sc->proto; -} -static const SDProto sd_proto_spi;static bool sd_is_spi (SDState *sd) { -return sd_proto (sd) == &sd_proto_spi; +return sd->proto == &sd_proto_spi; }static const char *sd_version_str (enum SDPhySpecificationVersion version)
@@ -1035,7 +1030,7 @@ static bool address_in_range(SDState *sd, const char *desc,static sd_rsp_type_t sd_invalid_state_for_cmd (SDState *sd,SDRequest req) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: CMD%i in a wrong state: %s (spec %s)\n" , -sd_proto (sd)->name, req.cmd,sd_state_name (sd->state), + sd->proto->name, req.cmd,sd_state_name (sd->state),sd_version_str (sd->spec_version));return sd_illegal;
@@ -1044,7 +1039,7 @@ static sd_rsp_type_t sd_invalid_state_for_cmd(SDState *sd, SDRequest req)static sd_rsp_type_t sd_invalid_mode_for_cmd (SDState *sd,SDRequest req) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: CMD%i in a wrong mode: %s (spec %s)\n" , -sd_proto (sd)->name, req.cmd,sd_mode_name (sd->mode), + sd->proto->name, req.cmd,sd_mode_name (sd->mode),sd_version_str (sd->spec_version));return sd_illegal;
@@ -1053,7 +1048,7 @@ static sd_rsp_type_t sd_invalid_mode_for_cmd(SDState *sd, SDRequest req)static sd_rsp_type_t sd_cmd_illegal (SDState *sd,SDRequest req) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: Unknown CMD%i for spec %s\n" , -sd_proto (sd)->name, req.cmd, + sd->proto->name, req.cmd,sd_version_str (sd->spec_version));return sd_illegal;
@@ -1064,7 +1059,7 @@ __attribute__((unused))static sd_rsp_type_t sd_cmd_unimplemented (SDState *sd,SDRequest req) {qemu_log_mask (LOG_UNIMP ,"%s: CMD%i not implemented\n" , -sd_proto (sd)->name, req.cmd); + sd->proto->name, req.cmd);return sd_illegal; }
@@ -1157,7 +1152,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)* However there is no ACMD55, so we want to trace this particular case. */ if (req.cmd !=55 || sd->expecting_acmd) { -trace_sdcard_normal_command (sd_proto (sd)->name, +trace_sdcard_normal_command (sd->proto->name, sd->last_cmd_name, req.cmd, req.arg,sd_state_name (sd->state)); }
@@ -1176,8 +1171,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)return sd_illegal; } -if (sd_proto (sd)->cmd[req.cmd]) { -return sd_proto (sd)->cmd[req.cmd](sd, req); +if (sd->proto->cmd[req.cmd]) { +return sd->proto->cmd[req.cmd](sd, req); }switch (req.cmd) {
@@ -1623,12 +1618,12 @@ static sd_rsp_type_t sd_app_command(SDState *sd, SDRequest req) { sd->last_cmd_name =sd_acmd_name (req.cmd); -trace_sdcard_app_command (sd_proto (sd)->name, sd->last_cmd_name, +trace_sdcard_app_command (sd->proto->name, sd->last_cmd_name, req.cmd, req.arg,sd_state_name (sd->state)); sd->card_status |=APP_CMD ; -if (sd_proto (sd)->acmd[req.cmd]) { -return sd_proto (sd)->acmd[req.cmd](sd, req); +if (sd->proto->acmd[req.cmd]) { +return sd->proto->acmd[req.cmd](sd, req); }switch (req.cmd) {
@@ -1919,7 +1914,7 @@ void sd_write_byte(SDState *sd, uint8_t value)if (sd->card_status & (ADDRESS_ERROR |WP_VIOLATION ))return ; -trace_sdcard_write_data (sd_proto (sd)->name, +trace_sdcard_write_data (sd->proto->name, sd->last_cmd_name, sd->current_cmd, sd->data_offset, value);switch (sd->current_cmd) {
@@ -2074,7 +2069,7 @@ uint8_t sd_read_byte(SDState *sd) io_len = (sd->ocr & (1 <<30 )) ?512 : sd->blk_len; -trace_sdcard_read_data (sd_proto (sd)->name, +trace_sdcard_read_data (sd->proto->name, sd->last_cmd_name, sd->current_cmd, sd->data_offset, io_len);switch (sd->current_cmd) {
@@ -2218,7 +2213,9 @@ static const SDProto sd_proto_sd = {static void sd_instance_init (Object *obj) {SDState *sd =SD_CARD (obj); +SDCardClass *sc =SD_CARD_GET_CLASS (sd); + sd->proto = sc->proto; sd->last_cmd_name ="UNSET" ; sd->enable = true; sd->ocr_power_timer =timer_new_ns (QEMU_CLOCK_VIRTUAL , sd_ocr_powerup, sd);
Signature · 1 line
2.41.0
Quoted 21 lines · Philippe Mathieu-Daudé
Since v1:
- various patches merged, few more addedVarious SD card cleanups and fixes accumulated over the years. Various have been useful to help integrating eMMC support (which will come later).
Philippe Mathieu-Daudé (12):
tests/qtest: Disablenpcm7xx_sdhcitests using hardcoded RCA hw/sd/sdcard: Generate random RCA value
hw/sd/sdcard: Track last command used to help logging hw/sd/sdcard: Trace block offset in READ/WRITE data accesses hw/sd/sdcard: Do not store vendor data on block drive (CMD56) hw/sd/sdcard: SendWRITE_PROTbits MSB first (CMD30) hw/sd/sdcard: SendNUM_WR_BLOCKSbits MSB first (ACMD22) hw/sd/sdcard: UseREADY_FOR_DATAdefinition instead of magic value hw/sd/sdcard: Assign SDCardStates enum values hw/sd/sdcard: Simplifysd_inactive_statehandling hw/sd/sdcard: RestrictSWITCH_FUNCTIONtosd_transfer_state(CMD6) hw/sd/sdcard: Add direct reference to SDProto in SDState
Quoted 5 lines
hw/sd/sd.c | 119 ++++++++++++++++--------------- tests/qtest/npcm7xx_sdhci-test.c | 7 ++ hw/sd/trace-events | 4 +- 3 files changed, 70 insertions(+), 60 deletions(-)
Thanks,
C.