Skip to contentSkip to conversation

gpio: graniterapids: Add missing raw_spinlock_init()

PATCH Applied Aapo Vienamo 3 participants 3 messages Jun 25, 2024 – Jun 26, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: graniterapids: Add missing raw_spinlock_init()

Add the missing raw_spin_lock_init() call to gnr_gpio_probe().

Fixes ecc4b1418e23 ("gpio: Add Intel Granite Rapids-D vGPIO driver")
---
 drivers/gpio/gpio-graniterapids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-graniterapids.c +2 -0
index c693fe05d50f..f2e911a3d2ca 100644
@@ -296,6 +296,8 @@ static int gnr_gpio_probe(struct platform_device *pdev)
 	if (!priv)
 		return -ENOMEM;
 
+	raw_spin_lock_init(&priv->lock);
+
 	regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(regs))
 		return PTR_ERR(regs);
Signature · 1 line
2.45.2
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Aapo Vienamo

Add the missing raw_spin_lock_init() call to gnr_gpio_probe().

Fixes ecc4b1418e23 ("gpio: Add Intel Granite Rapids-D vGPIO driver")

Linus/Bartosz, I wonder if you can take this one directly? Andy is currently on vacation and mine starts after this week so there is nobody handling these until August. Thanks!

Quoted 19 lines
---
 drivers/gpio/gpio-graniterapids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-graniterapids.c +2 -0
index c693fe05d50f..f2e911a3d2ca 100644
@@ -296,6 +296,8 @@ static int gnr_gpio_probe(struct platform_device *pdev)
 	if (!priv)
 		return -ENOMEM;
 
+	raw_spin_lock_init(&priv->lock);
+
 	regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(regs))
 		return PTR_ERR(regs);
Signature · 1 line
2.45.2