Skip to contentSkip to conversation

dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type

PATCH In review Frank Li 1 participant 3 messages Jun 25, 2024

Subsystems (4)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type

fsl,pcie-scfg actually need an argument when there are more than one PCIe instances. Change it to phandle-array and use items to descript each field means.

---
 .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml      | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml +7 -1
index 793986c5af7ff..679c2989de7a2 100644
@@ -43,10 +43,16 @@ properties:
       - const: config
 
   fsl,pcie-scfg:
-    $ref: /schemas/types.yaml#/definitions/phandle
+    $ref: /schemas/types.yaml#/definitions/phandle-array
     description: A phandle to the SCFG device node. The second entry is the
       physical PCIe controller index starting from '0'. This is used to get
       SCFG PEXN registers.
+    items:
+      items:
+        - description: A phandle to the SCFG device node
+        - description: PCIe controller index starting from '0'
+      minItems: 1
+    maxItems: 1
 
   big-endian:
     $ref: /schemas/types.yaml#/definitions/flag
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep

Allow compatible string fallback to general fsl,ls-pcie-ep. Fix below warning:

arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: pcie_ep@3400000: compatible: ['fsl,ls1046a-pcie-ep', 'fsl,ls-pcie-ep'] is too long

---
 .../bindings/pci/fsl,layerscape-pcie-ep.yaml      | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml +9 -6
index 399efa7364c93..21f1edfe814d4 100644
@@ -22,12 +22,15 @@ description:
 
 properties:
   compatible:
-    enum:
-      - fsl,ls2088a-pcie-ep
-      - fsl,ls1088a-pcie-ep
-      - fsl,ls1046a-pcie-ep
-      - fsl,ls1028a-pcie-ep
-      - fsl,lx2160ar2-pcie-ep
+    items:
+      - enum:
+          - fsl,ls2088a-pcie-ep
+          - fsl,ls1088a-pcie-ep
+          - fsl,ls1046a-pcie-ep
+          - fsl,ls1028a-pcie-ep
+          - fsl,lx2160ar2-pcie-ep
+      - const: fsl,ls-pcie-ep
+    minItems: 1
 
   reg:
     maxItems: 2
Signature · 1 line
2.34.1
author maintainer
#2 lore raw

Re: [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep

Quoted 7 lines · Frank Li

Allow compatible string fallback to general fsl,ls-pcie-ep. Fix below warning:

arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: pcie_ep@3400000: compatible: ['fsl,ls1046a-pcie-ep', 'fsl,ls-pcie-ep'] is too long

---

Sorry, this patch sent out accidently. 'fsl,ls-pcie-ep' actually are not used in driver.

Frank Li

Quoted 32 lines
 .../bindings/pci/fsl,layerscape-pcie-ep.yaml      | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml +9 -6
index 399efa7364c93..21f1edfe814d4 100644
@@ -22,12 +22,15 @@ description:
 
 properties:
   compatible:
-    enum:
-      - fsl,ls2088a-pcie-ep
-      - fsl,ls1088a-pcie-ep
-      - fsl,ls1046a-pcie-ep
-      - fsl,ls1028a-pcie-ep
-      - fsl,lx2160ar2-pcie-ep
+    items:
+      - enum:
+          - fsl,ls2088a-pcie-ep
+          - fsl,ls1088a-pcie-ep
+          - fsl,ls1046a-pcie-ep
+          - fsl,ls1028a-pcie-ep
+          - fsl,lx2160ar2-pcie-ep
+      - const: fsl,ls-pcie-ep
+    minItems: 1
 
   reg:
     maxItems: 2
Signature · 1 line
2.34.1