tty: serial: ma35d1: Add a NULL check for of_node
Subsystems (2)
PATCH v3 1/1 tty: serial: ma35d1: Add a NULL check for of_node
From: Jacky Huang <[email protected]>
The pdev->dev.of_node can be NULL if the "serial" node is absent. Add a NULL check to return an error in such cases.
v3:
- Added "Reported-by:" line.
v2:
- Added "Fixes" line.
Fixes 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Jacky Huang <[email protected]>
--- drivers/tty/serial/ma35d1_serial.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/tty/serial/ma35d1_serial.c +7 -6
@@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev)struct uart_ma35d1_port *up;int ret =0 ; -if (pdev->dev.of_node) { - ret =of_alias_get_id (pdev->dev.of_node,"serial" ); -if (ret <0 ) { -dev_err (&pdev->dev,"failed to get alias/pdev id, errno %d\n" , ret); -return ret; - } +if (!pdev->dev.of_node) +return -ENODEV ; + + ret =of_alias_get_id (pdev->dev.of_node,"serial" ); +if (ret <0 ) { +dev_err (&pdev->dev,"failed to get alias/pdev id, errno %d\n" , ret); +return ret; } up = &ma35d1serial_ports[ret]; up->port.line = ret;
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 9 lines · Jacky Huang
From: Jacky Huang <[email protected]>
The
pdev->dev.of_nodecan be NULL if the "serial" node is absent. Add a NULL check to return an error in such cases.v3:
- Added "Reported-by:" line.
v2:
- Added "Fixes" line.
As per the kernel documentation, these "v3:" information goes below the --- line.
Please fix up and send a v4.
thanks,
greg k-h