Skip to contentSkip to conversation

dt-bindings: net: convert enetc to yaml

PATCH Superseded Frank Li 4 participants 10 messages Jun 26, 2024 – Jul 10, 2024

Subsystems (5)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: net: convert enetc to yaml

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +35 -0
new file mode 100644
index 0000000000000..ce88d7ce07a5e
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-ierb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Integrated Endpoint Register Block
+
+description:
+  The fsl_enetc driver can probe on the Integrated Endpoint Register
+  Block, which preconfigures the FIFO limits for the ENETC ports.
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - fsl,ls1028a-enetc-ierb
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ierb@1f0800000 {
+        compatible = "fsl,ls1028a-enetc-ierb";
+        reg = <0xf0800000 0x10000>;
+    };
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +53 -0

53 lines not on this page · raw message

Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +50 -0

50 lines not on this page · raw message

Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -119

119 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 13 lines · Frank Li

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

Quoted 11 lines
---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: reg: [[1, 4026531840], [0, 1048576]] is too long
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mdio@0,3' were unexpected)
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc-mdio.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: reg: [[1, 4026531840], [0, 1048576]] is too long
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'ethernet@0,0' were unexpected)
from schema $id: http://devicetree.org/schemas/pci/host-generic-pci.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: 'device_type' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: pcie@1f0000000: 'ranges' is a required property
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

reviewer
#2 lore raw
In reply to Frank Li

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 32

Quoted 3 lines · Frank Li
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +3 -0
+examples:
+  - |
+    ierb@1f0800000 {

Node names should be generic.

maintainer
#3 lore raw
Quoted 7 lines · Fabio Estevam

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 32

Quoted 3 lines · Frank Li
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +3 -0
+examples:
+  - |
+    ierb@1f0800000 {

Node names should be generic.

Yes, but what would that be for this block? Unless we have (or add) a documented name, then it doesn't matter too much.

Rob

maintainer
#4 lore raw
In reply to Frank Li
Quoted 31 lines · Frank Li

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +1 -0
new file mode 100644
index 0000000000000..ce88d7ce07a5e
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-ierb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Integrated Endpoint Register Block
+
+description:
+  The fsl_enetc driver can probe on the Integrated Endpoint Register
+  Block, which preconfigures the FIFO limits for the ENETC ports.

Wrap at 80 chars

Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +11 -0
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - fsl,ls1028a-enetc-ierb
+
+  reg:
+    maxItems: 1

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ierb@1f0800000 {

unit-address doesn't match

Quoted 13 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +3 -0
+        compatible = "fsl,ls1028a-enetc-ierb";
+        reg = <0xf0800000 0x10000>;
+    };
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
new file mode 100644
index 0000000000000..60740ea56cb08
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-mdio.yaml#

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +10 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENETC the central MDIO PCIe endpoint device
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+
+maintainers:
+  - Frank Li <[email protected]>.

stray '.' ^

Quoted 7 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 31

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +10 -0
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: mdio.yaml

As a PCI device, also needs pci-device.yaml.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 39

Quoted 8 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +8 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;

Drop compatible and reg. Just need the minimum to define a PCI bus node.

Quoted 42 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +14 -0
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        mdio@0,3 {
+            compatible = "pci1957,ee01", "fsl,enetc-mdio";
+            reg = <0x000300 0 0 0 0>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet-phy@2 {
+                reg = <0x2>;
+            };
+        };
+    };
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +22 -0
new file mode 100644
index 0000000000000..843c27e357f2d
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENETC ethernet
+
+description:
+  Depending on board design and ENETC port type (internal or
+  external) there are two supported link modes specified by
+  below device tree bindings.
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,e100
+      - const: fsl,enetc

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +10 -0
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: ethernet-controller.yaml

As a PCI device, also needs pci-device.yaml.

Quoted 18 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +18 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        ethernet@0,0 {
+            compatible = "pci1957,e100", "fsl,enetc";
+            reg = <0x000000 0 0 0 0>;
+            phy-handle = <&sgmii_phy0>;
+            phy-connection-type = "sgmii";
+        };
+    };
author maintainer
#5 lore raw
Quoted 106 lines · Rob Herring
Quoted 31 lines · Frank Li

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +1 -0
new file mode 100644
index 0000000000000..ce88d7ce07a5e
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-ierb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Integrated Endpoint Register Block
+
+description:
+  The fsl_enetc driver can probe on the Integrated Endpoint Register
+  Block, which preconfigures the FIFO limits for the ENETC ports.

Wrap at 80 chars

Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +11 -0
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - fsl,ls1028a-enetc-ierb
+
+  reg:
+    maxItems: 1

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ierb@1f0800000 {

unit-address doesn't match

Quoted 13 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +3 -0
+        compatible = "fsl,ls1028a-enetc-ierb";
+        reg = <0xf0800000 0x10000>;
+    };
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
new file mode 100644
index 0000000000000..60740ea56cb08
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-mdio.yaml#

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +10 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENETC the central MDIO PCIe endpoint device
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+
+maintainers:
+  - Frank Li <[email protected]>.

stray '.' ^

Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +11 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio
+
+  reg:
+    maxItems: 1
+
Quoted 8 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 31

Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +6 -0
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: mdio.yaml

As a PCI device, also needs pci-device.yaml.

After I add pci-devices.yaml, I get
Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: ethernet@0,0: False schema does not allow {'compatible': ['pci1957,e100', 'fsl,enetc'], 'reg': [[0, 0, 0, 0, 0]], 'phy-handle': [[4294967295]], 'phy-connection-type': ['sgmii'], '$nodename': ['ethernet@0,0']}

It looks like match to two schemas, then report error. If I change enetc's compatible string to other random string. No error report.

I am not sure how to fix this. I have not seen other schema use pci-device.yaml yet.

Frank

Quoted 85 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 39

Quoted 9 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +8 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;

Drop compatible and reg. Just need the minimum to define a PCI bus node.

Quoted 42 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +14 -0
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        mdio@0,3 {
+            compatible = "pci1957,ee01", "fsl,enetc-mdio";
+            reg = <0x000300 0 0 0 0>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet-phy@2 {
+                reg = <0x2>;
+            };
+        };
+    };
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +22 -0
new file mode 100644
index 0000000000000..843c27e357f2d
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENETC ethernet
+
+description:
+  Depending on board design and ENETC port type (internal or
+  external) there are two supported link modes specified by
+  below device tree bindings.
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,e100
+      - const: fsl,enetc

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +10 -0
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: ethernet-controller.yaml

As a PCI device, also needs pci-device.yaml.

Quoted 18 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +18 -0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        ethernet@0,0 {
+            compatible = "pci1957,e100", "fsl,enetc";
+            reg = <0x000000 0 0 0 0>;
+            phy-handle = <&sgmii_phy0>;
+            phy-connection-type = "sgmii";
+        };
+    };
maintainer
#6 lore raw
Quoted 117 lines · Frank Li
Quoted 106 lines · Rob Herring
Quoted 31 lines · Frank Li

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +1 -0
new file mode 100644
index 0000000000000..ce88d7ce07a5e
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-ierb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Integrated Endpoint Register Block
+
+description:
+  The fsl_enetc driver can probe on the Integrated Endpoint Register
+  Block, which preconfigures the FIFO limits for the ENETC ports.

Wrap at 80 chars

Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +11 -0
+
+maintainers:
+  - Frank Li <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - fsl,ls1028a-enetc-ierb
+
+  reg:
+    maxItems: 1

Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    ierb@1f0800000 {

unit-address doesn't match

Quoted 13 lines
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml new file +3 -0
+        compatible = "fsl,ls1028a-enetc-ierb";
+        reg = <0xf0800000 0x10000>;
+    };
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
new file mode 100644
index 0000000000000..60740ea56cb08
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/fsl,enetc-mdio.yaml#

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +10 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENETC the central MDIO PCIe endpoint device
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+
+maintainers:
+  - Frank Li <[email protected]>.

stray '.' ^

Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +11 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio
+
+  reg:
+    maxItems: 1
+
Quoted 8 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 31

Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +6 -0
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: mdio.yaml

As a PCI device, also needs pci-device.yaml.

Quoted 2 lines

After I add pci-devices.yaml, I get
Documentation/devicetree/bindings/net/fsl,enetc.example.dtb: ethernet@0,0: False schema does not allow {'compatible': ['pci1957,e100', 'fsl,enetc'], 'reg': [[0, 0, 0, 0, 0]], 'phy-handle': [[4294967295]], 'phy-connection-type': ['sgmii'], '$nodename': ['ethernet@0,0']}

Perhaps use pci-device.yaml, not pci-devices.yaml which doesn't exist. The latter gives me this error, the former works fine for me.

Rob

maintainer
#7 lore raw
In reply to Frank Li
Quoted 11 lines

-----Original Message-----
From: Frank Li <[email protected]>
Sent: 2024年6月27日 0:23
To: [email protected]
Cc: Frank Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v2 1/1] dt-bindings: net: convert enetc to yaml

Quoted 3 lines

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Sorry I didn't see this patch until now, I was planning to make this conversion but didn't realize you had started it first. It's very nice, thanks!

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml

Quoted 28 lines

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)  create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +0 -0
new file mode 100644
index 0000000000000..60740ea56cb08

I suggest changing the file name to nxp,netc-emdio.yaml. "fsl" is a very outdated prefix. For new files, I think "nxp" is a better prefix.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 4

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+
+title: ENETC the central MDIO PCIe endpoint device

external is better, that is why we call it EMDIO.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +5 -0
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+

This my local description, excerpted from NETC's block guide, FYI.
description: |
NETC provides an external master MDIO interface (EMDIO) for managing external devices (PHYs). EMDIO supports both Clause 22 and 45 protocols. And the EMDIO provides a means for different software modules to share a single set of MDIO signals to access their PHYs.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 2 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +2 -0
+maintainers:
+  - Frank Li <[email protected]>.

Vladimir and Claudiu as the driver maintainer, it is best to add them to this list

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 21

Quoted 7 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio

" fsl,enetc-mdio" is meaningless, we did not use it ever.

Documentation/devicetree/bindings/net/fsl,enetc.yaml

Quoted 38 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +32 -0
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: mdio.yaml
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        mdio@0,3 {
+            compatible = "pci1957,ee01", "fsl,enetc-mdio";
+            reg = <0x000300 0 0 0 0>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet-phy@2 {
+                reg = <0x2>;
+            };
+        };
+    };
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +0 -0
new file mode 100644
index 0000000000000..843c27e357f2d

Same as above, nxp,enetc.yaml or nxp,netc-enetc.yaml is better.

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 1

Quoted 2 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +1 -0
@@ -0,0 +1,50 @@
+title: ENETC ethernet

title: The NIC functionality of NXP NETC

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +5 -0
+
+description:
+  Depending on board design and ENETC port type (internal or
+  external) there are two supported link modes specified by
+  below device tree bindings.

description: |
The NIC functionality in NETC is known as EtherNET Controller (ENETC). ENETC supports virtualization/isolation based on PCIe Single Root IO Virtualization (SR-IOV), advanced QoS with 8 traffic classes and 4 drop resilience levels, and a full range of TSN standards and NIC offload capabilities.

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 9

Quoted 3 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +3 -0
+
+maintainers:
+  - Frank Li <[email protected]>

Save as above.

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 22

Quoted 7 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,e100
+      - const: fsl,enetc

Should be removed.

Documentation/devicetree/bindings/net/fsl,enetc.yaml line 20

Quoted 4 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +4 -0
+
+  reg:
+    maxItems: 1
+

This is an example I see in fsl-enetc.txt

ethernet@0,0 {
	compatible = "fsl,enetc";
	reg = <0x000000 0 0 0 0>;
	phy-handle = <&sgmii_phy0>;
	phy-connection-type = "sgmii";

	mdio {
		#address-cells = <1>;
		#size-cells = <0>;
		sgmii_phy0: ethernet-phy@2 {
			reg = <0x2>;
		};
	};
};

But here I don't see any description of the mdio child node. I think you need to add it, just like below.
mdio:
$ref: mdio.yaml#
unevaluatedProperties: false
description: |
Optional child node for ENETC instance, otherwise use NETC EMDIO.

Quoted 152 lines
Documentation/devicetree/bindings/net/fsl,enetc.yaml new file +24 -0
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: ethernet-controller.yaml
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pcie@1f0000000 {
+        compatible = "pci-host-ecam-generic";
+        reg = <0x01 0xf0000000 0x0 0x100000>;
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        ethernet@0,0 {
+            compatible = "pci1957,e100", "fsl,enetc";
+            reg = <0x000000 0 0 0 0>;
+            phy-handle = <&sgmii_phy0>;
+            phy-connection-type = "sgmii";
+        };
+    };
Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -4
deleted file mode 100644
index 9b9a3f197e2d3..0000000000000
@@ -1,119 +0,0 @@
-* ENETC ethernet device tree bindings
-
-Depending on board design and ENETC port type (internal or
-external) there are two supported link modes specified by -below device tree

bindings.

Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -13
-
-Required properties:
-
-- reg		: Specifies PCIe Device Number and Function
-		  Number of the ENETC endpoint device, according
-		  to parent node bindings.
-- compatible	: Should be "fsl,enetc".
-
-1. The ENETC external port is connected to a MDIO configurable phy
-
-1.1. Using the local ENETC Port MDIO interface
-
-In this case, the ENETC node should include a "mdio" sub-node -that in turn

should contain the "ethernet-phy" node describing the -external phy. Below properties are required, their bindings -already defined in Documentation/devicetree/bindings/net/ethernet.txt or

Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -33
-Documentation/devicetree/bindings/net/phy.txt.
-
-Required:
-
-- phy-handle		: Phandle to a PHY on the MDIO bus.
-			  Defined in ethernet.txt.
-
-- phy-connection-type	: Defined in ethernet.txt.
-
-- mdio			: "mdio" node, defined in mdio.txt.
-
-- ethernet-phy		: "ethernet-phy" node, defined in phy.txt.
-
-Example:
-
-	ethernet@0,0 {
-		compatible = "fsl,enetc";
-		reg = <0x000000 0 0 0 0>;
-		phy-handle = <&sgmii_phy0>;
-		phy-connection-type = "sgmii";
-
-		mdio {
-			#address-cells = <1>;
-			#size-cells = <0>;
-			sgmii_phy0: ethernet-phy@2 {
-				reg = <0x2>;
-			};
-		};
-	};
-
-1.2. Using the central MDIO PCIe endpoint device
-
-In this case, the mdio node should be defined as another PCIe -endpoint node,

at the same level with the ENETC port nodes.

Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -33
-
-Required properties:
-
-- reg		: Specifies PCIe Device Number and Function
-		  Number of the ENETC endpoint device, according
-		  to parent node bindings.
-- compatible	: Should be "fsl,enetc-mdio".
-
-The remaining required mdio bus properties are standard, their bindings
-already defined in Documentation/devicetree/bindings/net/mdio.txt.
-
-Example:
-
-	ethernet@0,0 {
-		compatible = "fsl,enetc";
-		reg = <0x000000 0 0 0 0>;
-		phy-handle = <&sgmii_phy0>;
-		phy-connection-type = "sgmii";
-	};
-
-	mdio@0,3 {
-		compatible = "fsl,enetc-mdio";
-		reg = <0x000300 0 0 0 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		sgmii_phy0: ethernet-phy@2 {
-			reg = <0x2>;
-		};
-	};
-
-2. The ENETC port is an internal port or has a fixed-link external -connection
-
-In this case, the ENETC port node defines a fixed link connection, -as specified

by Documentation/devicetree/bindings/net/fixed-link.txt.

Documentation/devicetree/bindings/net/fsl-enetc.txt deleted +0 -30
-
-Required:
-
-- fixed-link	: "fixed-link" node, defined in "fixed-link.txt".
-
-Example:
-	ethernet@0,2 {
-		compatible = "fsl,enetc";
-		reg = <0x000200 0 0 0 0>;
-		fixed-link {
-			speed = <1000>;
-			full-duplex;
-		};
-	};
-
-* Integrated Endpoint Register Block bindings
-
-Optionally, the fsl_enetc driver can probe on the Integrated Endpoint Register
-Block, which preconfigures the FIFO limits for the ENETC ports. This is a node
-with the following properties:
-
-- reg		: Specifies the address in the SoC memory space.
-- compatible	: Must be "fsl,ls1028a-enetc-ierb".
-
-Example:
-	ierb@1f0800000 {
-		compatible = "fsl,ls1028a-enetc-ierb";
-		reg = <0x01 0xf0800000 0x0 0x10000>;
-	};
--

2.34.1

maintainer
#8 lore raw
Quoted 41 lines · Wei Fang
Quoted 12 lines

-----Original Message-----
From: Frank Li <[email protected]>
Sent: 2024年6月27日 0:23
To: [email protected]
Cc: Frank Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v2 1/1] dt-bindings: net: convert enetc to yaml

Quoted 3 lines

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Sorry I didn't see this patch until now, I was planning to make this conversion but didn't realize you had started it first. It's very nice, thanks!

Quoted 22 lines

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)  create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644 Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/fsl-enetc.txt
Quoted 9 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml

Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +0 -0
new file mode 100644
index 0000000000000..60740ea56cb08

I suggest changing the file name to nxp,netc-emdio.yaml. "fsl" is a very outdated prefix. For new files, I think "nxp" is a better prefix.

Convention is filenames use the compatible string. So no.

Quoted 24 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 4

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+
+title: ENETC the central MDIO PCIe endpoint device

external is better, that is why we call it EMDIO.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +5 -0
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+

This my local description, excerpted from NETC's block guide, FYI.
description: |
NETC provides an external master MDIO interface (EMDIO) for managing external devices (PHYs). EMDIO supports both Clause 22 and 45 protocols. And the EMDIO provides a means for different software modules to share a single set of MDIO signals to access their PHYs.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 2 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +2 -0
+maintainers:
+  - Frank Li <[email protected]>.

Vladimir and Claudiu as the driver maintainer, it is best to add them to this list

Quoted 9 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 21

Quoted 7 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio

" fsl,enetc-mdio" is meaningless, we did not use it ever.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:
compatible = "pci1957,ee01", "fsl,enetc-mdio";

In fact, until I recently added the standard PCI compatibles, these were the only compatible strings used.

Rob

maintainer
#9 lore raw
Quoted 68 lines

-----Original Message-----
From: Rob Herring <[email protected]>
Sent: 2024年7月9日 22:11
To: Wei Fang <[email protected]>
Cc: Frank Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Vladimir Oltean <[email protected]>; Claudiu Manoil <[email protected]>; Clark Wang <[email protected]>
Subject: Re: [PATCH v2 1/1] dt-bindings: net: convert enetc to yaml

Quoted 44 lines · Wei Fang
Quoted 12 lines

-----Original Message-----
From: Frank Li <[email protected]>
Sent: 2024年6月27日 0:23
To: [email protected]
Cc: Frank Li <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v2 1/1] dt-bindings: net: convert enetc to yaml

Quoted 3 lines

Convert enetc device binding file to yaml. Split to 3 yaml files, 'fsl,enetc.yaml', 'fsl,enetc-mdio.yaml', 'fsl,enetc-ierb.yaml'.

Sorry I didn't see this patch until now, I was planning to make this conversion but didn't realize you had started it first. It's very nice, thanks!

Quoted 25 lines

Additional Changes:
- Add pci<vendor id>,<production id> in compatible string.
- Ref to common ethernet-controller.yaml and mdio.yaml.
- Remove fixed-link part.

---
Change from v1 to v2
- renamee file as fsl,enetc-mdio.yaml, fsl,enetc-ierb.yaml, fsl,enetc.yaml
- example include pcie node

---
 .../bindings/net/fsl,enetc-ierb.yaml          |  35 ++++++
 .../bindings/net/fsl,enetc-mdio.yaml          |  53 ++++++++
 .../devicetree/bindings/net/fsl,enetc.yaml    |  50 ++++++++
 .../devicetree/bindings/net/fsl-enetc.txt     | 119 ------------------
 4 files changed, 138 insertions(+), 119 deletions(-)  create mode
100644 Documentation/devicetree/bindings/net/fsl,enetc-ierb.yaml
 create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
 create mode 100644
Documentation/devicetree/bindings/net/fsl,enetc.yaml
 delete mode 100644

Documentation/devicetree/bindings/net/fsl-enetc.txt

Quoted 10 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml

Quoted 7 lines

diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file mode 100644
index 0000000000000..60740ea56cb08

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +0 -0

I suggest changing the file name to nxp,netc-emdio.yaml. "fsl" is a very outdated prefix. For new files, I think "nxp" is a better prefix.

Quoted 1 line

Convention is filenames use the compatible string. So no.

Actually, the "fsl,enetc-mdio" compatible is not used in the driver, I'm not sure whether we should still keep it in the DTS, maybe we can remove it from DTS first, or rename the compatible string, IMO, "fsl,enetc-mdio" is not quiet right, this MDIO controller not only provide MDIO bus to ENETC, but also to NETC switch.

Quoted 45 lines
Quoted 8 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 4

Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +4 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+
+title: ENETC the central MDIO PCIe endpoint device

external is better, that is why we call it EMDIO.

Quoted 8 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 12

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +5 -0
+
+description:
+  In this case, the mdio node should be defined as another PCIe
+  endpoint node, at the same level with the ENETC port nodes
+

This my local description, excerpted from NETC's block guide, FYI.
description: |
NETC provides an external master MDIO interface (EMDIO) for managing

external

Quoted 1 line

devices (PHYs). EMDIO supports both Clause 22 and 45 protocols. And

the EMDIO

Quoted 1 line

provides a means for different software modules to share a single set of

MDIO

Quoted 7 lines

signals to access their PHYs.

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 14

Quoted 2 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +2 -0
+maintainers:
+  - Frank Li <[email protected]>.

Vladimir and Claudiu as the driver maintainer, it is best to add them to this list

Quoted 9 lines

Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml line 21

Quoted 7 lines
Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml new file +7 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - pci1957,ee01
+      - const: fsl,enetc-mdio

" fsl,enetc-mdio" is meaningless, we did not use it ever.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:
compatible = "pci1957,ee01", "fsl,enetc-mdio";

In fact, until I recently added the standard PCI compatibles, these were the only compatible strings used.