Skip to contentSkip to conversation

Perf: Calling available function for stats printing

PATCH In review Abhishek Dubey 2 participants 2 messages Jun 27, 2024 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Perf: Calling available function for stats printing

For printing dump_trace, just use existing stats_print() function.

---
 tools/perf/builtin-report.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
tools/perf/builtin-report.c +1 -4
index 69618fb0110b..8678eebc49e6 100644
@@ -1089,10 +1089,7 @@ static int __cmd_report(struct report *rep)
 			perf_session__fprintf_dsos(session, stdout);
 
 		if (dump_trace) {
-			perf_session__fprintf_nr_events(session, stdout,
-							rep->skip_empty);
-			evlist__fprintf_nr_events(session->evlist, stdout,
-						  rep->skip_empty);
+			stats_print(rep);
 			return 0;
 		}
 	}
Signature · 1 line
2.44.0
reviewer
#1 lore raw
Quoted 5 lines · Abhishek Dubey

For printing dump_trace, just use existing stats_print() function.

Thanks Abishek, the change looks good but it needs to be rebased on top of Commit 411ee13598ef ("perf hist: Add symbol_conf.skip_empty") -
https://lore.kernel.org/r/[email protected]
. Recently Howard Chu wrote a guide on this:
https://sberm.cn/blog/how-to-contrib-perf

Another small issue is the commit message should be "perf report: ..." rather than "Perf: ...".

Thanks,
Ian