Skip to contentSkip to conversation

drm/amdgpu: Correct register used to clear fault status

PATCH In review Hawking Zhang 2 participants 2 messages Jun 28, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Correct register used to clear fault status

Driver should write to fault_cntl registers to do
one-shot address/status clear.

---
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c +1 -1
index 8d7267a013d2..621761a17ac7 100644
@@ -569,7 +569,7 @@ static bool mmhub_v1_8_query_utcl2_poison_status(struct amdgpu_device *adev,
 	if (!amdgpu_sriov_vf(adev)) {
 		/* clear page fault status and address */
 		WREG32_P(SOC15_REG_OFFSET(MMHUB, hub_inst,
-			 regVM_L2_PROTECTION_FAULT_STATUS), 1, ~1);
+			 regVM_L2_PROTECTION_FAULT_CNTL), 1, ~1);
 	}
 
 	return fed;
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Quoted 31 lines

-----Original Message-----
From: Hawking Zhang <[email protected]>
Sent: Friday, June 28, 2024 5:04 PM
To: [email protected]; Zhou1, Tao <[email protected]>
Cc: Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: Correct register used to clear fault status

Driver should write to fault_cntl registers to do one-shot address/status clear.

---
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c +1 -1
index 8d7267a013d2..621761a17ac7 100644
@@ -569,7 +569,7 @@ static bool
 mmhub_v1_8_query_utcl2_poison_status(struct amdgpu_device *adev,
      if (!amdgpu_sriov_vf(adev)) {
              /* clear page fault status and address */
              WREG32_P(SOC15_REG_OFFSET(MMHUB, hub_inst,
-                      regVM_L2_PROTECTION_FAULT_STATUS), 1, ~1);
+                      regVM_L2_PROTECTION_FAULT_CNTL), 1, ~1);
      }
 
      return fed;

--
2.17.1