drm/amdgpu: Fix hbm stack id in boot error report
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix hbm stack id in boot error report
To align with firmware, hbm id field 0x1 refers to hbm stack 0, 0x2 refers to hbm statck 1.
Signed-off-by Hawking Zhang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1 -1
@@ -4565,7 +4565,7 @@ static void amdgpu_ras_boot_time_error_reporting(struct amdgpu_device *adev, socket_id =AMDGPU_RAS_GPU_ERR_SOCKET_ID (boot_error); aid_id =AMDGPU_RAS_GPU_ERR_AID_ID (boot_error); - hbm_id =AMDGPU_RAS_GPU_ERR_HBM_ID (boot_error); + hbm_id = ((1 ==AMDGPU_RAS_GPU_ERR_HBM_ID (boot_error)) ?0 :1 );if (AMDGPU_RAS_GPU_ERR_MEM_TRAINING (boot_error)) dev_info(adev->dev,
Signature · 1 line
2.17.1
[AMD Official Use Only - AMD Internal Distribution Only]
How about:
hbm_id = AMDGPU_RAS_GPU_ERR_HBM_ID(boot_error) - 1;
Anyway, the patch is:
Reviewed-by Tao Zhou <[email protected]>
Quoted 32 lines
-----Original Message-----
From: Hawking Zhang <[email protected]>
Sent: Friday, June 28, 2024 5:04 PM
To: [email protected]; Zhou1, Tao <[email protected]>
Cc: Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: Fix hbm stack id in boot error reportTo align with firmware, hbm id field
0x1refers to hbm stack 0,0x2refers to hbm statck 1.Signed-off-by Hawking Zhang <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1
-1@@ -4565,7 +4565,7 @@ static void amdgpu_ras_boot_time_error_reporting(struct amdgpu_device *adev, socket_id =AMDGPU_RAS_GPU_ERR_SOCKET_ID (boot_error); aid_id =AMDGPU_RAS_GPU_ERR_AID_ID (boot_error); - hbm_id =AMDGPU_RAS_GPU_ERR_HBM_ID (boot_error); + hbm_id = ((1 ==AMDGPU_RAS_GPU_ERR_HBM_ID (boot_error)) ?0 :1 );if (AMDGPU_RAS_GPU_ERR_MEM_TRAINING (boot_error))dev_info(adev->dev,--
2.17.1