Skip to contentSkip to conversation

arm64: dts: mediatek: mt7622: readd syscon to pciesys node

PATCH Applied Christian Marangi 5 participants 6 messages Jun 28, 2024 – Jul 8, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 arm64: dts: mediatek: mt7622: readd syscon to pciesys node

Sata node reference the pciesys with the property mediatek,phy-node and that is used as a syscon to access the pciesys regs.

Readd the syscon compatible to pciesys node to restore correct functionality of the SATA interface.

Fixes 3ba5a6159434 ("arm64: dts: mediatek: mt7622: fix clock controllers")
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/mediatek/mt7622.dtsi +1 -1
index 917fa39a74f8..bb0ec1edbe5b 100644
@@ -790,7 +790,7 @@ u2port1: usb-phy@1a0c5000 {
 	};
 
 	pciesys: clock-controller@1a100800 {
-		compatible = "mediatek,mt7622-pciesys";
+		compatible = "mediatek,mt7622-pciesys", "syscon";
 		reg = <0 0x1a100800 0 0x1000>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;
Signature · 1 line
2.45.1
#1 lore raw

PATCH v2 2/2 dt-bindings: clock: mediatek: add syscon compatible for mt7622 pciesys

Add required syscon compatible for mt7622 pciesys. This is required for SATA interface as the regs are shared.

---
Changes v2:
- Fix broken schema example

 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml +6 -4
index c77111d10f90..9c3913f9092c 100644
@@ -14,9 +14,11 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - mediatek,mt7622-pciesys
-      - mediatek,mt7629-pciesys
+    oneOf:
+      - items:
+          - const: mediatek,mt7622-pciesys
+          - const: syscon
+      - const: mediatek,mt7629-pciesys
 
   reg:
     maxItems: 1
@@ -38,7 +40,7 @@ additionalProperties: false
 examples:
   - |
     clock-controller@1a100800 {
-        compatible = "mediatek,mt7622-pciesys";
+        compatible = "mediatek,mt7622-pciesys", "syscon";
         reg = <0x1a100800 0x1000>;
         #clock-cells = <1>;
         #reset-cells = <1>;
Signature · 1 line
2.45.1
#4 lore raw
In reply to Christian Marangi
Quoted 5 lines

Sata node reference the pciesys with the property mediatek,phy-node and that is used as a syscon to access the pciesys regs.

Readd the syscon compatible to pciesys node to restore correct functionality of the SATA interface.

…

Quoted 1 line
Reported-by Frank Wunderlich …

Was any related information published?

Regards,
Markus

#5 lore raw

Am 29. Juni 2024 19:35:01 MESZ schrieb Markus Elfring <[email protected]>:

Quoted 5 lines
Quoted 5 lines

Sata node reference the pciesys with the property mediatek,phy-node and that is used as a syscon to access the pciesys regs.

Readd the syscon compatible to pciesys node to restore correct functionality of the SATA interface.

Quoted 8 lines

…

Quoted 1 line
Reported-by Frank Wunderlich …

Was any related information published?

Regards,
Markus

Hi,

I found this while changing uboot to of_upstream and fixed it there (not yet send to mailinglist). As of_upstream uses linux dts,i rechecked if it is broken there too and yes it is.

But i have not sent issue to mailinglist because we fixed it before :) regards Frank