Skip to contentSkip to conversation

arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b

PATCH Applied Diederik de Haas 3 participants 3 messages Jun 28, 2024 – Jul 4, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b

There have been several attempts to set the dma-names property on the SoC level (in rk356x.dtsi), but that appears to cause problems when set on channels without flow control.

Quoting part of a previous attempt for clarification:

Quoted 5 lines

Nah, enabling it for bluetooth is fine because you have flow control. My issues have been on channels without flow control. Without DMA it simply drops messages or the channel hangs until you close and reopen it. With DMA, when an overflow locks up the channel it is usually unavailable until the board is rebooted.

Setting it on the board level for the bluetooth connection was deemed safe, so do so for the Quartz64 Model B.

This fixes the following error/warning:

of_dma_request_slave_channel: dma-names property of node

      '/serial@fe650000' missing or empty

dw-apb-uart fe650000.serial: failed to request DMA

---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts +1 -0
index b908ce006c26..13e599a85eb8 100644
@@ -652,6 +652,7 @@ &tsadc {
 };
 
 &uart1 {
+	dma-names = "tx", "rx";
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
 	status = "okay";
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Diederik de Haas

There have been several attempts to set the dma-names property on the SoC level (in rk356x.dtsi), but that appears to cause problems when set on channels without flow control.

Quoting part of a previous attempt for clarification:

Quoted 5 lines

Nah, enabling it for bluetooth is fine because you have flow control. My issues have been on channels without flow control. Without DMA it simply drops messages or the channel hangs until you close and reopen it. With DMA, when an overflow locks up the channel it is usually unavailable until the board is rebooted.

Setting it on the board level for the bluetooth connection was deemed safe, so do so for the Quartz64 Model B.

This fixes the following error/warning:

Quoted 7 lines

of_dma_request_slave_channel: dma-names property of node

      '/serial@fe650000' missing or empty

dw-apb-uart fe650000.serial: failed to request DMA

Thanks for this patch, it's looking good to me.

Quoted 17 lines
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts +1 -0
index b908ce006c26..13e599a85eb8 100644
@@ -652,6 +652,7 @@ &tsadc {
 };
 
 &uart1 {
+	dma-names = "tx", "rx";
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
 	status = "okay";
maintainer Applied
#2 lore raw
In reply to Diederik de Haas
Quoted 6 lines · Diederik de Haas

There have been several attempts to set the dma-names property on the SoC level (in rk356x.dtsi), but that appears to cause problems when set on channels without flow control.

Quoting part of a previous attempt for clarification:

Quoted 7 lines
Quoted 5 lines

Nah, enabling it for bluetooth is fine because you have flow control. My issues have been on channels without flow control. Without DMA it simply drops messages or the channel hangs until you close and reopen it. With DMA, when an overflow locks up the channel it is usually unavailable until the board is rebooted.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b

      commit: bf6f26deb0e84089700c1b864f643442e262e16b

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>