hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
Subsystems (3)
PATCH 1/1 hwmon: (dell-smm) Add Dell OptiPlex 7060 to DMI table
The BIOS on this machine is buggy and will in some cases return an error when trying to get the fan state, but reading of the RPM values and the temperature sensors still works.
--- Documentation/hwmon/dell-smm-hwmon.rst | 2 ++ drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 2 files changed, 9 insertions(+)
Documentation/hwmon/dell-smm-hwmon.rst +2 -0
@@ -360,6 +360,8 @@ Firmware Bug Affected Machines ======================================================= ================= Reading of fan states return spurious errors. Precision 490 + OptiPlex 7060 + Reading of fan types causes erratic fan behaviour. Studio XPS 8000 Studio XPS 8100
drivers/hwmon/dell-smm-hwmon.c +7 -0
@@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "MP061"), }, }, + { + .ident = "Dell OptiPlex 7060", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"), + }, + }, { .ident ="Dell Precision" , .matches = {
--
2.39.2
Pali Rohár
maintainerQuoted 3 lines · On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
The BIOS on this machine is buggy and will in some cases return an error when trying to get the fan state, but reading of the RPM values and the temperature sensors still works.
Does this error affects machine usage (e.g. freeze of CPU or some erratic fan behavior)? Or just kernel does not receive fan state and is unable to report meaningful value to userspace?
Quoted 42 lines
Signed-off-by Armin Wolf <[email protected]>--- Documentation/hwmon/dell-smm-hwmon.rst | 2 ++ drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 2 files changed, 9 insertions(+)Documentation/hwmon/dell-smm-hwmon.rst +2
-0@@ -360,6 +360,8 @@ Firmware Bug Affected Machines ======================================================= ================= Reading of fan states return spurious errors. Precision 490 + OptiPlex 7060 + Reading of fan types causes erratic fan behaviour. Studio XPS 8000 Studio XPS 8100drivers/hwmon/dell-smm-hwmon.c +7
-1@@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "MP061"), }, }, + { + .ident = "Dell OptiPlex 7060", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"), + }, + }, { .ident ="Dell Precision" , .matches = { --2.39.2
Am 28.06.24 um 23:57 schrieb Pali Rohár:
Quoted 7 lines · On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
Quoted 3 lines
The BIOS on this machine is buggy and will in some cases return an error when trying to get the fan state, but reading of the RPM values and the temperature sensors still works.
Does this error affects machine usage (e.g. freeze of CPU or some erratic fan behavior)? Or just kernel does not receive fan state and is unable to report meaningful value to userspace?
Basically, it seems that the BIOS will return an error if the to-be-returned fan state is less than 2. Everything else seems to work.
Thanks,
Armin Wolf
Quoted 41 lines
Quoted 41 lines
Signed-off-by Armin Wolf <[email protected]>--- Documentation/hwmon/dell-smm-hwmon.rst | 2 ++ drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 2 files changed, 9 insertions(+)Documentation/hwmon/dell-smm-hwmon.rst +2
-0@@ -360,6 +360,8 @@ Firmware Bug Affected Machines ======================================================= ================= Reading of fan states return spurious errors. Precision 490 + OptiPlex 7060 + Reading of fan types causes erratic fan behaviour. Studio XPS 8000 Studio XPS 8100drivers/hwmon/dell-smm-hwmon.c +7
-1@@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "MP061"), }, }, + { + .ident = "Dell OptiPlex 7060", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"), + }, + }, { .ident ="Dell Precision" , .matches = { --2.39.2
Quoted 6 lines · On Saturday 29 June 2024 00:43:08 Armin Wolf wrote:
Am 28.06.24 um 23:57 schrieb Pali Rohár:
Quoted 4 lines · On Friday 28 June 2024 23:47:23 Armin Wolf wrote:
Quoted 3 lines
The BIOS on this machine is buggy and will in some cases return an error when trying to get the fan state, but reading of the RPM values and the temperature sensors still works.
Quoted 6 lines
Quoted 3 lines
Does this error affects machine usage (e.g. freeze of CPU or some erratic fan behavior)? Or just kernel does not receive fan state and is unable to report meaningful value to userspace?
Basically, it seems that the BIOS will return an error if the to-be-returned fan state is less than 2. Everything else seems to work.
Ok, if there is no negative impact then fine for me.
Quoted 44 lines
Thanks,
Armin WolfQuoted 41 lines
Quoted 41 lines
Signed-off-by Armin Wolf <[email protected]>--- Documentation/hwmon/dell-smm-hwmon.rst | 2 ++ drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 2 files changed, 9 insertions(+)Documentation/hwmon/dell-smm-hwmon.rst +2
-0@@ -360,6 +360,8 @@ Firmware Bug Affected Machines ======================================================= ================= Reading of fan states return spurious errors. Precision 490 + OptiPlex 7060 + Reading of fan types causes erratic fan behaviour. Studio XPS 8000 Studio XPS 8100drivers/hwmon/dell-smm-hwmon.c +7
-1@@ -1263,6 +1263,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "MP061"), }, }, + { + .ident = "Dell OptiPlex 7060", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7060"), + }, + }, { .ident ="Dell Precision" , .matches = { --2.39.2
Quoted 7 lines · Armin Wolf
The BIOS on this machine is buggy and will in some cases return an error when trying to get the fan state, but reading of the RPM values and the temperature sensors still works.
Signed-off-by Armin Wolf <[email protected]>Acked-by Pali Rohár <[email protected]>
Applied.
Thanks,
Guenter